Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 56 56
Lines 2530 2530
Branches 144 144
=======================================
Hits 2325 2325
Misses 131 131
Partials 74 74 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
slayoo
reviewed
Sep 14, 2026
| set(PyPartMC_DIR "${PYPARTMC_CMAKE_DIR}") | ||
|
|
||
| find_package(PyPartMC REQUIRED) | ||
|
|
Member
There was a problem hiding this comment.
@orzel320, IIUC, this should not be needed as all these symbols should be inside the PyPartMC library. Also, since this is only happening on Windows, the fix should likely only modify what happens on Windows.
Removed nanobind configuration and linking from CMake.
Adjust nanobind_add_module call and link options for non-Windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have updated gcc version used in compilation to newest, since the error present in 16.1.0 seems to have been fixed in 16.2.0. I have also explicitly linked nanobind in readme_cpp CMakeLists. By doing this I think I have resolved #557.