Skip to content

fix(cfl): render static Chocolatey URLs - #491

Merged
rianjs merged 6 commits into
mainfrom
codex/cfl-choco-internalization
Sep 25, 2026
Merged

rianjs merged 6 commits into
mainfrom
codex/cfl-choco-internalization

Conversation

@rianjs

@rianjs rianjs commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Render literal AMD64 and ARM64 release URLs in confluence-cli packages, including the manual publisher, and inspect a rendered nupkg in Windows CI. This is the Chocolatey Business balloon: merge after shared workflow PR open-cli-collective/.github#48 is published to v1, release one new cfl version, then verify licensed internalization and offline install before rolling out other packages. Related: #482; keep the issue open until empirical confirmation.

@rianjs

rianjs commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Test coverage assessment — PR #491

Blocker

None.

Major

  • .github/workflows/test-chocolatey.yml:8-10,49-55 — The only new test hand-renders the template; it never runs the manual publisher transformation in .github/workflows/chocolatey-publish-cfl.yml:48-64. It would pass if that workflow generated a malformed URL, omitted a replacement, or reintroduced a runtime version expression. The test also does not run when a future PR changes only the publisher workflow because its path filter covers only tools/*/packaging/chocolatey/**. Exercise one shared rendering command with fixture inputs from both workflows, or test the publisher's exact transform and include its workflow path in the trigger.

  • .github/workflows/test-chocolatey.yml:69-76 — The packed-artifact checks prove only that both URL strings occur somewhere in the script. They pass if the ARM64 branch selects $urlAmd64 or the AMD64 branch selects $urlArm64 (tools/cfl/packaging/chocolatey/tools/chocolateyInstall.ps1:12-19). Run the rendered installer once per architecture with Install-ChocolateyZipPackage stubbed, and assert the captured URL/checksum pair.

Minor

  • .github/workflows/test-chocolatey.yml:51-54,69-76 — The test inserts artificial checksums and never asserts either rendered checksum. It therefore does not cover the requirement to preserve architecture-specific SHA256 values: a swapped or malformed value from the release-manifest extraction at .github/workflows/chocolatey-publish-cfl.yml:25-46 still passes. Use a small checksums.txt fixture and assert the exact values passed for AMD64 and ARM64.

Nit

None.

@rianjs
rianjs marked this pull request as ready for review September 25, 2026 15:33

@rianjs-bot rianjs-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 1ec6f0253587
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]

Summary

Reviewer Findings
automation:ci-release 0
policies:conventions 0
structure:repo-health 0

Reviewer Coverage

  • automation:ci-release — complete (broad); skipped: none; constraints: none
  • policies:conventions — complete (broad); skipped: none; constraints: Shared cli-common and organization automation convenience copies were not present locally; review used the available repository and cfl development guidance.
  • structure:repo-health — complete (broad); inspected 3 assigned files (4 inspected across reviewers): .github/workflows/chocolatey-publish-cfl.yml, .github/workflows/test-chocolatey.yml, tools/cfl/scripts/render-chocolatey-install.ps1; skipped: none; constraints: Review limited to the assigned Chocolatey publisher, test workflow, and renderer changes.
Inspected files (4)
  • .github/workflows/chocolatey-publish-cfl.yml
  • .github/workflows/test-chocolatey.yml
  • tools/cfl/packaging/chocolatey/tools/chocolateyInstall.ps1
  • tools/cfl/scripts/render-chocolatey-install.ps1

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 1m 42s | gpt-5.6-terra | cr 0.10.314
Field Value
Model gpt-5.6-terra
Reviewers automation:ci-release, policies:conventions, structure:repo-health
Engine codex_cli · gpt-5.6-terra
Reviewed by cr · rianjs-bot[bot]
Duration 1m 42s wall · 3m 08s compute
Cost unavailable
Tokens 494.6k in / 9.1k out

Per-workstream usage

  • orchestrator-selection — gpt-5.6-terra
    • In: 16.4k
    • Out: 343
    • Cache read: 11.0k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 9s
  • automation:ci-release — gpt-5.6-terra
    • In: 174.2k
    • Out: 3.6k
    • Cache read: 146.9k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 1m 14s
  • policies:conventions — gpt-5.6-terra
    • In: 129.3k
    • Out: 2.0k
    • Cache read: 103.2k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 44s
  • structure:repo-health — gpt-5.6-terra
    • In: 138.8k
    • Out: 2.7k
    • Cache read: 111.4k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 55s
  • orchestrator-rollup — gpt-5.6-terra
    • In: 35.8k
    • Out: 384
    • Cache read: 27.1k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 3s

@rianjs
rianjs merged commit e017b86 into main Sep 25, 2026
18 checks passed
@rianjs
rianjs deleted the codex/cfl-choco-internalization branch September 25, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant