Repository navigation
Conversation
…ons do The post-write issue view of these commands can now append the same Custom Fields section as issues get --custom-fields, so a custom field set with --field can be confirmed without a second command. The section builder moves to internal/present so the issues and transitions packages share it.
monit-reviewer
requested changes
Oct 13, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 2406d95a103c
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| architecture:solid-reviewer-agnostic | 1 |
architecture:solid-reviewer-agnostic (1 finding)
Major - tools/jtk/internal/present/custom_fields.go:17
U-S3 / U-D1:
AppendIssueCustomFieldsmoves cache reads and a possible liveGetFieldsnetwork call intointernal/present, whichdocs/development.mddescribes as the package that "owns output rendering". Until now present took data in and rendered it (refresh.gouses onlycachetypes, andprojection.ResolvetakesfetchFields func(context.Context) ([]api.Field, error)instead of reaching for the cache itself). This helper takes a concrete*api.Client, callscache.GetFieldsCacheFirstambiently and swallows the error, so the render layer now has hidden IO and cannot be unit-tested without an HTTP server. Later presenters are likely to copy it.Suggested fix: keep the shared code but split it along the existing seam. Either (a) give the helper the same injected shape
projection.Resolveuses:AppendIssueCustomFields(ctx, fetchFields func(context.Context) ([]api.Field, error), issue *api.Issue, model *present.OutputModel), with the commands passingfieldsFetcher(client)(already ininternal/cmd/issues/cache_helpers.go; transitions would need an equivalent or a shared cmd-side home); or (b) make present pure,AppendIssueCustomFieldsFrom(model, issue, fields []api.Field), and do the fetch in the command closures. Either option keeps the documented "section omitted when metadata cannot load" behavior in the caller, where the effect is visible.
Reviewer Coverage
go:implementation-tests— complete (broad); inspected 12 assigned files (14 inspected across reviewers):tools/jtk/internal/cmd/issues/assign.go,tools/jtk/internal/cmd/issues/assign_test.go,tools/jtk/internal/cmd/issues/create.go,tools/jtk/internal/cmd/issues/create_test.go,tools/jtk/internal/cmd/issues/custom_fields_mutation_test.go,tools/jtk/internal/cmd/issues/get.go,tools/jtk/internal/cmd/issues/update.go,tools/jtk/internal/cmd/issues/update_test.go,tools/jtk/internal/cmd/transitions/custom_fields_test.go,tools/jtk/internal/cmd/transitions/transitions.go,tools/jtk/internal/cmd/transitions/transitions_test.go,tools/jtk/internal/present/custom_fields.go; skipped: none; constraints: nonepolicies:conventions— complete (broad); inspected 6 assigned files (14 inspected across reviewers):tools/jtk/README.md,tools/jtk/internal/cmd/issues/assign.go,tools/jtk/internal/cmd/issues/create.go,tools/jtk/internal/cmd/issues/get.go,tools/jtk/internal/cmd/issues/update.go,tools/jtk/internal/cmd/transitions/transitions.go; skipped: none; constraints: No sibling ../cli-common/docs or ../.github checkouts present in this workbench, so shared Open CLI Collective standards docs were not directly consulted; relied on repo-local conventions visible in README.md, CHANGELOG.md and existing code.architecture:solid-reviewer-agnostic— complete (broad); inspected 7 assigned files (14 inspected across reviewers):tools/jtk/CHANGELOG.md,tools/jtk/internal/cmd/issues/assign.go,tools/jtk/internal/cmd/issues/create.go,tools/jtk/internal/cmd/issues/get.go,tools/jtk/internal/cmd/issues/update.go,tools/jtk/internal/cmd/transitions/transitions.go,tools/jtk/internal/present/custom_fields.go; skipped: none; constraints: Did not run make check or the test suite; reviewed the diff and surrounding package code statically.
Inspected files (14)
tools/jtk/CHANGELOG.mdtools/jtk/README.mdtools/jtk/internal/cmd/issues/assign.gotools/jtk/internal/cmd/issues/assign_test.gotools/jtk/internal/cmd/issues/create.gotools/jtk/internal/cmd/issues/create_test.gotools/jtk/internal/cmd/issues/custom_fields_mutation_test.gotools/jtk/internal/cmd/issues/get.gotools/jtk/internal/cmd/issues/update.gotools/jtk/internal/cmd/issues/update_test.gotools/jtk/internal/cmd/transitions/custom_fields_test.gotools/jtk/internal/cmd/transitions/transitions.gotools/jtk/internal/cmd/transitions/transitions_test.gotools/jtk/internal/present/custom_fields.go
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 2m 23s | ~$1.83 (est.) | claude-sonnet-5, claude-opus-5-5 | cr 0.10.319
| Field | Value |
|---|---|
| Model | claude-sonnet-5, claude-opus-5-5 |
| Reviewers | go:implementation-tests, policies:conventions, architecture:solid-reviewer-agnostic |
| Engine | claude_cli · claude-sonnet-5, claude-opus-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 2m 23s wall · 3m 40s compute |
| Cost | ~$1.83 (est.) |
| Pricing basis | anthropic-public-2026-09-23 |
| Tokens | 56 in / 12.2k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5- In: 6
- Out: 3.5k
- Cache read: 85.2k
- Cache create: 51.4k
- Cost: ~$0.26 (est.)
- Duration: 46s
go:implementation-tests— claude-sonnet-5- In: 10
- Out: 2.0k
- Cache read: 215.6k
- Cache create: 71.1k
- Cost: ~$0.35 (est.)
- Duration: 41s
policies:conventions— claude-sonnet-5- In: 18
- Out: 2.5k
- Cache read: 440.3k
- Cache create: 59.5k
- Cost: ~$0.35 (est.)
- Duration: 59s
architecture:solid-reviewer-agnostic— claude-opus-5-5- In: 16
- Out: 3.6k
- Cache read: 366.0k
- Cache create: 68.6k
- Cost: ~$0.69 (est.)
- Duration: 54s
orchestrator-rollup— claude-sonnet-5- In: 6
- Out: 549
- Cache read: 151.3k
- Cache create: 36.9k
- Cost: ~$0.18 (est.)
- Duration: 17s
monit-reviewer
approved these changes
Oct 13, 2026
monit-reviewer
left a comment
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 77c526f0a5fd
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| architecture:solid-reviewer-agnostic | 0 |
Reviewer Coverage
go:implementation-tests— complete (constrained); inspected 13 assigned files (15 inspected across reviewers):tools/jtk/internal/cmd/issues/assign.go,tools/jtk/internal/cmd/issues/assign_test.go,tools/jtk/internal/cmd/issues/create.go,tools/jtk/internal/cmd/issues/create_test.go,tools/jtk/internal/cmd/issues/custom_fields_mutation_test.go,tools/jtk/internal/cmd/issues/get.go,tools/jtk/internal/cmd/issues/update.go,tools/jtk/internal/cmd/issues/update_test.go,tools/jtk/internal/cmd/transitions/custom_fields_test.go,tools/jtk/internal/cmd/transitions/transitions.go,tools/jtk/internal/cmd/transitions/transitions_test.go,tools/jtk/internal/present/custom_fields.go,tools/jtk/internal/present/custom_fields_test.go; skipped: none; constraints: nonepolicies:conventions— complete (constrained); inspected 6 assigned files (15 inspected across reviewers):tools/jtk/README.md,tools/jtk/internal/cmd/issues/assign.go,tools/jtk/internal/cmd/issues/create.go,tools/jtk/internal/cmd/issues/get.go,tools/jtk/internal/cmd/issues/update.go,tools/jtk/internal/cmd/transitions/transitions.go; skipped: none; constraints: No sibling ../cli-common/docs or ../.github checkouts present in this workbench, so shared Open CLI Collective standards docs were not directly consulted; relied on repo-local conventions visible in README.md, CHANGELOG.md and existing code.architecture:solid-reviewer-agnostic— complete (constrained); inspected 7 assigned files (15 inspected across reviewers):tools/jtk/CHANGELOG.md,tools/jtk/internal/cmd/issues/assign.go,tools/jtk/internal/cmd/issues/create.go,tools/jtk/internal/cmd/issues/get.go,tools/jtk/internal/cmd/issues/update.go,tools/jtk/internal/cmd/transitions/transitions.go,tools/jtk/internal/present/custom_fields.go; skipped: none; constraints: Did not run make check or the test suite; reviewed the diff and surrounding package code statically. The earlier U-S3/U-D1 finding on present/custom_fields.go is resolved at 77c526f: the helper takes an injected fetchFields func, no longer imports cache, and has direct unit tests. The inline closure in transitions.go matches the existing sprints.go pattern.
Inspected files (15)
tools/jtk/CHANGELOG.mdtools/jtk/README.mdtools/jtk/internal/cmd/issues/assign.gotools/jtk/internal/cmd/issues/assign_test.gotools/jtk/internal/cmd/issues/create.gotools/jtk/internal/cmd/issues/create_test.gotools/jtk/internal/cmd/issues/custom_fields_mutation_test.gotools/jtk/internal/cmd/issues/get.gotools/jtk/internal/cmd/issues/update.gotools/jtk/internal/cmd/issues/update_test.gotools/jtk/internal/cmd/transitions/custom_fields_test.gotools/jtk/internal/cmd/transitions/transitions.gotools/jtk/internal/cmd/transitions/transitions_test.gotools/jtk/internal/present/custom_fields.gotools/jtk/internal/present/custom_fields_test.go
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 47s | ~$1.89 (est.) | claude-sonnet-5, claude-opus-5-5 | cr 0.10.319
| Field | Value |
|---|---|
| Model | claude-sonnet-5, claude-opus-5-5 |
| Reviewers | go:implementation-tests, policies:conventions, architecture:solid-reviewer-agnostic |
| Engine | claude_cli · claude-sonnet-5, claude-opus-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 47s wall · 2m 25s compute |
| Cost | ~$1.89 (est.) |
| Pricing basis | anthropic-public-2026-09-23 |
| Tokens | 34 in / 6.2k out |
Per-workstream usage
go:implementation-tests— claude-sonnet-5- In: 12
- Out: 2.1k
- Cache read: 461.9k
- Cache create: 98.4k
- Cost: ~$0.51 (est.)
- Duration: 48s
policies:conventions— claude-sonnet-5- In: 8
- Out: 1.8k
- Cache read: 225.0k
- Cache create: 83.1k
- Cost: ~$0.40 (est.)
- Duration: 46s
architecture:solid-reviewer-agnostic— claude-opus-5-5- In: 8
- Out: 1.9k
- Cache read: 277.8k
- Cache create: 100.7k
- Cost: ~$0.90 (est.)
- Duration: 34s
orchestrator-rollup— claude-sonnet-5- In: 6
- Out: 432
- Cache read: 193.4k
- Cache create: 11.1k
- Cost: ~$0.09 (est.)
- Duration: 15s
piekstra
marked this pull request as ready for review
October 13, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issues create,issues update,issues assignandtransitions doprint the issue after the write, but only the standard detail view. A custom field set with--field customfield_NNNNN=...could not be confirmed without a follow-upissues get --custom-fields.These four commands now take
--custom-fields, which appends the sameCustom Fields:sectionissues get --custom-fieldsshows: every non-emptycustomfield_*value, labeled with the field's name from the field cache.Behavior is unchanged without the flag. The section is appended inside each command's existing post-write fetch, so the retry schedule, the freshness checks, the fallback confirmation and
--idbehave as before. If field metadata cannot be loaded, the section is left out, as inissues get.Shared helper. The section builder moved from an unexported function in
issues/get.gotopresent.AppendIssueCustomFields, so theissuesandtransitionspackages use one implementation.issues getnow calls it too.Not changed:
sprints addandsprints removeprint a table, not a detail view; custom fields as table columns are already available onissues list,issues searchandsprints issuesthrough--fields "<field name>".Tests:
TestMutations_CustomFieldsFlag(create, update, assign, each with and without the flag) andTestRunDo_CustomFieldsFlag(transitions do). Existing call sites gain the new argument.make checkpasses (tidy, lint, tests, build).