Repository navigation
fix: keep install-step paths absolute in args - #22
Merged
Merged
Conversation
base: resolves only a run step's command path, not its args, so the
quarantine steps ran xattr on a bare name in the wrong working directory
and upgrades failed and reverted. Use the {{staged_path}} and {{appdir}}
template tokens in args, and convert the codereview-cli cask that a
later release re-emitted in the legacy form.
monit-reviewer
approved these changes
Sep 23, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 110f2b40ab7b
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| packaging:brew-tap-integrity | 0 |
Reviewer Coverage
packaging:brew-tap-integrity— complete (broad); skipped: none; constraints: none
Inspected files (18)
Casks/cfl.rbCasks/codereview-cli.rbCasks/cpm.rbCasks/google-readonly.rbCasks/google-readwrite.rbCasks/gro.rbCasks/grw.rbCasks/hubspot-cli.rbCasks/jira-ticket-cli.rbCasks/jtk.rbCasks/newrelic-cli.rbCasks/nrq.rbCasks/qlmarkdown2.rbCasks/salesforce-cli.rbCasks/slack-chat-cli.rbCasks/slck.rbCasks/spotify-cli.rbCasks/swiftmarkdown.rb
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 1m 20s | ~$0.77 (est.) | claude-sonnet-5 | cr 0.10.311
| Field | Value |
|---|---|
| Model | claude-sonnet-5 |
| Reviewers | packaging:brew-tap-integrity |
| Engine | claude_cli · claude-sonnet-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 1m 20s wall · 1m 12s compute |
| Cost | ~$0.77 (est.) |
| Pricing basis | anthropic-public-2026-09-02 |
| Tokens | 18 in / 2.8k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5- In: 6
- Out: 1.4k
- Cache read: 103.7k
- Cache create: 73.9k
- Cost: ~$0.33 (est.)
- Duration: 27s
packaging:brew-tap-integrity— claude-sonnet-5- In: 8
- Out: 1.1k
- Cache read: 187.3k
- Cache create: 75.5k
- Cost: ~$0.35 (est.)
- Duration: 26s
orchestrator-rollup— claude-sonnet-5- In: 4
- Out: 375
- Cache read: 108.3k
- Cache create: 15.7k
- Cost: ~$0.09 (est.)
- Duration: 17s
piekstra
marked this pull request as ready for review
September 23, 2026 17:25
piekstra
added a commit
that referenced
this pull request
Sep 23, 2026
…23) The google-cli 2.0.12 release started before `v1` included open-cli-collective/.github#47, so its casks (`gro`, `grw`, `google-readonly`, `google-readwrite`) came out with the bare-name quarantine step that fails and reverts `brew upgrade`. This applies the same `{{staged_path}}` form as #22. Later releases publish the corrected form from `v1`. `brew style --only-cops Cask/InstallSteps,Homebrew/OSDependsOn Casks/*.rb`: no offenses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base: :staged_path(orbase: :appdir) with a bare name inargs.base:resolves only theruncommand path, so xattr ran on a relative name, exited 1, andbrew upgradereverted every affected cask (xattr: No such file: gro).{{staged_path}}and{{appdir}}install-step template tokens, which Homebrew expands insideargs.codereview-cliwas re-published in the legacypostflight doform after the earlier migration, which fails this repo's CI style check on main; it is converted to the same token form.The generator fix is open-cli-collective/.github#47; until
v1includes it, the next release of a CLI re-publishes the broken form for that cask.Verification
brew upgrade --cask google-readonly1.2.7 -> 2.0.11 succeeds with the token form on Homebrew 7.0.6 and fails and reverts with the current cask.{{staged_path}}/gro->/opt/homebrew/Caskroom/google-readonly/2.0.11/gro,{{appdir}}/X.app->/Applications/X.app.brew style --only-cops Cask/InstallSteps,Homebrew/OSDependsOn Casks/*.rb: no offenses (main has one, in codereview-cli).