Skip to content

fix: keep install-step paths absolute in args - #22

Merged
piekstra merged 1 commit into
mainfrom
fix/install-step-args-paths
Sep 23, 2026
Merged

piekstra merged 1 commit into
mainfrom
fix/install-step-args-paths

Conversation

@piekstra

Copy link
Copy Markdown
Member

Summary

  • The quarantine steps used base: :staged_path (or base: :appdir) with a bare name in args. base: resolves only the run command path, so xattr ran on a relative name, exited 1, and brew upgrade reverted every affected cask (xattr: No such file: gro).
  • Args now use the {{staged_path}} and {{appdir}} install-step template tokens, which Homebrew expands inside args.
  • codereview-cli was re-published in the legacy postflight do form after the earlier migration, which fails this repo's CI style check on main; it is converted to the same token form.

The generator fix is open-cli-collective/.github#47; until v1 includes it, the next release of a CLI re-publishes the broken form for that cask.

Verification

  • brew upgrade --cask google-readonly 1.2.7 -> 2.0.11 succeeds with the token form on Homebrew 7.0.6 and fails and reverts with the current cask.
  • Both tokens expand against a real cask context: {{staged_path}}/gro -> /opt/homebrew/Caskroom/google-readonly/2.0.11/gro, {{appdir}}/X.app -> /Applications/X.app.
  • brew style --only-cops Cask/InstallSteps,Homebrew/OSDependsOn Casks/*.rb: no offenses (main has one, in codereview-cli).

base: resolves only a run step's command path, not its args, so the
quarantine steps ran xattr on a bare name in the wrong working directory
and upgrades failed and reverted. Use the {{staged_path}} and {{appdir}}
template tokens in args, and convert the codereview-cli cask that a
later release re-emitted in the legacy form.

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: 110f2b40ab7b
Profile: claude-monit-reviewer - Posting as: monit-reviewer

Summary

Reviewer Findings
packaging:brew-tap-integrity 0

Reviewer Coverage

  • packaging:brew-tap-integrity — complete (broad); skipped: none; constraints: none
Inspected files (18)
  • Casks/cfl.rb
  • Casks/codereview-cli.rb
  • Casks/cpm.rb
  • Casks/google-readonly.rb
  • Casks/google-readwrite.rb
  • Casks/gro.rb
  • Casks/grw.rb
  • Casks/hubspot-cli.rb
  • Casks/jira-ticket-cli.rb
  • Casks/jtk.rb
  • Casks/newrelic-cli.rb
  • Casks/nrq.rb
  • Casks/qlmarkdown2.rb
  • Casks/salesforce-cli.rb
  • Casks/slack-chat-cli.rb
  • Casks/slck.rb
  • Casks/spotify-cli.rb
  • Casks/swiftmarkdown.rb

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 1m 20s | ~$0.77 (est.) | claude-sonnet-5 | cr 0.10.311
Field Value
Model claude-sonnet-5
Reviewers packaging:brew-tap-integrity
Engine claude_cli · claude-sonnet-5
Reviewed by cr · monit-reviewer
Duration 1m 20s wall · 1m 12s compute
Cost ~$0.77 (est.)
Pricing basis anthropic-public-2026-09-02
Tokens 18 in / 2.8k out

Per-workstream usage

  • orchestrator-selection — claude-sonnet-5
    • In: 6
    • Out: 1.4k
    • Cache read: 103.7k
    • Cache create: 73.9k
    • Cost: ~$0.33 (est.)
    • Duration: 27s
  • packaging:brew-tap-integrity — claude-sonnet-5
    • In: 8
    • Out: 1.1k
    • Cache read: 187.3k
    • Cache create: 75.5k
    • Cost: ~$0.35 (est.)
    • Duration: 26s
  • orchestrator-rollup — claude-sonnet-5
    • In: 4
    • Out: 375
    • Cache read: 108.3k
    • Cache create: 15.7k
    • Cost: ~$0.09 (est.)
    • Duration: 17s

@piekstra
piekstra marked this pull request as ready for review September 23, 2026 17:25
@piekstra
piekstra merged commit cb7b3d7 into main Sep 23, 2026
1 check passed
@piekstra
piekstra deleted the fix/install-step-args-paths branch September 23, 2026 17:28
piekstra added a commit that referenced this pull request Sep 23, 2026
…23)

The google-cli 2.0.12 release started before `v1` included
open-cli-collective/.github#47, so its casks (`gro`, `grw`,
`google-readonly`, `google-readwrite`) came out with the bare-name
quarantine step that fails and reverts `brew upgrade`. This applies the
same `{{staged_path}}` form as #22. Later releases publish the corrected
form from `v1`.

`brew style --only-cops Cask/InstallSteps,Homebrew/OSDependsOn
Casks/*.rb`: no offenses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants