Repository navigation
fix: build with Go 1.26.10 for the eMudhra CA distrust - #213
Merged
Merged
Conversation
monit-reviewer
approved these changes
Oct 21, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: 5a708ccddc8d
Profile: claude-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| automation:ci-release | 0 |
| go:implementation-tests | 0 |
| policies:conventions | 0 |
| security:code-auditor | 0 |
Reviewer Coverage
automation:ci-release— complete (broad); skipped: none; constraints: Release workflow delegates to open-cli-collective/.github release.yml@v1, which is not checked out; could not verify it honors the go.mod toolchain directive. Repo has a single go.mod; .github/workflows/test-chocolatey.yml hardcodes go-version '1.26' (pre-existing, test-only build, not changed by this diff).go:implementation-tests— complete (broad); skipped: none; constraints: Did not run go build; reviewed the go.mod diff only. The repo has a single go.mod and no go.work.policies:conventions— complete (broad); skipped: none; constraints: Only go.mod was assigned; workflows were checked read-only for how they select the Go version. Shared cli-common docs were not in context, so only repo-visible conventions were checked.security:code-auditor— complete (broad); skipped: none; constraints: Could not independently verify that go1.26.10 contains the claimed eMudhra distrust fix; relied on the PR description. The repo has a single go.mod.
Inspected files (1)
go.mod
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 3m 51s | ~$0.74 (est.) | claude-sonnet-5-5 | cr 0.10.325
| Field | Value |
|---|---|
| Model | claude-sonnet-5-5 |
| Reviewers | automation:ci-release, go:implementation-tests, policies:conventions, security:code-auditor |
| Engine | claude_cli · claude-sonnet-5-5 |
| Reviewed by | cr · monit-reviewer |
| Duration | 3m 51s wall · 8m 07s compute |
| Cost | ~$0.74 (est.) |
| Pricing basis | baseline-2026-10-02/pricing |
| Tokens | 46 in / 6.3k out |
Per-workstream usage
orchestrator-selection— claude-sonnet-5-5- In: 4
- Out: 872
- Cache read: 28.8k
- Cache create: 23.4k
- Cost: ~$0.11 (est.)
- Duration: 57s
automation:ci-release— claude-sonnet-5-5- In: 12
- Out: 2.0k
- Cache read: 141.4k
- Cache create: 34.8k
- Cost: ~$0.19 (est.)
- Duration: 1m 54s
go:implementation-tests— claude-sonnet-5-5- In: 8
- Out: 970
- Cache read: 93.8k
- Cache create: 20.2k
- Cost: ~$0.11 (est.)
- Duration: 1m 44s
policies:conventions— claude-sonnet-5-5- In: 8
- Out: 1.1k
- Cache read: 72.8k
- Cache create: 32.2k
- Cost: ~$0.15 (est.)
- Duration: 1m 32s
security:code-auditor— claude-sonnet-5-5- In: 8
- Out: 890
- Cache read: 94.3k
- Cache create: 20.4k
- Cost: ~$0.11 (est.)
- Duration: 1m 27s
orchestrator-rollup— claude-sonnet-5-5- In: 6
- Out: 427
- Cache read: 118.0k
- Cache create: 10.8k
- Cost: ~$0.07 (est.)
- Duration: 31s
zzwong
marked this pull request as ready for review
October 21, 2026 00:48
Pin the Go toolchain to 1.26.10, which distrusts the compromised eMudhra intermediate keys (CVE-2026-111943), and read the Go version from go.mod in every setup-go step.
zzwong
force-pushed
the
zzwong/go-1.26.10-toolchain
branch
from
October 21, 2026 00:53
5a708cc to
5ff747b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
toolchain go1.26.10to every Go module so CI and release builds use Go 1.26.10. Go 1.26.10 and 1.27.3 add acrypto/x509distrust of the compromised eMudhra intermediate keys (CVE-2026-111943), which applies whatever root store the binary verifies against. Binaries built with earlier releases still accept certificates issued through those keys on Linux, where verification uses the system roots.actions/setup-gouses thetoolchaindirective in preference to thegodirective, so builds, tests and releases all pick it up. Thegolanguage version is unchanged.Verification
GOTOOLCHAIN=go1.26.10 go build ./...passes for every module.