This repository was archived by the owner on Aug 20, 2026. It is now read-only.
Repository navigation
build: Include frontend/.env.production in the build context - #547
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
==========================================
- Coverage 86.71% 86.66% -0.05%
==========================================
Files 27 27
Lines 2062 2062
==========================================
- Hits 1788 1787 -1
- Misses 274 275 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jpmckinney
force-pushed
the
dockerignore
branch
from
August 20, 2026 18:32
8faa6ea to
9a50d3f
Compare
Both images are built from the root of the repository, so Docker reads only the root .dockerignore. frontend/.dockerignore was never read, and the !.env.production exception in it did not apply, so vite build ran without VITE_API_URL, VITE_LOCALE and VITE_CURRENCY. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
jpmckinney
force-pushed
the
dockerignore
branch
from
August 20, 2026 18:34
9a50d3f to
71c867b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker-double.ymlbuilds both images withfile:and the default context, which is the root of the repository. Docker therefore looks for.dockerignore(orDockerfile_app.dockerignore/Dockerfile_static.dockerignore) at the root, and never readsfrontend/.dockerignore.That file held two rules the root file lacks:
!.env.production, an exception to**/.*. Without it,frontend/.env.productionis excluded from the context, sopnpm exec vite buildinDockerfile_staticruns with noVITE_*values:axios.tsgetsbaseURL: undefinedinstead of/api, andintl.tsgets an undefined locale and currency. The exception has to name the path relative to the context root, hence!frontend/.env.production.**/dist, so a localfrontend/distis no longer sent to the daemon and then overwritten by the build.This also deletes
frontend/.dockerignore, since nothing reads it, and dropspytest.inito match cookiecutter-django after open-contracting/software-development-handbook@66aad43.A build was not run to confirm the context contents (no Docker daemon available), so the first
Dockerfile_staticbuild on this branch is the check.Found while cleaning up the same dead
frontend/.dockerignorein pelican-frontend, where the root file was missing entirely.🤖 Generated with Claude Code