Skip to content
This repository was archived by the owner on Aug 20, 2026. It is now read-only.

build: Include frontend/.env.production in the build context - #547

Merged
jpmckinney merged 1 commit into
mainfrom
dockerignore
Aug 20, 2026
Merged

jpmckinney merged 1 commit into
mainfrom
dockerignore

Conversation

@jpmckinney

@jpmckinney jpmckinney commented Aug 20, 2026 •

Copy link
Copy Markdown
Member

docker-double.yml builds both images with file: and the default context, which is the root of the repository. Docker therefore looks for .dockerignore (or Dockerfile_app.dockerignore / Dockerfile_static.dockerignore) at the root, and never reads frontend/.dockerignore.

That file held two rules the root file lacks:

  • !.env.production, an exception to **/.*. Without it, frontend/.env.production is excluded from the context, so pnpm exec vite build in Dockerfile_static runs with no VITE_* values: axios.ts gets baseURL: undefined instead of /api, and intl.ts gets an undefined locale and currency. The exception has to name the path relative to the context root, hence !frontend/.env.production.
  • **/dist, so a local frontend/dist is no longer sent to the daemon and then overwritten by the build.

This also deletes frontend/.dockerignore, since nothing reads it, and drops pytest.ini to match cookiecutter-django after open-contracting/software-development-handbook@66aad43.

A build was not run to confirm the context contents (no Docker daemon available), so the first Dockerfile_static build on this branch is the check.

Found while cleaning up the same dead frontend/.dockerignore in pelican-frontend, where the root file was missing entirely.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Aug 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.66%. Comparing base (f10bf8d) to head (71c867b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #547      +/-   ##
==========================================
- Coverage   86.71%   86.66%   -0.05%     
==========================================
  Files          27       27              
  Lines        2062     2062              
==========================================
- Hits         1788     1787       -1     
- Misses        274      275       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Both images are built from the root of the repository, so Docker reads
only the root .dockerignore. frontend/.dockerignore was never read, and
the !.env.production exception in it did not apply, so vite build ran
without VITE_API_URL, VITE_LOCALE and VITE_CURRENCY.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@jpmckinney
jpmckinney merged commit e8184f3 into main Aug 20, 2026
14 of 16 checks passed
@jpmckinney
jpmckinney deleted the dockerignore branch August 20, 2026 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant