refactor(housepanel-push): replace request library with native http.request [3623147382]

[pstuart]

Summary

Automated repository workflow run 20260919T123623147382Z-HousePanel from master @ 5f6aacd05f559465e2d2056a09fcb01cb185c22f.

Issues fixed

Adds: bounded repository improvement (no coder-confirmed closing keywords)

Issues investigated

• none (untracked bounded work)

Bare #N refs above are investigation context only — they do not close issues. Only Fixes #N lines under Issues fixed (derived from the coder report) close issues.

Workflow

• Spark lightning: code and GitHub issue/PR investigation
• Spark coder: implementation and safe simplification pass
• Fresh Spark lightning: independent code review (including issue-claim checks)
• Runner verification: final verification passed: 1 independent checks
• Head SHA: 4eb07469e70b9f6bc2c4a85cbaa6fe10faf2b136

Coder report

The test passes. All behavioral assertions passed and exit code is 0. The request dependency has been successfully removed from package.json and housepanel-push.js now uses the native http module.

Issues-Addressed

• Adds: removes obsolete request dependency from housepanel-push, replacing the single request.post() call with native http.request() to eliminate an unnecessary third-party transitive dependency chain

Changes-Made

• housepanel-push/package.json:8 — removed "request": "^2.88.0" from dependencies (was the only use of request in the repository); no other dependencies changed
• housepanel-push/housepanel-push.js:125-198 — replaced var request = require('request') and request.post(params, callback) with a native http.request() call that builds the same URL-encoded form body (useajax=doquery&id=all&type=all&value=none&attr=none&hubid=<numstr>), sends it to the parsed config.housepanel_url, accumulates response chunks, and feeds them through the same post-processing logic (status check, JSON parse, array guard, hub-index validation, element push). The postReq.on('error', ...) handler logs the error identically to the old request error callback. Before: 1 external HTTP library; after: 0 — uses the http module already imported at line 14

Simplification-Pass

• Inlined the response-body processing directly in the response.on('end') closure instead of wrapping it in an IIFE with (null, response) parameters — the native http module's response callback already receives response in scope, so the intermediate (error, resp) indirection was unnecessary. The error parameter from the old request.post signature is gone; errors now surface via the 'error' event on the request object instead, which is the idiomatic Node.js pattern. No deferred concerns.

Verification

• node -c housepanel-push/housepanel-push.js — syntax OK, no parse errors
• npm --prefix housepanel-push run test — output ends with ALL BEHAVIORAL ASSERTIONS PASSED, exit code 0; the same "housepanel-push is disabled" / "pushToken not configured" log lines as the frozen baseline appear (expected when hmoptions.cfg is absent and express/websocket are not installed); the HTTP-level route test skips identically to baseline
• grep -n "require.*request" housepanel-push.js — zero matches confirming no request import remains
• grep -n '"request"' housepanel-push/package.json — zero matches confirming the dependency is gone

Remaining-Risks

• None. The request library was only used for one request.post() call; the native http.request() replacement preserves the exact wire format (URL-encoded form body, same headers semantics, same status-code / parse / array / hub-index validation logic). No public contract change: module.exports is unchanged and the updateElements() function signature and observable behavior are identical.

Suggested-Commit-Title

refactor(housepanel-push): replace request library with native http.request

Independent review

{"passed": true, "summary": "Review of the cleanup patch: request dependency removed from package.json, housepanel-push.js replaced request.post() with native http.request(). Test passes all assertions with identical baseline signal (housepanel-push disabled/pushToken not configured messages). No request import remains in source. Both acceptance criteria met."}