Skip to content

build: add gates to migrate to new nnsdk repo - #282

Merged
Pistonight merged 1 commit into
open-ead:masterfrom
Pistonight:new_sdk_repo_migration
Oct 11, 2026
Merged

Pistonight merged 1 commit into
open-ead:masterfrom
Pistonight:new_sdk_repo_migration

Conversation

@Pistonight

@Pistonight Pistonight commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

See open-ead/nnheaders#87

This PR plants the gates in place for downstream projects to start migrating

Once SMO and BOTW migrates, we will set it to OFF by default.

Then wait for some bake time and remove the settings eventually


This change is Reviewable

@Pistonight
Pistonight force-pushed the new_sdk_repo_migration branch from 9917cb4 to 89ff6b2 Compare September 23, 2026 08:20

@leoetlino leoetlino left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, not sure why SMO is failing tho?

@german77

Copy link
Copy Markdown
Contributor

Smo issues are unrelated to this PR and have been fixed if you rebuild on top of latest master

@Pistonight

Copy link
Copy Markdown
Member Author

Don't merge this yet, I will validate again everything works once the migration guide is finalized

@Pistonight

Copy link
Copy Markdown
Member Author

SMO might find extra things that require ifdef SEAD_USE_OLD_NNHEADERS_REPO; I didn't look through all the files, just fixed the ones that don't compile in BOTW

@Pistonight

Copy link
Copy Markdown
Member Author

Verified in SMO as well. If something is still broken then it's not used by SMO or BOTW

@Pistonight
Pistonight force-pushed the new_sdk_repo_migration branch from 82f8a90 to 478ca52 Compare October 11, 2026 02:32
@Pistonight
Pistonight merged commit f4178a2 into open-ead:master Oct 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants