worker: honour backend_factory when reporting the machine's backend - #12
Open
pradipta-lyzr wants to merge 1 commit into
Open
worker: honour backend_factory when reporting the machine's backend#12pradipta-lyzr wants to merge 1 commit into
pradipta-lyzr wants to merge 1 commit into
Conversation
run_worker read the backend name straight from select_backend("auto") before
the job loop, so a worker started with an explicit backend_factory still
insisted on resolving a real one — and raised "No training backend available"
on any box without mlx or torch installed. That is precisely the case
backend_factory exists to serve, and _run_job already honoured it; only
registration didn't.
This is why the two hub↔worker tests failed on main: they hand in a stub
backend to exercise the real _Link and the real socket without a training
stack, and never got past registration. They also cost 15 seconds each waiting
on a thread that had already died, so the CPU suite drops from ~25s to ~5s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
run_workerresolved the machine's backend name viaselect_backend("auto")atregistration time, ignoring an explicitly supplied
backend_factory.