Repository navigation
Dark-theme review follow-ups: Observability, Marketplace, Context Center and entity details #34976
Description
Source: Notion Dark Theme. Scope: Observability onward and related follow-ups.
Implementation and light/dark evidence: #34977
60 files: application, test, Playwright helper and visual-baseline changes (see the PR for the current list). Focused local E2E results are recorded in the PR; backend runs on localhost:8585. Submodule pointers are unchanged.
| Section | Issue | Fix |
|---|---|---|
| Observability | Import icon is invisible | Use a core import icon with semantic foreground in CSV actions. |
| Observability | Action column has a different hover color | Let sticky action cells inherit the table row hover and selected surface. |
| Observability | Selected test-level card keeps light colors | Use semantic brand background, border, and foreground for selection cards. |
| Observability | Group and recurring counts need 8px top/bottom padding | Add 8 px vertical padding to the incident group/count row. |
| Observability | Orange alert icons are too bold | Not fixed. Needs a dark-mode change to core FeaturedIcon; the core edit changed light mode app-wide and was reverted. |
| Observability | Alert inputs are centered below the description | Make alert configuration sections full width with consistent horizontal gutters. |
| Observability | SQL query card is wrong | Use semantic SQL editor surfaces/borders and a core copy control. |
| Observability | Collapsed submenu selected icons change blue tone on pointer exit and disagree with expanded submenu | Preserve selected icon foreground across collapsed/expanded AI submenus. |
| Data Marketplace | Style modal/form is legacy and close icon invisible | Use the core style-modal shell and tokenized controls, retaining icon/color form validation. |
| Data Marketplace | Asset cards and list background differ from Explore | Separate transparent list frames from raised shared asset cards. |
| Data Marketplace | White border and unequal side padding | Remove duplicate domain detail borders and align page gutters. |
| Data Marketplace | Announcement menu icon invisible | Use a core announcement icon in domain/data-product manage menus. |
| Data Marketplace | Page view switch buttons overlap | Use the shared core view switch without overlapping button dimensions. |
| Data Marketplace | Tree/detail area is black; cards need elevation | Separate domain tree/detail canvas from child card surfaces. |
| Data Marketplace | Domain/data-product cards need Explore-like backgrounds | Apply shared semantic domain/data-product card and container surfaces. |
| Context Center | Memory card lacks hover in both themes | Add semantic memory-row hover and focus-within surfaces. |
| Context Center | List menu hover needs horizontal inset | Inset knowledge/dashboard pillar row hover bounds. |
| Context Center | Light canvas background missing across tabs | Apply the Context Center canvas token across its tab/page containers. |
| Entity Details | Table profiler settings drawer looks wrong | Use the core profiler-settings drawer shell and gutters; keep legacy Select/TreeSelect popups inside its focus/accessibility boundary through each selector’s getPopupContainer. |
| Entity Details | Profiler body has a box-in-box layout | Remove duplicate profiler body fill/border and align tab padding. |
| Entity Details | Description card lacks elevation | Give the shared description card a raised surface against its parent. |
| Entity Details | Custom property cards lack a surface | Use core Card variant="elevated" for regular and compact custom-property cards and a transparent outer Box. |
| Entity Details | Task creation inputs need core controls | Retain the upstream Untitled task-form migration from #34854; update shared combobox helpers and verify label focus, validation, creation, and reassignment. |
| Entity Details | Asset list cards need a card background | Fix shared asset-card surfaces and transparent parent frames across entity lists. |
| Shared follow-up | Side drawers have layout, invisible editor, and inconsistent icons | Theme activity side drawers, entity summary, rich editor surfaces, and toolbar SVG foregrounds. |
| Shared follow-up | Task label needs primary blue; task cards need elevation | Use semantic brand task links and elevated task-feed card surfaces. |
| Shared follow-up | Description cards have white borders and need core treatment | Centralize description/editor semantic borders and remove duplicate caller frames. |
| Glossary | Reviewer select dropdown is not fully on Untitled components | Use core avatars, removable tags, edit button, and semantic selected/hover rows in the shared user/team picker. |
| Glossary | Reviewer picker footer clipped at the viewport edge | Let the popover dialog scroll within its viewport-capped height. |
| Classification | Dropdown cards blend into the side drawer | Not fixed. The caller-side popover restyle was reverted; needs a core overlay-surface change. |
| Classification | This page has to be updated with dark theme changes (CSV import screenshot) | Retain the upstream import-page migration from #34796 and replace the remaining invisible UploadFile glyph with the core UploadCloud01 icon. |
Not in any PR yet
- Entity Details: "Orange icon color looks odd" — new Notion item (source).
Governance items are tracked in open-metadata/openmetadata-collate#7154; Collate-side follow-ups in open-metadata/openmetadata-collate#7240 (PR open-metadata/openmetadata-collate#7241).
Metadata
Metadata
Assignees
Labels
Type
Projects
- Status
Activity
Fixes open-metadata#34976: Align dark-theme surfaces and controls acr…