Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
330f274
Fixes #34976: Align dark-theme surfaces and controls across shared UI
shah-harshit Oct 8, 2026
961cc1b
Fix active rich-editor glyph foreground
shah-harshit Oct 8, 2026
712c4cc
Use core tw-color tokens instead of om-color in dark-theme fixes
shah-harshit Oct 8, 2026
f318ed6
Merge remote-tracking branch 'origin/main' into shah-harshit/notion-o…
shah-harshit Oct 8, 2026
62ff5cc
Fix themed overlay contrast and assignee form compatibility
shah-harshit Oct 9, 2026
ef733a3
Merge remote-tracking branch 'origin/main' into shah-harshit/notion-o…
shah-harshit Oct 9, 2026
b5ead40
Fix reviewer picker, classification overlays and custom-property elev…
shah-harshit Oct 9, 2026
80f590b
Format shared task and approval browser helpers
shah-harshit Oct 9, 2026
35c8fb9
Merge remote-tracking branch 'origin/main' into shah-harshit/notion-o…
shah-harshit Oct 9, 2026
a303078
Organize profiler and domain imports
shah-harshit Oct 9, 2026
f828272
Use semantic surfaces and colors in Classic sidebar submenus
shah-harshit Oct 9, 2026
5472f5a
Keep profiler dropdowns inside the settings drawer
shah-harshit Oct 9, 2026
8e2e75e
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 9, 2026
6d11f7d
Fix dark-theme UI checkstyle and coverage failures
shah-harshit Oct 9, 2026
4a0c9ea
Merge main and resolve profiler layout conflict
shah-harshit Oct 9, 2026
c99d05d
Fix duplicated profiler settings field labels
shah-harshit Oct 9, 2026
71dac20
Merge remote-tracking branch 'origin/main' into shah-harshit/notion-o…
shah-harshit Oct 9, 2026
cd52d6d
Keep the reviewer picker footer reachable in short viewports
shah-harshit Oct 9, 2026
20f95de
Revert "Fix duplicated profiler settings field labels"
shah-harshit Oct 9, 2026
cac7694
Revert out-of-scope core and Classic sidebar changes
shah-harshit Oct 9, 2026
956408a
Remove accidentally committed watchman cookie
shah-harshit Oct 9, 2026
def7c97
Update Teams visual baseline for the core owner edit button
shah-harshit Oct 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions .github/playwright/impact-map.generated.json
Original file line number Diff line number Diff line change
Expand Up @@ -7611,14 +7611,6 @@
"playwright/e2e/Pages/AppStopRunModal.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Modals/StyleModal/StyleModal.component.tsx"
],
"specs": [
"playwright/e2e/Pages/DomainUIInteractions.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Modals/TourEndModal/TourEndModal.tsx"
Expand Down Expand Up @@ -12448,6 +12440,22 @@
"playwright/e2e/Pages/IntakeForm.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/AddKPIPage.tsx"
],
"specs": [
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/EditKPIPage.tsx"
],
"specs": [
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KnowledgeCenterFilterPage/KnowledgeCenterFilterPage.tsx"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,23 @@ test('Profiler settings survive a table reindex', async ({ browser }) => {
await page.getByTestId('profiler-setting-btn').click();
await page.getByTestId('profiler-settings-modal').waitFor();

// Body-portaled options are hidden by the modal's accessibility boundary.
// Check accessible options and keyboard selection inside the drawer.
const settings = page.getByRole('dialog', { name: 'Settings' });
const sampleType = settings.getByRole('combobox', {
name: 'Profile Sample type',
});
await settings.getByTestId('profile-sample').click();
await expect(
settings.getByRole('option', { name: 'Row Count', exact: true })
).toBeAttached();
await sampleType.press('ArrowDown');
await sampleType.press('Enter');
await expect(settings.getByTestId('metric-number-input')).toBeVisible();
await settings.getByTestId('profile-sample').click();
await sampleType.press('ArrowUp');
await sampleType.press('Enter');

await page.getByTestId('slider-input').clear();
await page.getByTestId('slider-input').fill(PROFILE_SAMPLE);
await page.getByTestId('sample-data-count-input').clear();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,15 @@ test.describe('Task Creation - Request Description', () => {
await expect(page.getByTestId('form-container')).toBeVisible();

// Assignee field - search and select user
const assigneeInput = page.locator('[data-testid="select-assignee"] input');
const assigneeInput = page
.getByTestId('select-assignee')
.getByRole('combobox');
await expect(assigneeInput).toHaveAccessibleName(/^Assignees\b/);
await page
.locator('label')
.filter({ hasText: /^Assignees\b/ })
.click();
await expect(assigneeInput).toBeFocused();
await assigneeInput.click();

// Search for user
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -1292,10 +1292,12 @@ export const createDescriptionTaskForGlossary = async (
);

await expect(
page.locator('[data-testid="select-assignee"] input')
page.getByTestId('select-assignee').getByRole('combobox')
).toBeDisabled();
} else {
const assigneeField = page.locator('[data-testid="select-assignee"] input');
const assigneeField = page
.getByTestId('select-assignee')
.getByRole('combobox');
await assigneeField.click();

const userSearchResponse = page.waitForResponse(
Expand Down Expand Up @@ -1342,11 +1344,13 @@ export const createTagTaskForGlossary = async (
);

await expect(
page.locator('[data-testid="select-assignee"] input')
page.getByTestId('select-assignee').getByRole('combobox')
).toBeDisabled();
} else {
// select assignee
const assigneeField = page.locator('[data-testid="select-assignee"] input');
const assigneeField = page
.getByTestId('select-assignee')
.getByRole('combobox');
await assigneeField.click();
const userSearchResponse = page.waitForResponse(
`/api/v1/search/query?q=*${value.assignee}**&index=user%2Cteam*`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ export const addAssigneeFromPopoverWidget = async (data: {

const assigneeModal = page.locator('.ant-modal-content').last();
const assigneeSelect = assigneeModal.getByTestId('select-assignee');
const assigneeInput = assigneeSelect.locator('input');
const assigneeInput = assigneeSelect.getByRole('combobox');
const assigneeOption = page.getByTestId(user.name).first();
const normalizedAssigneeOption = page
.getByTestId(user.name.toLowerCase())
Expand Down
12 changes: 8 additions & 4 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/task.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,12 @@ export const createDescriptionTask = async (
);

await expect(
page.locator('[data-testid="select-assignee"] input')
page.getByTestId('select-assignee').getByRole('combobox')
).toBeDisabled();
} else {
const assigneeField = page.locator('[data-testid="select-assignee"] input');
const assigneeField = page
.getByTestId('select-assignee')
.getByRole('combobox');
await assigneeField.click();
await assigneeField.fill(value.assignee);

Expand Down Expand Up @@ -163,11 +165,13 @@ export const createTagTask = async (
);

await expect(
page.locator('[data-testid="select-assignee"] input')
page.getByTestId('select-assignee').getByRole('combobox')
).toBeDisabled();
} else {
// select assignee
const assigneeField = page.locator('[data-testid="select-assignee"] input');
const assigneeField = page
.getByTestId('select-assignee')
.getByRole('combobox');
await assigneeField.click();
await assigneeField.fill(value.assignee);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ export const openTaskForm = async (page: Page, route: string) => {
};

export const selectAssignee = async (page: Page, assigneeName: string) => {
const assigneeInput = page.locator('[data-testid="select-assignee"] input');
const assigneeInput = page
.getByTestId('select-assignee')
.getByRole('combobox');
const assigneeOption = page.getByTestId(assigneeName);
const assigneeSearchResponse = page
.waitForResponse(
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,18 @@

.activity-feed-card-new {
border-radius: var(--om-radius-xl);
background: @grey-9;
background: var(--tw-color-bg-surface);
display: flex;
flex-direction: column;
flex-wrap: wrap;
width: inherit;

&.ant-card {
background: @grey-9;
background: var(--tw-color-bg-surface);
border-radius: var(--om-radius-xl);
margin-bottom: var(--om-space-20);
border: 0.5px solid @grey-15;
border: 1px solid var(--tw-color-border-subtle);
box-shadow: var(--om-shadow-card);
}

.ant-card-body {
Expand Down Expand Up @@ -66,7 +67,7 @@
.task-feed-card-v1-new {
.header-link {
word-wrap: break-word;
color: @primary-heading-color;
color: var(--tw-color-text-link);
font-weight: var(--om-font-weight-semibold);
display: inline;
}
Expand All @@ -84,8 +85,8 @@
border-radius: var(--om-radius-xl);
padding: var(--om-space-16);
margin: var(--om-space-20) 0 0 0;
background: @grey-9;
border: 0.5px solid @grey-15;
background: var(--tw-color-bg-surface);
border: 1px solid var(--tw-color-border-subtle);
input.ant-input,
textarea.ant-input {
border-radius: var(--om-radius-20);
Expand All @@ -102,8 +103,8 @@

.activity-feed-reply-button {
border-radius: var(--om-radius-3xl);
border: 1px solid var(--om-legacy-color-d4d4d8);
color: var(--om-legacy-color-52525b);
border: 1px solid var(--tw-color-border-secondary);
color: var(--tw-color-text-secondary);
font-size: var(--om-font-size-xs);
}
.comments-input-field {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,10 @@

&,
& a {
color: @primary-heading-color;
color: var(--tw-color-text-link);

&:hover {
color: @primary-heading-color;
color: var(--tw-color-text-link);
}
}
}
Expand All @@ -244,33 +244,36 @@
}

.activity-feed-editor-container-new {
background-color: @grey-9;
border: 0.5px solid @grey-15;
background-color: var(--tw-color-bg-surface);
border: 1px solid var(--tw-color-border-subtle);
border-radius: var(--om-radius-10);
width: 100%;

.ql-container {
background-color: @grey-9;
border: 1px solid @grey-15;
background-color: var(--tw-color-bg-surface);
border: none;
width: 100%;

&:focus-within {
border: 0.5px solid @grey-15;
outline: 1px solid var(--tw-color-border-brand);
outline-offset: -1px;
}
}

.ql-toolbar {
background-color: @grey-9;
border: 1px solid @grey-15;
background-color: var(--tw-color-bg-surface);
border: none;
border-bottom: 1px solid var(--tw-color-border-subtle);
flex-wrap: wrap;

&:focus-within {
border: 0.5px solid @grey-15;
outline: 1px solid var(--tw-color-border-brand);
outline-offset: -1px;
}
}

.ql-toolbar button {
color: var(--om-color-gray-true-800);
color: var(--tw-color-text-secondary);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -506,19 +506,19 @@
@media (pointer: coarse) {
.ql-snow.ql-toolbar button:hover:not(.ql-active),
.ql-snow .ql-toolbar button:hover:not(.ql-active) {
color: var(--om-legacy-color-444444);
color: var(--tw-color-text-secondary);
}
.ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-fill,
.ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-fill,
.ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-stroke.ql-fill,
.ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-stroke.ql-fill {
fill: var(--om-legacy-color-444444);
fill: var(--tw-color-text-secondary);
}
.ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-stroke,
.ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-stroke,
.ql-snow.ql-toolbar button:hover:not(.ql-active) .ql-stroke-miter,
.ql-snow .ql-toolbar button:hover:not(.ql-active) .ql-stroke-miter {
stroke: var(--om-legacy-color-444444);
stroke: var(--tw-color-text-secondary);
}
}
.ql-snow {
Expand Down Expand Up @@ -556,20 +556,20 @@
}
.ql-snow .ql-stroke {
fill: none;
stroke: var(--om-legacy-color-444444);
stroke: var(--tw-color-text-secondary);
stroke-linecap: round;
stroke-linejoin: round;
stroke-width: 2;
}
.ql-snow .ql-stroke-miter {
fill: none;
stroke: var(--om-legacy-color-444444);
stroke: var(--tw-color-text-secondary);
stroke-miterlimit: 10;
stroke-width: 2;
}
.ql-snow .ql-fill,
.ql-snow .ql-stroke.ql-fill {
fill: var(--om-legacy-color-444444);
fill: var(--tw-color-text-secondary);
}
.ql-snow .ql-empty {
fill: none;
Expand Down Expand Up @@ -643,7 +643,7 @@
max-width: 100%;
}
.ql-snow .ql-picker {
color: var(--om-legacy-color-444444);
color: var(--tw-color-text-secondary);
display: inline-block;
font-size: var(--om-font-size-sm);
font-weight: var(--om-font-weight-medium);
Expand Down
Loading
Loading