Repository navigation
Fixes open-metadata/openmetadata-collate#7317: dark-mode surfaces and borders render light #35271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
docs/decisions/2026-10-12-dark-mode-targets-ai-mode-core-surfaces-only.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Dark mode targets AI mode and core/Tailwind surfaces only | ||
|
|
||
| - **Status:** Accepted | ||
| - **Revisions:** v1 2026-10-12 (initial) | ||
| - **Deciders:** Harshit Shah | ||
| - **Guard:** reviewer | ||
| - **Related:** ADR:2026-10-11-migrated-antd-components-adopt-core-styling, open-metadata/openmetadata-collate#7317, open-metadata/OpenMetadata#35271 | ||
|
|
||
| ## Context | ||
| Dark-mode sweeps keep finding light edges and fills on antd components (`.ant-modal-header`, | ||
| `.ant-dropdown-menu`, `.ant-select-selector`, `.ant-collapse-item`) and on classic-mode chrome | ||
| such as the classic navbar search. Antd is being removed from the codebase component by component, | ||
| and classic (non-AI) mode is not going to ship a dark theme. Dark-mode work spent on either is | ||
| deleted by the migration that follows it. | ||
|
|
||
| ## Decision | ||
| Classic (non-AI) mode does not support dark mode, and antd-only surfaces are not themed for dark. | ||
| Dark-mode fixes target AI mode, rendered through `@openmetadata/ui-core-components` and Tailwind | ||
| (`tw:`) surfaces, plus non-antd legacy markup that AI mode renders. | ||
|
|
||
| - Do not add `.dark-mode` overrides, dark token swaps or `tw:dark:*` variants whose only effect is | ||
| on an `.ant-*` selector or an antd component. | ||
| - Do not fix classic-only chrome for dark mode. | ||
| - A shared legacy LESS variable (for example `@grey-15`) may be bridged for dark when non-antd | ||
| surfaces in AI mode use it, even though antd consumers pick the change up too. | ||
| - An antd surface that looks wrong in dark is fixed by migrating it to its core equivalent. | ||
|
|
||
| ## Consequences | ||
| Antd screens and classic mode can look unfinished in dark until they migrate; that is accepted. | ||
| Dark-mode PRs stay small and their fixes survive the antd removal. Revisit if classic mode is | ||
| kept and given a dark theme, or if the antd removal stops before the remaining surfaces are migrated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -91,7 +91,6 @@ | |
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| white-space: nowrap; | ||
| max-width: 95%; | ||
| } | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.