Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
b41ba6e
feat(ui): migrate standalone antd Select and Input to core components
shah-harshit Oct 12, 2026
58d862f
fix(ui): let Enter reach core comboboxes in the SSO form
shah-harshit Oct 12, 2026
8458474
test(ui): fix e2e fallout from the core Select/Input migration
shah-harshit Oct 12, 2026
8a38022
fix(ui): keep the lineage search text when the combobox loses focus
shah-harshit Oct 12, 2026
725a8c9
fix(ui-core): truncate long chips instead of overflowing narrow fields
shah-harshit Oct 13, 2026
43c9c9e
chore(ui): refresh lint baselines after rebasing onto main
shah-harshit Oct 13, 2026
07e8684
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 13, 2026
bbfab20
test(ui): refresh the glossary visual baseline for the core modal, bu…
shah-harshit Oct 13, 2026
3395dd6
chore(ui): refresh lint baselines after rebasing onto main
shah-harshit Oct 13, 2026
95c825c
test(ui): click Customize UI cards by test id
shah-harshit Oct 13, 2026
6e120f3
test(ui): scope Customize UI card lookups and use the core lineage se…
shah-harshit Oct 13, 2026
379c34e
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 13, 2026
d49bf5a
test(ui): pick the Data Quality "All" test type from the open dropdown
shah-harshit Oct 13, 2026
41f4fff
feat(ui): move simple modal forms from antd Form to core HookForm
shah-harshit Oct 13, 2026
073b3c0
feat(ui): move config, policy, rule and role forms to core HookForm
shah-harshit Oct 13, 2026
77e0c7e
feat(ui): move email, team, bot auth and create-user forms to core Ho…
shah-harshit Oct 13, 2026
9fa4f3f
feat(ui): move persona form to core and reuse the core field value bo…
shah-harshit Oct 13, 2026
298d9ae
feat(ui): move team email and subscription forms to core HookForm
shah-harshit Oct 13, 2026
282586c
feat(ui): share the core custom property form and permission debugger…
shah-harshit Oct 13, 2026
fb0f147
feat(ui): move the theme settings form to core HookForm
shah-harshit Oct 13, 2026
e447977
feat(ui): share the core learning resource fields with the classic dr…
shah-harshit Oct 13, 2026
6d8697d
feat(ui): move the data asset rule form to core HookForm
shah-harshit Oct 13, 2026
bf40686
feat(ui): move query and KPI forms to core HookForm; let RHF own Hook…
shah-harshit Oct 13, 2026
965d466
feat(ui): move lineage config and table constraint forms to core Hook…
shah-harshit Oct 13, 2026
efb89a0
feat(ui): move the task form settings page to core HookForm
shah-harshit Oct 13, 2026
9710c18
fix(ui): keep typed rule conditions and render the bot form fields
shah-harshit Oct 13, 2026
3b4bd42
chore(ui): refresh lint baselines after rebasing onto the updated base
shah-harshit Oct 13, 2026
6943bbe
fix(ui): visual fixes from the form migration review
shah-harshit Oct 13, 2026
aaad83c
fix(ui): cap percentage KPI targets and record the form migration rules
shah-harshit Oct 13, 2026
dc51e62
test(ui): pick token expiry from the core Select in user helpers
shah-harshit Oct 13, 2026
996fb13
fix(ui): keep the learning resource drawer open while picking options
shah-harshit Oct 13, 2026
16a7d6d
feat(ui): move TeamTypeSelect and ColorPicker to core components
shah-harshit Oct 13, 2026
e477b5c
feat(ui): move the query table picker and classic term boosts to core
shah-harshit Oct 13, 2026
951ecf8
test(ui): wait for any table search when picking the query's tables
shah-harshit Oct 13, 2026
a989e91
fix(ui): keep query table picks and name each theme colour input
shah-harshit Oct 13, 2026
91a9fe8
fix(ui): keep the theme colour swatch a full-size native colour input
shah-harshit Oct 13, 2026
9fe342b
chore(ui): refresh the positional-locator baseline after rebasing ont…
shah-harshit Oct 13, 2026
e83df6c
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 13, 2026
883ce75
fix(ui): re-read the lineage config each time its modal opens
shah-harshit Oct 13, 2026
3d9879a
fix(ui): address self-review on the form migration
shah-harshit Oct 13, 2026
d5bdec8
chore(ui): run CI's i18n sync checks in make ui-checkstyle-changed
shah-harshit Oct 13, 2026
136f28a
Revert "chore(ui): run CI's i18n sync checks in make ui-checkstyle-ch…
shah-harshit Oct 13, 2026
5611e96
test(ui): fix the lineage view-mode and custom property E2E steps
shah-harshit Oct 13, 2026
7788e56
fix(ui-core): keep the toggle track full width next to long hint text
shah-harshit Oct 13, 2026
ca9f5cf
chore(ui): refresh lint baselines after rebasing onto main
shah-harshit Oct 13, 2026
2f6e61a
Merge remote-tracking branch 'origin/main' into w35280
shah-harshit Oct 14, 2026
149d127
Merge remote-tracking branch 'origin/main' into w35280b
shah-harshit Oct 14, 2026
d287b5a
fix(ui): let the optional Task Category be cleared again
shah-harshit Oct 14, 2026
1b79b4e
Merge remote-tracking branch 'origin/main' into shah-harshit/antd-sel…
shah-harshit Oct 14, 2026
d736686
test(playwright): refresh visual-regression baselines after merging main
shah-harshit Oct 14, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 24 additions & 180 deletions .github/playwright/impact-map.generated.json
Original file line number Diff line number Diff line change
Expand Up @@ -6971,16 +6971,6 @@
"playwright/e2e/Pages/Lineage/LineageInteraction.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityLineage/LineageConfigModal.tsx"
],
"specs": [
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Flow/LineageSettings.spec.ts",
"playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityLineage/LineageControlButtons/LineageControlButtons.tsx"
Expand Down Expand Up @@ -7252,22 +7242,11 @@
"openmetadata-ui/src/main/resources/ui/src/components/GlobalSearchBar/GlobalSearchBar.tsx"
],
"specs": [
"playwright/e2e/Features/DomainFilterQueryFilter.spec.ts",
"playwright/e2e/Features/ExploreFilterComposition.spec.ts",
"playwright/e2e/Features/ExploreQuickFilters.spec.ts",
"playwright/e2e/Features/ExploreUrlState.spec.ts",
"playwright/e2e/Features/GlobalSearchSuggestions.spec.ts",
"playwright/e2e/Features/SearchIndexNestedColumns.spec.ts",
"playwright/e2e/Flow/ExploreAggregationCountsMatching.spec.ts",
"playwright/e2e/Flow/ExploreDiscovery.spec.ts",
"playwright/e2e/Flow/GlobalSearch.spec.ts",
"playwright/e2e/Flow/MetricSearch.spec.ts",
"playwright/e2e/Flow/Navbar.spec.ts",
"playwright/e2e/Flow/Tour.spec.ts",
"playwright/e2e/Pages/CustomProperties.spec.ts",
"playwright/e2e/Pages/ExploreBrowse.spec.ts",
"playwright/e2e/Pages/ExploreTree.spec.ts",
"playwright/e2e/Search/SearchNightly.spec.ts",
"playwright/e2e/Search/SearchRelevance.spec.ts"
]
},
Expand Down Expand Up @@ -7656,14 +7635,6 @@
"playwright/e2e/Pages/Tag.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithFunctionEditor/ModalWithFunctionEditor.tsx"
],
"specs": [
"playwright/e2e/Pages/Lineage/LineageInteraction.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx"
Expand Down Expand Up @@ -8185,64 +8156,13 @@
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/SearchSettings/FieldValueBoostModal/FieldValueBoostModal.tsx"
],
"specs": [
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/SearchSettings/GlobalSettingsItem/GlobalSettingsItem.tsx"
],
"specs": [
"playwright/e2e/Pages/Domains.spec.ts",
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/SearchSettings/SearchPreview/SearchPreview.tsx"
],
"specs": [
"playwright/e2e/Features/AIMode/ConnectionServiceDetails.spec.ts",
"playwright/e2e/Features/ColumnSorting.spec.ts",
"playwright/e2e/Features/Container.spec.ts",
"playwright/e2e/Features/DataAssetRulesEnabled.spec.ts",
"playwright/e2e/Features/DataQuality/DataQuality.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseSoftDeleteRestore.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryAssets.spec.ts",
"playwright/e2e/Features/ImpactAnalysis.spec.ts",
"playwright/e2e/Features/LandingPageWidgets/DomainDataProductsWidgets.spec.ts",
"playwright/e2e/Features/MetricAssets.spec.ts",
"playwright/e2e/Features/OnlineUsers.spec.ts",
"playwright/e2e/Features/Pagination.spec.ts",
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Features/SchemaSearch.spec.ts",
"playwright/e2e/Features/Table.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Flow/SchemaTable.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileMembers.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileTeam.spec.ts",
"playwright/e2e/Pages/Bots.spec.ts",
"playwright/e2e/Pages/BotsProfile.spec.ts",
"playwright/e2e/Pages/DataContracts.spec.ts",
"playwright/e2e/Pages/DataProductAndSubdomains.spec.ts",
"playwright/e2e/Pages/DomainAdvanced.spec.ts",
"playwright/e2e/Pages/DomainUIInteractions.spec.ts",
"playwright/e2e/Pages/Domains.spec.ts",
"playwright/e2e/Pages/InputOutputPorts.spec.ts",
"playwright/e2e/Pages/SearchSettings.spec.ts",
"playwright/e2e/Pages/ServiceEntity.spec.ts",
"playwright/e2e/Pages/ServiceListing.spec.ts",
"playwright/e2e/Pages/Teams.spec.ts",
"playwright/e2e/Pages/TestSuite.spec.ts",
"playwright/e2e/Pages/TestSuiteDetailsPage.spec.ts",
"playwright/e2e/Pages/UserDetails.spec.ts",
"playwright/e2e/Pages/Users.spec.ts",
"playwright/e2e/Search/SearchRelevance.spec.ts"
]
},
Expand Down Expand Up @@ -8455,8 +8375,11 @@
"specs": [
"playwright/e2e/Features/AccessControlSettings.spec.ts",
"playwright/e2e/Features/IncidentManager.spec.ts",
"playwright/e2e/Features/SSOConfiguration.spec.ts",
"playwright/e2e/Features/Tasks/TaskAssigneeManagement.spec.ts",
"playwright/e2e/Pages/CustomProperties.spec.ts"
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/CustomProperties.spec.ts",
"playwright/e2e/Pages/Users.spec.ts"
]
},
{
Expand All @@ -8472,8 +8395,7 @@
"openmetadata-ui/src/main/resources/ui/src/components/Settings/Email/EmailConfigForm/EmailConfigForm.component.tsx"
],
"specs": [
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Pages/EmailConfiguration.spec.ts"
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts"
]
},
{
Expand All @@ -8484,6 +8406,15 @@
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Settings/Persona/CustomizeUI/CustomizeUI.tsx"
],
"specs": [
"playwright/e2e/Features/CustomizeDetailPage.spec.ts",
"playwright/e2e/Pages/DataContracts.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Settings/Services/AddIngestion/AddIngestion.component.tsx"
Expand Down Expand Up @@ -8719,7 +8650,6 @@
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileMembers.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileUser.spec.ts",
"playwright/e2e/Pages/BotsProfile.spec.ts",
"playwright/e2e/Pages/DataContracts.spec.ts"
]
},
Expand Down Expand Up @@ -10969,6 +10899,14 @@
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/discovery/personal-space/Profile/tabs/platform-settings/search/FieldValueBoostDialog.tsx"
],
"specs": [
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/discovery/personal-space/Profile/tabs/platform-settings/search/FieldValueBoostTable.tsx"
Expand Down Expand Up @@ -12534,14 +12472,6 @@
"playwright/e2e/Pages/DataProducts.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/Configuration/EditUrlConfiguration/EditUrlConfigurationPage.tsx"
],
"specs": [
"playwright/e2e/Pages/OmdURLConfiguration.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/Configuration/LoginConfigurationDetails/LoginConfigurationPage.tsx"
Expand Down Expand Up @@ -12781,22 +12711,6 @@
"playwright/e2e/Pages/IntakeForm.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/AddKPIPage.tsx"
],
"specs": [
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/EditKPIPage.tsx"
],
"specs": [
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KnowledgeCenterFilterPage/KnowledgeCenterFilterPage.tsx"
Expand All @@ -12810,10 +12724,6 @@
"openmetadata-ui/src/main/resources/ui/src/pages/LearningResourcesPage/LearningResourceForm.component.tsx"
],
"specs": [
"playwright/e2e/Features/IncidentManager.spec.ts",
"playwright/e2e/Features/ProfileGovernance.spec.ts",
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Pages/GlossaryTermRelationSettings.spec.ts",
"playwright/e2e/Pages/LearningResources.spec.ts"
]
},
Expand All @@ -12833,8 +12743,7 @@
"specs": [
"playwright/e2e/Features/MetricHierarchy.spec.ts",
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Flow/LineageSettings.spec.ts",
"playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts"
"playwright/e2e/Flow/LineageSettings.spec.ts"
]
},
{
Expand Down Expand Up @@ -12912,8 +12821,7 @@
"openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/AddPolicyPage/AddPolicyPage.tsx"
],
"specs": [
"playwright/e2e/Features/AccessControlSettings.spec.ts",
"playwright/e2e/Pages/Policies.spec.ts"
"playwright/e2e/Features/AccessControlSettings.spec.ts"
]
},
{
Expand All @@ -12935,15 +12843,6 @@
"playwright/e2e/Pages/Policies.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/RuleForm/RuleForm.tsx"
],
"specs": [
"playwright/e2e/Features/AccessControlSettings.spec.ts",
"playwright/e2e/Pages/Policies.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/ProfilerConfigurationPage/ProfilerConfigurationPage.tsx"
Expand All @@ -12958,25 +12857,6 @@
"openmetadata-ui/src/main/resources/ui/src/pages/RolesPage/AddAttributeModal/AddAttributeModal.tsx"
],
"specs": [
"playwright/e2e/Features/ContextCenterDocument.spec.ts",
"playwright/e2e/Features/ContextCenterMemories.spec.ts",
"playwright/e2e/Features/DataQuality/CertificationFilter.spec.ts",
"playwright/e2e/Features/DataQuality/DataObservabilityGovernanceTab.spec.ts",
"playwright/e2e/Features/DataQuality/DataQuality.spec.ts",
"playwright/e2e/Features/DataQuality/DataQualityDashboard.spec.ts",
"playwright/e2e/Features/DomainFilterQueryFilter.spec.ts",
"playwright/e2e/Features/ExploreFilterComposition.spec.ts",
"playwright/e2e/Features/ExploreQuickFilters.spec.ts",
"playwright/e2e/Features/ExploreSortOrderFilter.spec.ts",
"playwright/e2e/Features/ExploreUrlState.spec.ts",
"playwright/e2e/Features/IncidentManager.spec.ts",
"playwright/e2e/Features/NestedColumnsExpandCollapse.spec.ts",
"playwright/e2e/Features/SearchExport.spec.ts",
"playwright/e2e/Flow/ExploreDiscovery.spec.ts",
"playwright/e2e/Pages/AuditLogs.spec.ts",
"playwright/e2e/Pages/DataContracts.spec.ts",
"playwright/e2e/Pages/DataProductCertificationFilter.spec.ts",
"playwright/e2e/Pages/Lineage/LineageFilters.spec.ts",
"playwright/e2e/Pages/Roles.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts"
]
Expand All @@ -12987,20 +12867,8 @@
],
"specs": [
"playwright/e2e/Features/AccessControlSettings.spec.ts",
"playwright/e2e/Features/EntityRenameConsolidation.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMiscOperations.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMutualExclusivityDataProductTree.spec.ts",
"playwright/e2e/Features/MetricCustomUnitFlow.spec.ts",
"playwright/e2e/Features/MetricHierarchy.spec.ts",
"playwright/e2e/Features/MultipleRename.spec.ts",
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileTeam.spec.ts",
"playwright/e2e/Pages/DataProductAndSubdomains.spec.ts",
"playwright/e2e/Pages/EditClassification.spec.ts",
"playwright/e2e/Pages/IntakeForm.spec.ts",
"playwright/e2e/Pages/Roles.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts",
"playwright/e2e/Pages/Teams.spec.ts"
]
},
Expand Down Expand Up @@ -13254,30 +13122,6 @@
"playwright/e2e/Pages/GlossaryImportExport.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/TeamsPage/AddTeamForm.tsx"
],
"specs": [
"playwright/e2e/Features/AIMode/Observability.spec.ts",
"playwright/e2e/Features/DataQuality/TestLibrary.spec.ts",
"playwright/e2e/Features/EntityRenameConsolidation.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMiscOperations.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMutualExclusivityDataProductTree.spec.ts",
"playwright/e2e/Features/MetricCustomUnitFlow.spec.ts",
"playwright/e2e/Features/MetricHierarchy.spec.ts",
"playwright/e2e/Features/MultipleRename.spec.ts",
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileTeam.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileUser.spec.ts",
"playwright/e2e/Pages/BotsProfile.spec.ts",
"playwright/e2e/Pages/DataProductAndSubdomains.spec.ts",
"playwright/e2e/Pages/EditClassification.spec.ts",
"playwright/e2e/Pages/IntakeForm.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/TestSuiteDetailsPage/TestSuiteDetailsPage.component.tsx"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Classic settings forms reuse the AI-mode core form when one exists

- **Status:** Accepted
- **Revisions:** v1 2026-10-13 (initial)
- **Deciders:** Harshit Shah
- **Guard:** reviewer
- **Related:** ADR:2026-10-11-antd-imports-are-frozen-by-eslint-suppressions, ADR:2026-10-11-migrated-antd-components-adopt-core-styling, open-metadata/OpenMetadata#35285

## Context
Several classic settings pages (access-control rules, field value boosts, the permission
debugger, custom properties, learning resources) had an antd form while AI mode already had a
`@openmetadata/ui-core-components` version of the same form with the same payload. Migrating the
classic copy to core in place would leave two core forms for one entity, with fields,
validation and payload mapping that drift apart over time.

## Decision
When a classic form migrates off antd and AI mode already has a core version of that form, the
classic page renders the shared AI component and the antd copy is deleted. If the AI form is
embedded in an AI-only page shell, its fields and payload mapping are extracted into a shared
component, hook or `*.utils.ts` that both pages use (for example `CustomPropertyFormFields`,
`useLearningResourceFields`). A second core copy of the form is not written.

## Consequences
One place to change a form's fields, validation and payload, at the cost of classic pages
taking the AI form's layout. Classic-only behaviour (a doc side panel, a drawer shell) stays in
the classic page around the shared fields. Revisit if classic and AI forms are meant to diverge
for the same entity.
Loading
Loading