Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
138 changes: 12 additions & 126 deletions .github/playwright/impact-map.generated.json
Original file line number Diff line number Diff line change
Expand Up @@ -6969,16 +6969,6 @@
"playwright/e2e/Pages/Lineage/LineageInteraction.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityLineage/LineageConfigModal.tsx"
],
"specs": [
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Flow/LineageSettings.spec.ts",
"playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Entity/EntityLineage/LineageControlButtons/LineageControlButtons.tsx"
Expand Down Expand Up @@ -7645,14 +7635,6 @@
"playwright/e2e/Pages/Tag.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithFunctionEditor/ModalWithFunctionEditor.tsx"
],
"specs": [
"playwright/e2e/Pages/Lineage/LineageInteraction.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx"
Expand Down Expand Up @@ -8116,14 +8098,6 @@
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/SearchSettings/FieldValueBoostModal/FieldValueBoostModal.tsx"
],
"specs": [
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/SearchSettings/SearchPreview/SearchPreview.tsx"
Expand Down Expand Up @@ -8363,8 +8337,7 @@
"openmetadata-ui/src/main/resources/ui/src/components/Settings/Email/EmailConfigForm/EmailConfigForm.component.tsx"
],
"specs": [
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Pages/EmailConfiguration.spec.ts"
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts"
]
},
{
Expand Down Expand Up @@ -8615,17 +8588,11 @@
"openmetadata-ui/src/main/resources/ui/src/components/Settings/Users/CreateUser/CreateUser.component.tsx"
],
"specs": [
"playwright/e2e/Features/ContextCenterPermission.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryDisplayNameEdit.spec.ts",
"playwright/e2e/Features/QueryEntity.spec.ts",
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileMembers.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileUser.spec.ts",
"playwright/e2e/Pages/BotsProfile.spec.ts",
"playwright/e2e/Pages/DataContracts.spec.ts",
"playwright/e2e/Pages/EditClassification.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts"
"playwright/e2e/Pages/DataContracts.spec.ts"
]
},
{
Expand Down Expand Up @@ -10893,6 +10860,14 @@
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/discovery/personal-space/Profile/tabs/platform-settings/search/FieldValueBoostDialog.tsx"
],
"specs": [
"playwright/e2e/Pages/SearchSettings.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/discovery/personal-space/Profile/tabs/platform-settings/search/FieldValueBoostTable.tsx"
Expand Down Expand Up @@ -12464,14 +12439,6 @@
"playwright/e2e/Pages/DataProducts.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/Configuration/EditUrlConfiguration/EditUrlConfigurationPage.tsx"
],
"specs": [
"playwright/e2e/Pages/OmdURLConfiguration.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/Configuration/LoginConfigurationDetails/LoginConfigurationPage.tsx"
Expand Down Expand Up @@ -12713,36 +12680,6 @@
"playwright/e2e/Pages/IntakeForm.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/AddKPIPage.tsx"
],
"specs": [
"playwright/e2e/Features/ContextCenterPermission.spec.ts",
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryDisplayNameEdit.spec.ts",
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/BotsProfile.spec.ts",
"playwright/e2e/Pages/EditClassification.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KPIPage/EditKPIPage.tsx"
],
"specs": [
"playwright/e2e/Features/ContextCenterPermission.spec.ts",
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryDisplayNameEdit.spec.ts",
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/BotsProfile.spec.ts",
"playwright/e2e/Pages/EditClassification.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/KnowledgeCenterFilterPage/KnowledgeCenterFilterPage.tsx"
Expand All @@ -12756,10 +12693,6 @@
"openmetadata-ui/src/main/resources/ui/src/pages/LearningResourcesPage/LearningResourceForm.component.tsx"
],
"specs": [
"playwright/e2e/Features/IncidentManager.spec.ts",
"playwright/e2e/Features/ProfileGovernance.spec.ts",
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Pages/GlossaryTermRelationSettings.spec.ts",
"playwright/e2e/Pages/LearningResources.spec.ts"
]
},
Expand All @@ -12779,8 +12712,7 @@
"specs": [
"playwright/e2e/Features/MetricHierarchy.spec.ts",
"playwright/e2e/Features/ProfilePlatformSettings.spec.ts",
"playwright/e2e/Flow/LineageSettings.spec.ts",
"playwright/e2e/Pages/Lineage/PlatformLineage.spec.ts"
"playwright/e2e/Flow/LineageSettings.spec.ts"
]
},
{
Expand Down Expand Up @@ -12858,8 +12790,7 @@
"openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/AddPolicyPage/AddPolicyPage.tsx"
],
"specs": [
"playwright/e2e/Features/AccessControlSettings.spec.ts",
"playwright/e2e/Pages/Policies.spec.ts"
"playwright/e2e/Features/AccessControlSettings.spec.ts"
]
},
{
Expand All @@ -12881,15 +12812,6 @@
"playwright/e2e/Pages/Policies.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/PoliciesPage/RuleForm/RuleForm.tsx"
],
"specs": [
"playwright/e2e/Features/AccessControlSettings.spec.ts",
"playwright/e2e/Pages/Policies.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/ProfilerConfigurationPage/ProfilerConfigurationPage.tsx"
Expand All @@ -12914,20 +12836,8 @@
],
"specs": [
"playwright/e2e/Features/AccessControlSettings.spec.ts",
"playwright/e2e/Features/EntityRenameConsolidation.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMiscOperations.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMutualExclusivityDataProductTree.spec.ts",
"playwright/e2e/Features/MetricCustomUnitFlow.spec.ts",
"playwright/e2e/Features/MetricHierarchy.spec.ts",
"playwright/e2e/Features/MultipleRename.spec.ts",
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileTeam.spec.ts",
"playwright/e2e/Pages/DataProductAndSubdomains.spec.ts",
"playwright/e2e/Pages/EditClassification.spec.ts",
"playwright/e2e/Pages/IntakeForm.spec.ts",
"playwright/e2e/Pages/Roles.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts",
"playwright/e2e/Pages/Teams.spec.ts"
]
},
Expand Down Expand Up @@ -13181,30 +13091,6 @@
"playwright/e2e/Pages/GlossaryImportExport.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/TeamsPage/AddTeamForm.tsx"
],
"specs": [
"playwright/e2e/Features/AIMode/Observability.spec.ts",
"playwright/e2e/Features/DataQuality/TestLibrary.spec.ts",
"playwright/e2e/Features/EntityRenameConsolidation.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMiscOperations.spec.ts",
"playwright/e2e/Features/Glossary/GlossaryMutualExclusivityDataProductTree.spec.ts",
"playwright/e2e/Features/MetricCustomUnitFlow.spec.ts",
"playwright/e2e/Features/MetricHierarchy.spec.ts",
"playwright/e2e/Features/MultipleRename.spec.ts",
"playwright/e2e/Flow/AddRoleAndAssignToUser.spec.ts",
"playwright/e2e/Flow/PersonaFlow.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileTeam.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileUser.spec.ts",
"playwright/e2e/Pages/BotsProfile.spec.ts",
"playwright/e2e/Pages/DataProductAndSubdomains.spec.ts",
"playwright/e2e/Pages/EditClassification.spec.ts",
"playwright/e2e/Pages/IntakeForm.spec.ts",
"playwright/e2e/Pages/Tags.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/pages/TestSuiteDetailsPage/TestSuiteDetailsPage.component.tsx"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ test('the app config never suppresses a migrated component', async () => {

// Exact, so re-running --suppress-rule cannot quietly absorb new antd usage.
// Lower this when a PR removes antd imports and prunes the baseline.
const EXPECTED_SUPPRESSED_ANTD_SYMBOLS = 357;
const EXPECTED_SUPPRESSED_ANTD_SYMBOLS = 346;
const suppressedSymbols = Object.values(suppressions).reduce(
(total, rules) =>
total + (rules['openmetadata-antd/no-antd-import']?.count ?? 0),
Expand Down
30 changes: 0 additions & 30 deletions openmetadata-ui/src/main/resources/ui/eslint-suppressions.json
Original file line number Diff line number Diff line change
Expand Up @@ -1008,21 +1008,6 @@
"count": 1
}
},
"src/components/Database/TableQueries/QueryCard.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 1
}
},
"src/components/Database/TableQueries/QueryUsedByOtherTable/QueryUsedByOtherTable.component.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 1
}
},
"src/components/Database/TableQueries/TableQueries.interface.ts": {
"openmetadata-antd/no-antd-import": {
"count": 1
}
},
"src/components/Database/TableQueries/TableQueries.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 3
Expand Down Expand Up @@ -1188,11 +1173,6 @@
"count": 1
}
},
"src/components/SearchSettings/TermBoost/TermBoost.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 3
}
},
"src/components/ServiceInsights/AgentsStatusWidget/AgentsStatusWidget.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 1
Expand Down Expand Up @@ -1343,11 +1323,6 @@
"count": 1
}
},
"src/components/common/ColorPicker/ColorPicker.component.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 2
}
},
"src/components/common/DatePicker/DatePicker.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 2
Expand Down Expand Up @@ -1483,11 +1458,6 @@
"count": 1
}
},
"src/components/common/TeamTypeSelect/TeamTypeSelect.component.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 3
}
},
"src/components/common/UserTeamSelectableListSearchInput/UserTeamSelectableListSearchInput.component.tsx": {
"openmetadata-antd/no-antd-import": {
"count": 1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,14 +201,18 @@ test('Query Entity', async ({ page }) => {
await page.click(CODE_EDITOR_LINE, { clickCount: 3 });
await page.keyboard.press('Backspace');
await page.keyboard.type(`${queryData.queryUsedIn.table1}`);
await page.click('[data-testid="edit-query-used-in"]');
const tableSearchResponse = page.waitForResponse(
'/api/v1/search/query?q=*&index=table*'
(response) =>
response.url().includes('/api/v1/search/query') &&
response.url().includes('index=table')
);
await page.keyboard.type(queryData.queryUsedIn.table2);
await page
.getByTestId('edit-query-used-in')
.getByRole('combobox')
.fill(queryData.queryUsedIn.table2);
await tableSearchResponse;
await page
.locator('.ant-select-dropdown:visible .ant-select-item-option')
.getByRole('option')
.filter({
has: page.getByText(queryData.queryUsedIn.table2, { exact: true }),
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import {
Typography,
} from '@openmetadata/ui-core-components';
import { Copy01 } from '@openmetadata/ui-core-components/icons';
import { DefaultOptionType } from 'antd/lib/select';
import classNames from 'classnames';
import { isUndefined, split } from 'lodash';
import { Duration } from 'luxon';
Expand All @@ -41,6 +40,7 @@ import {
} from '../../../constants/Query.constant';
import { CSMode } from '../../../enums/codemirror.enum';
import { EntityTabs, EntityType } from '../../../enums/entity.enum';
import { EntityReference } from '../../../generated/type/entityReference';
import { useClipboard } from '../../../hooks/useClipBoard';
import useCustomLocation from '../../../hooks/useCustomLocation/useCustomLocation';
import { useFqn } from '../../../hooks/useFqn';
Expand Down Expand Up @@ -86,7 +86,7 @@ const QueryCard: FC<QueryCardProp> = ({
query: query.query,
isLoading: false,
});
const [selectedTables, setSelectedTables] = useState<DefaultOptionType[]>();
const [selectedTables, setSelectedTables] = useState<EntityReference[]>();

const { isAllowExpand, queryDate } = useMemo(() => {
const queryArr = split(query.query, '\n');
Expand Down Expand Up @@ -130,21 +130,7 @@ const QueryCard: FC<QueryCardProp> = ({
const updatedData = {
...query,
query: query.query !== sqlQuery.query ? sqlQuery.query : query.query,
queryUsedIn: isUndefined(selectedTables)
? query.queryUsedIn
: selectedTables.map((option) => {
const existingTable = query.queryUsedIn?.find(
(table) => table.id === option.value
);

return (
existingTable ?? {
id: (option.value as string) ?? '',
displayName: option.labelName as string,
type: EntityType.TABLE,
}
);
}),
queryUsedIn: selectedTables ?? query.queryUsedIn,
};
if (query.query !== sqlQuery.query || !isUndefined(selectedTables)) {
await onQueryUpdate(updatedData, 'query');
Expand Down
Loading
Loading