Repository navigation
docs: correct dark-mode brand-primary and brand-border values in color reference - #35395
Closed
detail-app[bot] wants to merge 1 commit into
Closed
detail-app[bot] wants to merge 1 commit into
detail-app[bot] wants to merge 1 commit into
Conversation
detail-app
Bot
requested review from
ShaileshParmar11,
chirag-madlani and
karanh37
as code owners
October 14, 2026 01:38
Contributor
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
7 tasks done
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates four stale Dark-token rows in
openmetadata-ui/.../docs/colors.md(Color Usage Handbook) so they match the dark palette shifted by 5ffed97:
tw:bg-brand-primarydark: "Brand 500 at 14%" -> "Brand 600 at 20%"tw:border-branddark:#53b1fd(brand-400) ->#1570ef(brand-600)tw:bg-brand-primarydark:#2e90fa(brand-500) ->#1570ef(brand-600)tw:border-branddark:#53b1fd(brand-400) ->#1570ef(brand-600)(the source tokens in
globals.cssalready changed; the spec files werealready updated by the same commit; only this living color handbook lagged).
Example: a developer styling a focused input with
tw:border-brandin darkmode following the handbook would expect a
brand-400-blue border (#53b1fd),but since 5ffed97 actually renders
#1570ef(brand-600). Likewise a new brandtint surface built off the §2.1 row would have been designed against the old
Brand 500 at 14%instead of the currentBrand 600 at 20%, looking washedout against the rest of the dark UI palette.
Introduced by commit 5ffed97 (@shah-harshit, #35290)
Describe your changes:
Fixes # (no issue — pure doc drift raised by the change).
I corrected four stale dark-mode token values in the Color Usage Handbook
(
openmetadata-ui/src/main/resources/ui/docs/colors.md) because commit5ffed97 shifted
--color-bg-brand-primaryand--color-border-branddarkvalues in
globals.cssbut the handbook still listed the old recipes/hexes.Type of change:
High-level design:
N/A — single-file doc sync (4 rows across 3 sections of one handbook).
Tests:
Not applicable — no code change; values verified against
globals.cssdarkoverrides and the contract test (
theme-contract.test.js) updated by thesame commit.
UI screen recording:
Not applicable — documentation-only change, no UI behavior or styling change.
Checklist:
Fixes #<issue-number>above. (N/A — doc drift, no issue.)Doc Drift PRs can be configured here.