Skip to content

docs: correct dark-mode brand-primary and brand-border values in color reference - #35395

Closed
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-dark-mode-brand-primary-and-brand-bor-85f741
Closed

detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-dark-mode-brand-primary-and-brand-bor-85f741

Conversation

@detail-app

@detail-app detail-app Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Updates four stale Dark-token rows in openmetadata-ui/.../docs/colors.md
(Color Usage Handbook) so they match the dark palette shifted by 5ffed97:

  • §2.1 tw:bg-brand-primary dark: "Brand 500 at 14%" -> "Brand 600 at 20%"
  • §2.3 tw:border-brand dark: #53b1fd (brand-400) -> #1570ef (brand-600)
  • §2.6 tw:bg-brand-primary dark: #2e90fa (brand-500) -> #1570ef (brand-600)
  • §2.6 tw:border-brand dark: #53b1fd (brand-400) -> #1570ef (brand-600)
    (the source tokens in globals.css already changed; the spec files were
    already updated by the same commit; only this living color handbook lagged).

Example: a developer styling a focused input with tw:border-brand in dark
mode following the handbook would expect a brand-400-blue border (#53b1fd),
but since 5ffed97 actually renders #1570ef (brand-600). Likewise a new brand
tint surface built off the §2.1 row would have been designed against the old
Brand 500 at 14% instead of the current Brand 600 at 20%, looking washed
out against the rest of the dark UI palette.

Introduced by commit 5ffed97 (@shah-harshit, #35290)

Describe your changes:

Fixes # (no issue — pure doc drift raised by the change).

I corrected four stale dark-mode token values in the Color Usage Handbook
(openmetadata-ui/src/main/resources/ui/docs/colors.md) because commit
5ffed97 shifted --color-bg-brand-primary and --color-border-brand dark
values in globals.css but the handbook still listed the old recipes/hexes.

Type of change:

  • Documentation

High-level design:

N/A — single-file doc sync (4 rows across 3 sections of one handbook).

Tests:

Not applicable — no code change; values verified against globals.css dark
overrides and the contract test (theme-contract.test.js) updated by the
same commit.

UI screen recording:

Not applicable — documentation-only change, no UI behavior or styling change.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above. (N/A — doc drift, no issue.)
  • I have added tests (unit / integration / Playwright as applicable) and listed them above. (N/A — docs-only.)

Doc Drift PRs can be configured here.

@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@shah-harshit

Copy link
Copy Markdown
Contributor

Folded into #35294 (commit 8e149d4), which also owns the dark token sources. The bg-brand-primary quick-reference row there reads "Brand 600 at 20%" rather than a solid #1570ef, matching globals.css. Closing in favour of #35294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant