Skip to content

[2.0] test(playwright): stop collapsing auto-expanded glossary terms in GlossaryMutualExclusivity - #35399

Merged
anuj-kumary merged 1 commit into
2.0from
fix/2.0-glossary-me-autoexpand
Oct 14, 2026
Merged

anuj-kumary merged 1 commit into
2.0from
fix/2.0-glossary-me-autoexpand

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Describe your changes:

GlossaryMutualExclusivity.spec.ts fails 10 of 12 tests on the 2.0 AUT run (nightly 38492535608, postgresql 1.12.14 ➡ 2.0). Children never become visible after expanding a parent term in the glossary picker.

Root cause: #35287 (backport of the #35287) made TreeAsyncSelectList search expand every level via findExpandableKeysForArray. Each test searches, then clicks the parent's expand-icon — which now collapses the already-open parent and hides the children it asserts on. The trace confirms the search response carries the children; the failure snapshot shows the tree with the parent closed.

Fix: remove the 12 post-search expand-icon clicks. The parent-visible assertions stay, so the tests still prove the hierarchy renders.

Type of change:

  • Bug fix (test)

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation> — no issue; AUT failure fix
  • The change is test-only

Testing

  • Prettier and tsc clean on the spec.
  • Not run locally against a 2.0 build (no 2.0 stack available); validate via the 2.0 AUT / Playwright CI.

🤖 Generated with Claude Code

…in GlossaryMutualExclusivity

#34955 made the term picker search expand every level, so the spec's
expand-icon clicks now collapse the parent and hide the children it
asserts on. Drop the clicks; search already opens every parent.
@anuj-kumary
anuj-kumary requested a review from a team as a code owner October 14, 2026 04:40
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added the UI UI specific issues label Oct 14, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@anuj-kumary anuj-kumary self-assigned this Oct 14, 2026
@gitar-bot

gitar-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · Removing redundant Playwright expansion clicks only adjusts glossary test setup; it leaves product behavior and interfaces unchanged.

Removes 12 post-search expand-icon clicks from GlossaryMutualExclusivity.spec.ts that were collapsing auto-expanded glossary parent terms and hiding the children under test. Parent-visible assertions remain, and no product code is touched. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@anuj-kumary anuj-kumary added the safe to test Add this label to run secure Github workflows on PRs label Oct 14, 2026
@anuj-kumary
anuj-kumary merged commit decf53b into 2.0 Oct 14, 2026
92 of 97 checks passed
@anuj-kumary
anuj-kumary deleted the fix/2.0-glossary-me-autoexpand branch October 14, 2026 05:22

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants