Repository navigation
[2.0] test(playwright): stop collapsing auto-expanded glossary terms in GlossaryMutualExclusivity - #35399
Conversation
…in GlossaryMutualExclusivity #34955 made the term picker search expand every level, so the spec's expand-icon clicks now collapse the parent and hide the children it asserts on. Drop the clicks; search already opens every parent.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Code Review ✅ Approved🟢 Low risk · Removing redundant Playwright expansion clicks only adjusts glossary test setup; it leaves product behavior and interfaces unchanged. Removes 12 post-search VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
GlossaryMutualExclusivity.spec.tsfails 10 of 12 tests on the 2.0 AUT run (nightly 38492535608, postgresql 1.12.14 ➡ 2.0). Children never become visible after expanding a parent term in the glossary picker.Root cause: #35287 (backport of the #35287) made
TreeAsyncSelectListsearch expand every level viafindExpandableKeysForArray. Each test searches, then clicks the parent'sexpand-icon— which now collapses the already-open parent and hides the children it asserts on. The trace confirms the search response carries the children; the failure snapshot shows the tree with the parent closed.Fix: remove the 12 post-search
expand-iconclicks. The parent-visible assertions stay, so the tests still prove the hierarchy renders.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>— no issue; AUT failure fixTesting
tscclean on the spec.🤖 Generated with Claude Code