Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
d3868cf
refactor(ui): delete the dead antd form-field factory and its antd-on…
shah-harshit Oct 15, 2026
d1de267
refactor(ui): move the remaining antd date pickers to core
shah-harshit Oct 15, 2026
eb8a46c
refactor(ui): move the CSV grid's antd selects to core
shah-harshit Oct 15, 2026
3c3864f
refactor(ui): build the classic notification alert form on react-hook…
shah-harshit Oct 15, 2026
1b72f0b
refactor(ui): serve notification alerts from the observability alert …
shah-harshit Oct 15, 2026
0ebbe99
refactor(ui): drop the antd popup-container ConfigProviders
shah-harshit Oct 15, 2026
c08d8c7
chore(ui): lock Form, Select, Input and DatePicker out of antd
shah-harshit Oct 15, 2026
f24d9af
style(ui): organize imports in the migrated date-filter callers
shah-harshit Oct 15, 2026
6a2d8b7
test(ui): guard the metric enum editor before rendering it
shah-harshit Oct 15, 2026
772933d
fix(ui): draw the navbar search as one field again
shah-harshit Oct 15, 2026
6e2f886
Merge remote-tracking branch 'origin/main' into shah-harshit/6884-ant…
shah-harshit Oct 15, 2026
559c668
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 15, 2026
8fae811
refactor(ui): replace AntDConfigProvider with a theme CSS-variable hook
shah-harshit Oct 15, 2026
616561b
Merge remote-tracking branch 'origin/shah-harshit/6884-antd-tail' int…
shah-harshit Oct 15, 2026
e32c0a3
chore(ui): drop antd and its rc-* stack from the bootstrap allow-list
shah-harshit Oct 15, 2026
6369027
fix(ui): drop theme CSS variables a saved theme clears
shah-harshit Oct 15, 2026
01946ff
refactor(ui): share the date-range filter and picker helpers; tighten…
shah-harshit Oct 15, 2026
14822e0
fix(ui): restore sidebar label size and row spacing on core NavItem
shah-harshit Oct 15, 2026
b2657ee
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 15, 2026
d0d8a6c
Merge branch 'main' into shah-harshit/6884-antd-tail
shah-harshit Oct 15, 2026
e00233c
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 15, 2026
40a2fd0
test(playwright): wait for the Following card to mount, not its grid …
shah-harshit Oct 15, 2026
3dfda24
build(ui): raise the emitted-chunk ceiling for the antd removal
shah-harshit Oct 15, 2026
67badb2
fix(ui): match the classic sidebar to the pre-migration look
shah-harshit Oct 15, 2026
34083c5
fix(ui): let the classic sidebar sit on the page background
shah-harshit Oct 15, 2026
1015fa3
fix(ui): match classic sidebar rest icon and label colour
shah-harshit Oct 15, 2026
7e34cb4
Merge remote-tracking branch 'origin/shah-harshit/sidebar-messed-up-f…
shah-harshit Oct 15, 2026
a011e85
fix(ui): commit the CSV entity type on pick and end enum edits on close
shah-harshit Oct 15, 2026
d44af08
fix(ui): render href-less sidebar items such as Logout as a button
shah-harshit Oct 15, 2026
47db1d2
test(ui): refresh classic-sidebar visual baselines
shah-harshit Oct 15, 2026
cb2144e
test(ui): refresh table-details schema visual baseline
shah-harshit Oct 15, 2026
a8764b0
Merge remote-tracking branch 'origin/main' into shah-harshit/6884-ant…
shah-harshit Oct 15, 2026
6773f33
fix(ui): match the dark login panel to Collate's
shah-harshit Oct 15, 2026
8bf2998
Merge remote-tracking branch 'origin/main' into shah-harshit/6884-ant…
shah-harshit Oct 15, 2026
7a212fb
Merge remote-tracking branch 'origin/main' into shah-harshit/6884-ant…
shah-harshit Oct 16, 2026
c3e6c19
test(ui-core): cover Button onFocus/onBlur forwarding
shah-harshit Oct 16, 2026
1db2e56
fix(ui): address Sonar and lint findings on the antd tail
shah-harshit Oct 16, 2026
7a3a9ed
Merge branch 'main' into shah-harshit/6884-antd-tail
shah-harshit Oct 16, 2026
c791db4
test(ui): refresh landing-page-sidebar-collapsed baseline after main'…
shah-harshit Oct 16, 2026
d18d080
Merge remote-tracking branch 'origin/main' into shah-harshit/6884-ant…
shah-harshit Oct 16, 2026
a555f02
Merge remote-tracking branch 'origin/main' into shah-harshit/6884-ant…
shah-harshit Oct 16, 2026
e8ab529
fix(ui): commit date picks on Apply, keep borderless focus, swap sing…
shah-harshit Oct 16, 2026
f54a592
fix(ui): keep enum popovers inside the custom-property editor; let a …
shah-harshit Oct 16, 2026
bf934ea
Merge remote-tracking branch 'origin/main' into shah-harshit/6884-ant…
shah-harshit Oct 16, 2026
cd72bd5
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 16, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .github/playwright/impact-map.generated.json
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,7 @@
"playwright/e2e/Features/DataQuality/Profiler.spec.ts",
"playwright/e2e/Features/DataQuality/ProfilerIngestionForm.spec.ts",
"playwright/e2e/Features/DataQuality/RunTestCase.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseImportExportBasic.spec.ts",
Expand Down Expand Up @@ -1711,6 +1712,7 @@
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/RunTestCase.spec.ts",
"playwright/e2e/Features/DataQuality/TableLevelTests.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseCrudAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
Expand Down Expand Up @@ -2024,6 +2026,7 @@
"playwright/e2e/Features/DataAssetRulesEnabled.spec.ts",
"playwright/e2e/Features/DataQuality/ProfilerIngestionForm.spec.ts",
"playwright/e2e/Features/DataQuality/TableLevelTests.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/ExploreQuickFilters.spec.ts",
"playwright/e2e/Features/IngestionListNameSorting.spec.ts",
"playwright/e2e/Features/LandingPageWidgets/LandingPagePlatformHealth.spec.ts",
Expand Down Expand Up @@ -3074,6 +3077,7 @@
"playwright/e2e/Features/DataQuality/Profiler.spec.ts",
"playwright/e2e/Features/DataQuality/ProfilerIngestionForm.spec.ts",
"playwright/e2e/Features/DataQuality/RunTestCase.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseImportExportBasic.spec.ts",
Expand Down Expand Up @@ -3296,6 +3300,7 @@
"playwright/e2e/Features/AdvancedSearch.spec.ts",
"playwright/e2e/Features/ContextCenterDashboard.spec.ts",
"playwright/e2e/Features/DataQuality/IncidentManagerSqlQuery.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DomainFilterQueryFilter.spec.ts",
"playwright/e2e/Features/LandingPageWidgets/LandingPageContextCenter.spec.ts",
"playwright/e2e/Features/LandingPageWidgets/LandingPageCriticalAnnouncements.spec.ts",
Expand Down Expand Up @@ -3486,6 +3491,7 @@
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/RunTestCase.spec.ts",
"playwright/e2e/Features/DataQuality/TableLevelTests.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseCrudAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
Expand Down Expand Up @@ -3935,7 +3941,6 @@
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseIncidentPermissions.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseResultPermissions.spec.ts",
"playwright/e2e/Pages/AuditLogs.spec.ts",
"playwright/e2e/Pages/DataContractsSemanticRules.spec.ts",
"playwright/e2e/Pages/DataInsightSettings.spec.ts",
"playwright/e2e/Pages/Entity.spec.ts",
Expand Down Expand Up @@ -4102,6 +4107,7 @@
"playwright/e2e/Features/DataQuality/DataQualityListAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/DataQualityPermissions.spec.ts",
"playwright/e2e/Features/DataQuality/IncidentManagerDateFilter.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseImportExportBasic.spec.ts",
Expand Down Expand Up @@ -4835,6 +4841,7 @@
"playwright/e2e/Features/AIMode/ConnectionServiceDetails.spec.ts",
"playwright/e2e/Features/Announcements/SystemAnnouncements.spec.ts",
"playwright/e2e/Features/BulkEditEntity.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/OnlineUsers.spec.ts",
"playwright/e2e/Features/TestSuitePipelineRedeploy.spec.ts",
"playwright/e2e/Pages/AIProfile/ProfileMembers.spec.ts",
Expand Down Expand Up @@ -5162,6 +5169,7 @@
"playwright/e2e/Features/DataQuality/Profiler.spec.ts",
"playwright/e2e/Features/DataQuality/RunTestCase.spec.ts",
"playwright/e2e/Features/DataQuality/TableLevelTests.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseCrudAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
Expand Down Expand Up @@ -5270,6 +5278,7 @@
"playwright/e2e/Features/DataQuality/DataQuality.spec.ts",
"playwright/e2e/Features/DataQuality/IncidentManagerDateFilter.spec.ts",
"playwright/e2e/Features/DataQuality/IncidentManagerSqlQuery.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/EntitySuggestions.spec.ts",
"playwright/e2e/Features/FailedTestCaseSampleData.spec.ts",
Expand Down Expand Up @@ -6783,6 +6792,14 @@
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TableProfiler/QualityTab/QualityTab.component.tsx"
],
"specs": [
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts"
]
},
{
"sources": [
"openmetadata-ui/src/main/resources/ui/src/components/Database/Profiler/TestSummary/RunSummaryTiles/RunSummaryTiles.tsx"
Expand Down Expand Up @@ -11963,6 +11980,7 @@
"playwright/e2e/Features/DataQuality/ProfilerSettingsAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/RunTestCase.spec.ts",
"playwright/e2e/Features/DataQuality/TableLevelTests.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCaseExportFilters.spec.ts",
"playwright/e2e/Features/DataQuality/TableTestCasePagination.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseCrudAfterReindex.spec.ts",
"playwright/e2e/Features/DataQuality/TestCaseDetailsPage.spec.ts",
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
/*
* Copyright 2026 Collate.
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { render, screen } from '@testing-library/react';
import { describe, expect, it } from 'vitest';
import { NavItemBase, type NavItemSize } from './nav-item';

const Icon = () => <svg data-testid="nav-icon" />;

describe('NavItemBase', () => {
it('renders an item without an href as a button, not a link', () => {
render(<NavItemBase type="link">Logout</NavItemBase>);

expect(screen.getByRole('button', { name: 'Logout' })).toBeInTheDocument();
expect(screen.queryByRole('link')).not.toBeInTheDocument();
});

it.each<[NavItemSize, string]>([
['sm', 'tw:pl-9'],
['md', 'tw:pl-10'],
])(
'indents a %s collapsible child to line up with its parent label',
(size, indent) => {
render(
<NavItemBase href="/child" size={size} type="collapsible-child">
Child
</NavItemBase>
);

expect(screen.getByRole('link', { name: 'Child' })).toHaveClass(indent);
}
);

it.each<[NavItemSize, number]>([
['md', 0],
['lg', 1],
])('shows a %s collapsible child icon %i time(s)', (size, count) => {
render(
<NavItemBase
href="/child"
icon={Icon}
size={size}
type="collapsible-child">
Child
</NavItemBase>
);

expect(screen.queryAllByTestId('nav-icon')).toHaveLength(count);
});

it('fills the current item with the brand colour in the solid variant', () => {
render(
<>
<NavItemBase current href="/a" type="link" variant="solid">
Current
</NavItemBase>
<NavItemBase current href="/b" type="link">
Default
</NavItemBase>
<NavItemBase href="/c" type="link" variant="solid">
Resting
</NavItemBase>
</>
);

expect(screen.getByRole('link', { name: 'Resting' })).toHaveClass(
'tw:bg-transparent'
);
expect(screen.getByText('Resting')).toHaveClass('tw:text-tertiary');
expect(screen.getByText('Current')).toHaveClass('tw:text-primary_on-brand');

expect(screen.getByRole('link', { name: 'Current' })).toHaveClass(
'tw:bg-brand-solid'
);
expect(screen.getByRole('link', { name: 'Default' })).toHaveClass(
'tw:bg-brand-primary_alt'
);
});
});
Loading
Loading