Skip to content

fix(playwright): markdown preview and KPI Widget locators on Collate #35631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rohit0301 merged 9 commits into from
Oct 19, 2026
Merged

fix(playwright): markdown preview and KPI Widget locators on Collate #35631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
240c878
fix(playwright): fix markdown preview and KPI Widget locators on Collate
Rohit0301 Oct 16, 2026
c2a149d
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 16, 2026
a9050a4
test(playwright): locate markdown preview by data-testid instead of c…
Rohit0301 Oct 17, 2026
78d712c
test(playwright): select Data Insight tabs by data-testid instead of …
Rohit0301 Oct 17, 2026
4e29673
chore(playwright): auto-refresh impact-map.generated.json
github-actions[bot] Oct 17, 2026
5e9e448
Merge remote-tracking branch 'origin/main' into Rohit0301/markdown-kp…
Rohit0301 Oct 18, 2026
fe3b48d
test(playwright): stop importing app code from src/interface in Data …
Rohit0301 Oct 18, 2026
2f5dd3f
Merge remote-tracking branch 'origin/Rohit0301/markdown-kpi-fix' into…
Rohit0301 Oct 18, 2026
e7771af
Merge branch 'main' into Rohit0301/markdown-kpi-fix
Rohit0301 Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeWidgets.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
addKpi,
deleteKpiRequest,
deleteSeededKpisOnChart,
openDataInsightTab,
} from '../../utils/dataInsight';
import { waitForAllLoadersToDisappear } from '../../utils/entity';
import { sidebarClick } from '../../utils/sidebar';
Expand Down Expand Up @@ -136,7 +137,7 @@
// the stock layout instead of the persona's customizable one.
void persona;

const page = await browser.newPage();

Check warning on line 140 in openmetadata-ui/src/main/resources/ui/playwright/e2e/Flow/CustomizeWidgets.spec.ts

View workflow job for this annotation

GitHub Actions / checkstyle 

Prefer the `page` fixture (test.use({ storageState })) over browser.newPage() + manual login for single-user admin tests. For multi-user tests that need a second non-admin page, this warning is expected — no action needed
await testUser.signIn(page);
await use(page);
await page.close();
Expand Down Expand Up @@ -313,7 +314,7 @@
await waitForAllLoadersToDisappear(page);

await sidebarClick(page, SidebarItem.DATA_INSIGHT);
await page.getByRole('link', { name: 'KPIs', exact: true }).click();
await openDataInsightTab(page, 'kpi');

await page.getByTestId('add-kpi-btn').click();
const createdKpi = await addKpi(page, {
Expand Down
18 changes: 10 additions & 8 deletions openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/DataInsight.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ import { expect, test } from '../../support/fixtures/isolatedUser';
import { okJson } from '../../utils/apiResponse';
import { createNewPage, redirectToHomePage, uuid } from '../../utils/common';
import { waitForLandingPageWidget } from '../../utils/customizeLandingPage';
import { addKpi, deleteKpiRequest } from '../../utils/dataInsight';
import {
addKpi,
deleteKpiRequest,
openDataInsightTab,
} from '../../utils/dataInsight';
import { waitForResponseWithStatus } from '../../utils/waitHelpers';

// use the admin user to login
Expand Down Expand Up @@ -95,7 +99,7 @@ test.describe('Data Insight Page', { tag: '@data-insight' }, () => {
test('Create description and owner KPI', async ({ page }) => {
await navigateToDataInsightPage(page);

await page.getByRole('link', { name: 'KPIs', exact: true }).click();
await openDataInsightTab(page, 'kpi');

for (const data of kpiData) {
await page.getByTestId('add-kpi-btn').click();
Expand Down Expand Up @@ -224,9 +228,7 @@ test.describe('Data Insight Page', { tag: '@data-insight' }, () => {
await page.getByTestId('date-picker-menu').click();
await page.getByRole('menuitem', { name: 'Last 60 days' }).click();

await page
.getByRole('link', { name: 'App Analytics', exact: true })
.click();
await openDataInsightTab(page, 'app-analytics');

await expect(page.getByTestId('summary-card-content')).toBeVisible();
await expect(
Expand Down Expand Up @@ -257,7 +259,7 @@ test.describe('Data Insight Page', { tag: '@data-insight' }, () => {
await percentageOfDataAssetWithDescriptionResponse;
await page.getByTestId('date-picker-menu').click();
await page.getByRole('menuitem', { name: 'Last 60 days' }).click();
await page.getByRole('link', { name: 'KPIs', exact: true }).click();
await openDataInsightTab(page, 'kpi');

await expect(page.getByTestId('kpi-card')).toBeVisible();
await expect(
Expand Down Expand Up @@ -289,7 +291,7 @@ test.describe('Data Insight Page', { tag: '@data-insight' }, () => {
await latestKPIResponse;
await percentageOfDataAssetWithDescriptionResponse;

await page.getByRole('link', { name: 'KPIs', exact: true }).click();
await openDataInsightTab(page, 'kpi');

for (const data of kpiData) {
await page.getByTestId(`edit-action-${data.displayName}`).click();
Expand Down Expand Up @@ -356,7 +358,7 @@ test.describe('Data Insight Page', { tag: '@data-insight' }, () => {
await latestKPIResponse;
await percentageOfDataAssetWithDescriptionResponse;

await page.getByRole('link', { name: 'KPIs', exact: true }).click();
await openDataInsightTab(page, 'kpi');

for (const data of kpiData) {
const kpi = getCreatedKpi(data.displayName);
Expand Down
5 changes: 3 additions & 2 deletions ...metadata-ui/src/main/resources/ui/playwright/e2e/nightly/ContextCenterFilePreview.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,10 @@ test.describe('Context Center - Document File Preview', () => {
const modal = await openFilePreviewModal(page, row, document.id);

await expect(
modal.getByRole('heading', { name: MARKDOWN_HEADING })
modal
.getByTestId('markdown-preview')
.getByRole('heading', { name: MARKDOWN_HEADING })
).toBeVisible();
await expect(modal.locator('[class*="tw:prose"]')).toBeVisible();
});

test('plain text file renders inside a pre block in the preview modal', async ({
Expand Down
8 changes: 8 additions & 0 deletions openmetadata-ui/src/main/resources/ui/playwright/utils/dataInsight.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,11 @@ export const addKpi = async (page: Page, data: KPIData) => {

return { ...kpi, id: kpi.id, fullyQualifiedName: kpi.fullyQualifiedName };
};

export const openDataInsightTab = async (
page: Page,
tab: 'kpi' | 'app-analytics'
) => {
await page.getByTestId(`data-insight-tab-${tab}`).click();
await page.waitForURL(`**/data-insights/${tab}`);
};
2 changes: 1 addition & 1 deletion ...etadata-ui/src/main/resources/ui/src/components/common/FilePreviewer/MarkdownRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const MarkdownRenderer = ({ content }: PreviewRendererProps) => {
}, [content]);

return (
<div className="prose tw:max-w-none tw:p-4">
<div className="prose tw:max-w-none tw:p-4" data-testid="markdown-preview">
<ReactMarkdown components={getCustomMarkdownComponents()}>
{text}
</ReactMarkdown>
Expand Down
1 change: 1 addition & 0 deletions ...main/resources/ui/src/pages/DataInsightPage/DataInsightLeftPanel/DataInsightLeftPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import { DataInsightTabs } from '../../../interface/data-insight.interface';
import { getDataInsightPathWithFqn } from '../../../utils/DataInsightPureUtils';
import { useRequiredParams } from '../../../utils/useRequiredParams';
import DataInsightClassBase from '../DataInsightClassBase';

Check warning on line 21 in openmetadata-ui/src/main/resources/ui/src/pages/DataInsightPage/DataInsightLeftPanel/DataInsightLeftPanel.tsx

View workflow job for this annotation

GitHub Actions / checkstyle 

This runtime import participates in a circular dependency. Extract the shared type/constant/utility or invert the dependency

const DataInsightLeftPanel = () => {
const { t } = useTranslation();
Expand All @@ -36,6 +36,7 @@
<li key={item.key}>
<NavItemBase
current={item.key === (tab ?? DataInsightTabs.DATA_ASSETS)}
dataTestId={`data-insight-tab-${item.key}`}
href={getDataInsightPathWithFqn(item.key)}
icon={item.icon}
size="sm"
Expand Down
Loading