Keep a typed alert argument search when the source search is rebuilt by chirag-madlani · Pull Request #35683 · open-metadata/OpenMetadata

chirag-madlani · 2026-10-17T13:46:31Z

Describe your changes:

Fixes a race in the alert form's searchable rule arguments (e.g. the Updater Name user picker): a search typed right after adding a filter could be silently dropped. The text stays in the input, but no search request is ever sent, so the list keeps showing the unfiltered defaults.

Cause. In AiArgumentAutocomplete (AlertAiRuleSection.component.tsx), debouncedSearch (500 ms) was memoized on [argument, selectedSource, sourceSearch, stableContainerEntities], and an effect cancels it on cleanup. Adding a filter changes the form input → useAlertCapabilities re-asks the server → when it answers, useAlertSelection hands out a new search object → debouncedSearch is rebuilt and the pending typed search is .cancel()led.

Fix. Read those params through a ref (the component already does this for selectedValues), so the debounced function is created once and only cancelled on unmount.

This is what blocked the merge queue for #35678 on Flow/NotificationAlerts.spec.ts › Multiple Filters Alert (run 39030428697). The retry trace shows only two index=user&q= (empty query) requests about 950 ms apart, the second being the dependency change re-running the initial load, and never the typed name. The first attempt timed out on the same form with the filter option detaching.

Testing

Unit (RED → GREEN): new test in AlertAiFormFields.component.test.tsx, keeps a typed search when the source search is rebuilt during the debounce. It types, rerenders with a new sourceSearch, and advances the debounce. Before the fix it fails with the only searchQuery call being query: "", the same thing CI showed. Both alert suites now pass 50/50 (AlertAiFormFields.component.test.tsx, ClassicAlertRuleSection.test.tsx).
Playwright, local: production build of this branch served in front of a local backend, PLAYWRIGHT_RETRIES=0:
- Flow/NotificationAlerts.spec.ts + Flow/ObservabilityAlerts.spec.ts: all 17 tests pass (the 4 webhook tests with PLAYWRIGHT_WEBHOOK_HOST=host.docker.internal).
- Multiple Filters Alert with --repeat-each=3: 3/3 pass.

Type of change:

Bug fix

Checklist:

I have read the CONTRIBUTING document.
I have commented on my code, particularly in hard-to-understand areas.
I have added a test that covers the exact scenario we are fixing.

🤖 Generated with Claude Code

Confidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Keeps a pending alert argument search when search settings change.

Alert argument searches keep running when filter details refresh.
The profiler ingestion form spec joins two Playwright impact groups.

_{Reviews (1) · Last reviewed commit: "chore(playwright): auto-refresh impact-m..." · Reviewed by Greptile}

Adding a filter re-asks the server what the selection supports, which hands the argument autocomplete a new sourceSearch. debouncedSearch depended on it, so it was rebuilt and the cleanup cancelled the search the user was still typing: the text stayed in the input but no search request was ever sent. Read the search params through a ref so the debounced function is created once and only cancelled on unmount. This is the cause of the intermittent NotificationAlerts > Multiple Filters Alert timeouts in the merge queue.

github-actions · 2026-10-17T13:46:39Z

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

github-actions · 2026-10-17T13:47:12Z

🔄 Playwright impact map auto-refreshed

This PR touched specs or UI source that changed the source→spec routing map. I regenerated .github/playwright/impact-map.generated.json and pushed the diff to this branch.

- source entries: 944 → 944
- 0 added, 0 removed, 2 changed spec-list

Entries whose spec list changed:
  openmetadata-ui/src/main/resources/ui/playwright/utils/apiResponse.ts
  openmetadata-ui/src/main/resources/ui/src/components/Settings/Services/AddIngestion/AddIngestion.component.tsx

What is this file? It is the auto-generated half of Playwright's PR planner. It routes "if source X changes, run specs Y" by walking spec imports and cross-referencing getByTestId strings. Hand-authored routing in impact-map.json always wins on conflict.

What if I want to regenerate locally instead? Run this before pushing your next change to skip the bot commit:

python3 .github/scripts/generate_playwright_impact_map.py
git add .github/playwright/impact-map.generated.json
git commit --amend --no-edit  # or a separate commit

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

gitar-bot · 2026-10-17T13:48:25Z

Code Review ✅ Approved

🟡 Medium risk · Preserving pending alert-argument searches across source rebuilds changes option lookup timing, which could display an incorrect set of rule choices.

Fixes a race in the alert form's searchable rule arguments where a search typed right after adding a filter was silently dropped. The debounced search now reads its parameters through a ref, so it is only cancelled on unmount rather than on every rebuild. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

`Compact`
`gitar display:verbose`

_{Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source}

github-actions · 2026-10-17T13:54:59Z

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

One or more source files have linting or formatting issues.

Affected files

openmetadata-ui/src/main/resources/ui/src/components/observability/Alerts/AlertAiFormFields.component.test.tsx

🔍 ESLint findings in this PR's files — 0 error(s), 2 warning(s)

Errors block the build. Warnings do not yet — they are rules whose backlog is still
being worked down, listed so this PR does not add to it. See docs/ui-code-quality-gate.md.

0 error(s), 2 warning(s) across 2 changed file(s).

Count	Rule
1	`openmetadata-imports/no-lower-layer-page-imports`
1	`react-hooks/exhaustive-deps`

All findings

	Location	Rule	Message
🟡	`src/components/observability/Alerts/AlertAiFormFields.component.test.tsx:49:1`	`openmetadata-imports/no-lower-layer-page-imports`	Pages are route-level composition modules. Move the shared implementation/type to a lower layer instead of importing a page from here.
🟡	`src/components/observability/Alerts/AlertAiRuleSection.component.tsx:537:9`	`react-hooks/exhaustive-deps`	The 'selectedRules' logical expression could make the dependencies of useMemo Hook (at line 542) change on every render. To fix this, wrap the initialization of

Fix locally (fast - only checks files changed in this branch):

make ui-checkstyle-changed

github-actions · 2026-10-17T14:06:26Z

Jest test Coverage

UI tests summary

Lines	Statements	Branches	Functions
	78.59% (129940/165321)	65.36% (82635/126430)	66.7% (27612/41392)

sonarqubecloud · 2026-10-17T14:10:11Z

Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

chirag-madlani requested review from ShaileshParmar11 and karanh37 as code owners October 17, 2026 13:46

Copilot AI balanced review requested due to automatic review settings October 17, 2026 13:46

Copilot AI reviewed Oct 17, 2026

github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Oct 17, 2026

chore(playwright): auto-refresh impact-map.generated.json

95f3e25

Copilot AI balanced review requested due to automatic review settings October 17, 2026 13:47

Copilot AI reviewed Oct 17, 2026

Navigation Menu

Repository navigation

Keep a typed alert argument search when the source search is rebuilt - #35683

Keep a typed alert argument search when the source search is rebuilt#35683
chirag-madlani wants to merge 2 commits into
mainfrom
alert-search-debounce-race

chirag-madlani commented Oct 17, 2026 •

edited by greptile-apps Bot

Loading

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

gitar-bot Bot commented Oct 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

github-actions Bot commented Oct 17, 2026

Uh oh!

sonarqubecloud Bot commented Oct 17, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chirag-madlani commented Oct 17, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes:

Testing

Type of change:

Checklist:

Confidence Score: 5/5

Summary

Uh oh!

github-actions Bot commented Oct 17, 2026

❌ PR checklist incomplete

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 17, 2026

🔄 Playwright impact map auto-refreshed

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

gitar-bot Bot commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 17, 2026

❌ UI Checkstyle Failed

❌ ESLint + Prettier + Organise Imports (src)

🔍 ESLint findings in this PR's files — 0 error(s), 2 warning(s)

Uh oh!

github-actions Bot commented Oct 17, 2026

Jest test Coverage

UI tests summary

Uh oh!

sonarqubecloud Bot commented Oct 17, 2026

Quality Gate passed for 'open-metadata-ui'

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chirag-madlani commented Oct 17, 2026 •

edited by greptile-apps Bot

Loading

gitar-bot Bot commented Oct 17, 2026 •

edited

Loading