Skip to content

Docs: Explain Organization Policy ViewAll rule and RBAC Search policy combining (#590) - #608

Merged
kiran1287 merged 5 commits into
mainfrom
issue-590
Oct 16, 2026
Merged

kiran1287 merged 5 commits into
mainfrom
issue-590

Conversation

@kiran1287

Copy link
Copy Markdown
Contributor

Fixes #590.

Updated the Roles and Policies pages in v1.13.x, v2.0.x, and v2.1.x-SNAPSHOT.

Changes

authorization.mdx

  • Documented all three rules of the Organization Policy, including OrganizationPolicy-ViewAll-Rule.
  • Listed which conditions RBAC Search evaluates and noted that it ignores matchTeam(). Explained that isOwner() also covers the user's teams in search, while inAnyTeam() checks only team membership.
  • Added a "How Search Combines Your Policies" section: search combines the allow rules of all of a user's policies, so an unconditional ViewAll rule keeps every asset visible even with RBAC Search on. Added the steps for strict isolation and a warning about removing the rule.
  • Corrected the RBAC Search intro and added a pre-enable check for unconditional ViewAll rules.

use-cases.mdx

  • Qualified the "Keep the Organization Policy in place" advice for per-team and per-tenant isolation.
  • Added notes to Use Cases 3 and 4 that RBAC Search ignores matchTeam().
  • Added Use Case 10, showing how to make Explore show each team only the assets it owns.

@mintlify

mintlify Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
openmetadata 🟢 Ready View Preview Oct 15, 2026, 11:13 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@kiran1287 kiran1287 self-assigned this Oct 15, 2026
@kiran1287 kiran1287 added the CS Fix OM Customer support doc gaps label Oct 15, 2026

@ayush-shah ayush-shah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential finding on the reviewed commit; please verify the scenario below.


1. Go to **Settings** > **Preferences** > **Search** and turn on RBAC Search.
2. Go to **Settings** > **Policies** > **Organization Policy** and delete `OrganizationPolicy-ViewAll-Rule`.
3. Open every other policy that applies to the team, such as the policy of the Data Consumer role, and remove `ViewAll` from any rule that has no condition.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Potential P2] Remove every unrestricted search grant in the isolation steps

A team member with the Read-Only Viewer policy from Use Case 5 still sees other teams’ assets after following these steps: removing ViewAll leaves that policy’s unconditional ViewBasic grants, and the authorization page says search accepts ViewBasic, ViewAll, and All. Remove or ownership-scope all three operations in this procedure and the corresponding strict-isolation guidance, then verify with a member who has the other roles.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 8f6bcd6. The strict-isolation guidance and Use Case 10 now cover all three operations that search accepts: ViewBasic, ViewAll, and All. Step 3 tells readers to remove them from any rule that has no condition, or add a condition such as isOwner(), and it names the Read-Only Viewer policy from Use Case 5. Step 4 now says to repeat the test with a member who has each of the other roles on the team. Applied in v1.13.x, v2.0.x, and v2.1.x-SNAPSHOT.

@github-actions

Copy link
Copy Markdown

Review Report

Content type: Documentation
Overall verdict: NEEDS WORK
Reason: Critical=0, Major=1, Minor=1.
Reviewed revision: 8f6bcd6
Findings: Critical=0 Major=1 Minor=1

Issues Found

# Guideline Severity Original text Suggested change
1 Link wording: introduce full-sentence cross-references with "For more information, see [X]" Major "With RBAC Search turned on, this rule still applies. See Roles Based Access Controls (RBAC) Search." (v1.13.x, v2.0.x and v2.1.x-SNAPSHOT authorization.mdx, about line 98) Replace "See [...]" with "For more information, see Roles Based Access Controls (RBAC) Search."
2 Acronyms on first use: expand unfamiliar abbreviations on first use Minor "RBAC Search supports only some of these conditions." (v1.13.x, v2.0.x and v2.1.x-SNAPSHOT authorization.mdx, line 54; also "Default Rules" bullet) This is the first use of "RBAC" in the changed text. The expansion appears only later, in the "Roles Based Access Controls (RBAC) Search" heading. Write "Roles Based Access Controls (RBAC) Search supports only some of these conditions." and use "RBAC Search" afterward.

View job · claude-sonnet-5-5 (high) · full

@kiran1287
kiran1287 merged commit e21f797 into main Oct 16, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
staging — 8f6bcd62 Deployed Oct 15, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CS Fix OM Customer support doc gaps

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Explain Organization Policy ViewAll rule and RBAC Search policy combining

4 participants