fix(ext/http): avoid misaligned sockaddr_in access in SocketAddr constructor - #4629
Open
Shubhammehta2008 wants to merge 3 commits into
Open
Shubhammehta2008 wants to merge 3 commits into
Shubhammehta2008 wants to merge 3 commits into
Conversation
|
|
marcalff
requested changes
Sep 22, 2026
marcalff
left a comment
Member
There was a problem hiding this comment.
Thanks for the patch.
Please see comments, the proper fix is to use sockaddr_storage to represent a socket in an arbitrary protocol.
Other places using m_data may need some cleanup.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4629 +/- ##
==========================================
+ Coverage 86.53% 86.53% +0.01%
==========================================
Files 525 525
Lines 20475 20476 +1
==========================================
+ Hits 17715 17716 +1
Misses 2760 2760
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4307
Changes
Avoids undefined behavior caused by binding a
sockaddr_in &tom_datathroughreinterpret_castin theSocketAddr(u_long, uint16_t)constructor.Following the existing pattern in
SocketAddr(char const *)andport(), this initializes a clean stack-allocatedstruct sockaddr_inand copies it intom_datausingmemcpy.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes