[Metrics SDK] Fix spatial re-aggregation for asynchronous instruments - #4635
Open
nikhilbhatia08 wants to merge 4 commits into
Open
nikhilbhatia08 wants to merge 4 commits into
nikhilbhatia08 wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4635 +/- ##
==========================================
+ Coverage 86.53% 86.53% +0.01%
==========================================
Files 525 525
Lines 20475 20498 +23
==========================================
+ Hits 17715 17735 +20
- Misses 2760 2763 +3
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1724
Changes
Fix spatial re-aggregation for asynchronous instruments. A view which drops attributes is now applied to asynchronous instruments as well, and the observations which collapse onto the same attribute set are re-aggregated (summed up for the additive instruments) instead of the last observation overwriting the previous ones. Note that
AsyncMetricStorage's constructor now takes the view'sAttributesProcessor, matchingSyncMetricStorage.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes