Repository navigation
Conversation
Pull request dashboard statusWaiting on the author · refreshed 2026-11-11 17:13 UTC Two things need attention:
Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Celery sampler-attribute update.
No open issues 🎉
What changed in this PR
Updates Celery instrumentation to expose known span attributes to samplers at span creation, enabling attribute-based sampling as requested in #5253.
Changes:
- Collects producer and consumer attributes before starting spans, while retaining post-execution state updates.
- Refactors context extraction to return an attribute dictionary.
- Adds tests for sampler visibility, attribute-based sampling, and context cleanup.
| File | Description |
|---|---|
instrumentation/opentelemetry-instrumentation-celery/tests/test_utils.py |
Updates tests for dictionary-based attribute extraction. |
instrumentation/opentelemetry-instrumentation-celery/tests/test_tasks.py |
Tests sampler attributes, sampling decisions, and cleanup. |
instrumentation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/utils.py |
Returns extracted attributes and uses destination-kind enums. |
instrumentation/opentelemetry-instrumentation-celery/src/opentelemetry/instrumentation/celery/__init__.py |
Supplies known attributes when creating producer and consumer spans. |
.changelog/5312.changed |
Documents sampler visibility for Celery attributes. |
Review effort: Balanced
herin049
approved these changes
Nov 11, 2026
| utils.set_attributes_from_context(span, kwargs) | ||
| utils.set_attributes_from_context(span, task.request) | ||
| span.set_attribute(_TASK_NAME_KEY, task.name) | ||
| span.set_attributes(utils.get_attributes_from_context(kwargs)) |
Contributor
There was a problem hiding this comment.
small nit: do we maybe want to split out get_attributes_from_context into prerun/postrun to avoid redundant computation here.
Contributor
Author
There was a problem hiding this comment.
Will take a look tomorrow
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add known attributes at span creation time so that the sampler has visibility on them.
Refs #5253
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck