Repository navigation
pika: add visibility to sampler to messagging spans attributes - #5313
Merged
Merged
Conversation
Pull request dashboard statusMerged · refreshed 2026-11-11 17:11 UTC Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change to expose Pika messaging attributes at span creation for attribute-based sampling.
No open issues 🎉
What changed in this PR
Updates Pika instrumentation to expose known messaging attributes when spans are created, enabling attribute-based sampling as requested in #5253.
Changes:
- Collects messaging and connection attributes before calling
start_span. - Adds sampling tests for publishing, callbacks, and generator consumption, plus exception-propagation checks.
- Updates utility tests and adds a changelog entry.
| File | Description |
|---|---|
| instrumentation/opentelemetry-instrumentation-pika/tests/test_utils.py | Updates tests for attribute collection and span creation. |
| instrumentation/opentelemetry-instrumentation-pika/tests/test_sampling.py | Tests sampler visibility, sampling decisions, and error propagation. |
| instrumentation/opentelemetry-instrumentation-pika/src/opentelemetry/instrumentation/pika/utils.py | Passes known attributes directly to span creation. |
| .changelog/5313.changed | Documents sampler visibility for Pika attributes. |
Review effort: Balanced
herin049
approved these changes
Nov 11, 2026
xrmx
enabled auto-merge
November 11, 2026 16:49
Merged
via the queue into
open-telemetry:main
with commit Nov 11, 2026
5018dbf
1532 of 1534 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add known attributes at span creation time so that the sampler has visibility on them.
Refs #5253
Type of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck