Skip to content

opentelemetry-instrumentation-wsgi: capture Content-Type and Content-Length request headers #5321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghdtjdwn wants to merge 2 commits into
base: main
Choose a base branch
from
+31 −0
Open

opentelemetry-instrumentation-wsgi: capture Content-Type and Content-Length request headers #5321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a0045
opentelemetry-instrumentation-wsgi: capture Content-Type and Content-…
ghdtjdwn Nov 11, 2026
c5c697d
Add changelog fragment
ghdtjdwn Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5321.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-instrumentation-wsgi`: capture `Content-Type` and `Content-Length` request headers
5 changes: 5 additions & 0 deletions ...ion/opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,11 @@ def collect_custom_request_headers_attributes(environ: WSGIEnvironment) -> dict[
for key, val in environ.items()
if key.startswith(_CARRIER_KEY_PREFIX)
}
# PEP 3333: these two have no HTTP_ prefix and may be empty or absent
for key in ("CONTENT_TYPE", "CONTENT_LENGTH"):
val = environ.get(key)
if val:
headers[key.replace("_", "-")] = val

return sanitize.sanitize_header_values(
headers,
Expand Down
25 changes: 25 additions & 0 deletions instrumentation/opentelemetry-instrumentation-wsgi/tests/test_wsgi_middleware.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,31 @@ def test_custom_request_headers_added_in_server_span(self) -> None:
for point in metric.data.data_points:
self.assertTrue(set(expected).isdisjoint(point.attributes))

@mock.patch.dict(
"os.environ",
{OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST: "Content-Type,Content-Length"},
)
def test_custom_request_headers_content_type_and_length(self) -> None:
self.environ.update(
{
"CONTENT_TYPE": "application/json",
"CONTENT_LENGTH": "7",
"HTTP_CONTENT_TYPE": "text/html",
}
)
self.assertEqual(
otel_wsgi.collect_custom_request_headers_attributes(self.environ),
{
"http.request.header.content_type": ["application/json"],
"http.request.header.content_length": ["7"],
},
)
self.environ["CONTENT_LENGTH"] = ""
self.assertEqual(
otel_wsgi.collect_custom_request_headers_attributes(self.environ),
{"http.request.header.content_type": ["application/json"]},
)

@mock.patch.dict(
"os.environ",
{OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST: "Custom-Test-Header-1"},
Expand Down
Loading