Repository navigation
Conversation
…epeated headers The request and response headers are multidicts, and passing them to sanitize_header_values as is kept only the last value of a header that appears more than once. Group the values by header name first.
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-11 01:39 UTC Review the latest changes. Status above doesn't look right?
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
request.headersandresponse.headersare multidicts and are passed toSanitizeValue.sanitize_header_valuesas they are. That function assigns one list per key while iterating.items(), so for a header that appears more than once only the last value ends up inhttp.request.header.<name>/http.response.header.<name>. The aiohttp client and ASGI instrumentations record every value.Group the values by lowercased header name before handing them to the sanitizer. I did not reuse the
{key: headers.getall(key) for key in headers.keys()}form from the client instrumentation, because it callsgetallonce per header line and that gets slow when a request repeats the same header many times.collect_response_headers_attributesnow returns early when no response headers are configured, as the request side already does, so nothing is built in that case.Type of change
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck