Repository navigation
Keysight AI DCB collective communications - #491
lthompson-keysight wants to merge 2 commits into
Conversation
|
I tried to view the changes as a whole using the redocly link in this conversation and didn't see any changes. |
|
I have updated the Redocli link to https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/Keysight/keysight-ccb/refs/heads/keysight-ccb/artifacts/openapi.yaml&nocors#tag/Configuration . It should now show the tree view . |
b55ad64 to
047c201
Compare
48e7c1f to
6271f70
Compare
3f3f6e3 to
fa1bcdd
Compare
09b47e2 to
66efafd
Compare
Changes made for addressing PR review #2(note: any mention of 'removal' refers to removing/canceling a proposed addition. We're not removing General
Base OTG Model
Collective Communications
|
apratimmukherjee
left a comment
There was a problem hiding this comment.
Few possible points for cleanup:
- Field UIDs 101/102 are still used on shared schemas. The change list says contiguous IDs were restored, but these existing schemas still use 101/102. These numbers become permanent once released, so please use the next free uid:
Config.collective_communications / Config.artifacts: 101/102 → 12/13
Capture.max_file_size: 101 → 7
Rocev2.PerPortSettings.enable_rx_reordering: 101 → 4
Rocev2.AckAndNak.rnr_nak_retry_count / ack_request_interval: 101/102 → 6/7
Rocev2.DCQCN.rate_decrement_coefficient: 101 → 15
-
Config.artifacts is undefined (only a placeholder), so it can be removed, together with Placeholder.Object. It can be added back later with defined fields if it's really needed.
-
UID gaps in the new CC schemas. Removing fields left gaps, for example CollectiveCommunications.State.Stopped uses only 2/4/6, and CollectiveCommunications has no uid 3. These aren't released yet, so renumbering is enough.
-
The sample code is out of date. The code in the PR description still uses cc.platforms, platform_type, physical_binding.platform_name and the metric choices iterations_summary / packet_drop. None of these exist in the model any more.
ajbalogh
left a comment
There was a problem hiding this comment.
Problem
- OTG models are vendor-neutral. Existing sections such as
flowsandstateful_flowsreference objects defined inportsanddevicesby name throughx-constraint.collective_communicationsshould follow the same pattern.
- Every
InfrastructureRefinstead resolves against components the schema never declares.- A user has no way to determine from the model what values to supply for these properties.
- Each implementation must define its own valid values, so different servers can accept, reject or bind the same config differently. This breaks the model-driven, vendor-neutral contract the repository sets out to provide.
Proposal
- Remove
InfrastructureRef,RankBinding.infrastructure_ref,RankBinding.nic_refsandNicBinding. RankBinding:rank_idandnics[], each withethernet_name(x-constraint: /components/schemas/Device.Ethernet/properties/name) and optionalcustom_settings.- Host membership follows from each Ethernet's parent
Device. - The test port follows from each Ethernet's
connection.port_name. - Document both conventions in the
RankBindingdescription.
- Host membership follows from each Ethernet's parent
- Result: existing
x-constrainttooling catches dangling references, and no new vocabulary is required.
Note
- Update the PR sample to follow the latest model changes.
741acc9 to
da50e99
Compare
Changes made for addressing @apratimmukherjee PR review #3
@ajbalogh comments being evaluated |
Simplified infrastructure Snapshot of Keysight's model work, from internal commit 9a0ea1ada4b4, based on upstream 67a8aa5. Generated artifacts are built by CI from the sources in this commit. Co-authored-by: Cristian Dinu <cristian-mircea.dinu@keysight.com> Co-authored-by: Gabe Righi <gabriel.righi@keysight.com>
2e95a5f to
3416dde
Compare
Simplified Infrastructure to use an automatic assignment algorithm per discussion, and eliminated chakra references. |
Vendor-agnostic collective communication benchmarking model.
Feature Overview
Add support for benchmarking collective communications systems
Generated artifacts are built by CI from the sources in this commit.
Feature Details
config body: /collective_communications
set_control_state body: /collective_communications
get_state body: /collective_communications
get_metrics body: /collective_communications
Code snippets