Skip to content

feat: Remove yaml-language-server override after Volar update #523

Description

@fantonangeli

Description

Remove the temporary yaml-language-server@1.24.0 override introduced in #522 after upgrading to a compatible volar-service-yaml release.

Parent tracking issue: #289.

Motivation

volar-service-yaml@0.0.71 still depends on yaml-language-server~1.23.0. In #522, OWS Editor overrides this dependency to 1.24.0 to use the newer YAML Language Server without pulling in the outdated vscode-json-languageservice v4 dependency.

Upstream volarjs/services#127 updates the dependency to ~1.24.0, but is not merged/released yet. We should remove the workaround once the official dependency is available.

Proposed Implementation

  • Wait for volarjs/services#127 to be merged and a compatible volar-service-yaml version to be published.
  • Upgrade volar-service-yaml in pnpm-workspace.yaml and update the lockfile.
  • Remove the temporary yaml-language-server: "1.24.0" override and its comment.
  • Verify YAML completions, diagnostics, hover, and the Create an Open Workflow CodeLens, as well as existing JSON functionality.
  • Run the relevant unit tests, production builds, and Playwright E2E tests.

Definition of Done

  • Implementation: Fully implemented according to the Open Workflow spec.
  • Unit Tests: Comprehensive unit tests are included and passing.
  • Integration Tests: Verified within the monorepo and target environments (Web/VS Code).
  • Documentation: Updated README.md, ADRs, or official docs.
  • Performance: No significant regression in editor responsiveness.
  • Accessibility: UI changes comply with accessibility standards.

References

Metadata

Metadata

Labels

enhancementNew feature or request

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions