Skip to content

feat: make outer try catch task selectable - #540

Open
lornakelly wants to merge 1 commit into
open-workflow-specification:feature/node-editingfrom
lornakelly:254/try-catch-task
Open

lornakelly wants to merge 1 commit into
open-workflow-specification:feature/node-editingfrom
lornakelly:254/try-catch-task

Conversation

@lornakelly

Copy link
Copy Markdown
Collaborator

Contributes to #254

Summary

Add sidepanel view to outer try catch node when selected - on the canvas a try task is drawn as three nodes: the outer TRY…CATCH node and an inner Try and Catch. In the YAML/JSON it is considered one task, not 3 separate. Currently you dont see anything when you select the outer node, this PR adds a small fix so you see the same view as the inner try and catch when selecting the outer TRY…CATCH

Verify

Storybook > Nested Editing > Try Catch Retry Inline

@netlify

netlify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for openworkflow-editor ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b6bdbc
🔍 Latest deploy log https://app.netlify.com/projects/openworkflow-editor/deploys/6af72364175ab6f6c3153432
😎 Deploy Preview https://deploy-preview-540--openworkflow-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@changeset-bot

changeset-bot Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b6bdbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@openworkflowspec/diagram-editor Minor
@openworkflowspec/core Minor
@openworkflowspec/i18n Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new assertion fails for all three aliases because toEqual compares fresh matchesData callbacks by identity; compare serialized descriptor shapes instead to test form equivalence.

1 open issue
What changed in this PR

This PR makes selecting the outer TRY…CATCH frame show the same editing panel as its inner Try and Catch frames, reflecting their shared workflow task.

Changes:

  • Maps the outer frame to the existing tryTask form schema.
  • Adds form-equivalence tests for all try/catch frame types.
  • Adds a minor-release changeset for the diagram editor.
File Description
packages/​open-workflow-diagram-editor/​tests/​core/​schemaWalker.test.ts Adds form-equivalence checks for try/catch frames.
packages/​open-workflow-diagram-editor/​src/​core/​schemaWalker.ts Maps TryCatch to the shared task form.
.changeset/​quick-banks-tap.md Records the panel improvement for release.

Review effort: Balanced

Signed-off-by: lornakelly <lornakelly88@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change to show the shared task side panel for outer TRY…CATCH nodes.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@fantonangeli fantonangeli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants