Repository navigation
feat: make outer try catch task selectable - #540
lornakelly wants to merge 1 commit into
Conversation
✅ Deploy Preview for openworkflow-editor ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 0b6bdbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
🟡 Changes recommended
The new assertion fails for all three aliases because toEqual compares fresh matchesData callbacks by identity; compare serialized descriptor shapes instead to test form equivalence.
1 open issue
What changed in this PR
This PR makes selecting the outer TRY…CATCH frame show the same editing panel as its inner Try and Catch frames, reflecting their shared workflow task.
Changes:
- Maps the outer frame to the existing
tryTaskform schema. - Adds form-equivalence tests for all try/catch frame types.
- Adds a minor-release changeset for the diagram editor.
| File | Description |
|---|---|
packages/open-workflow-diagram-editor/tests/core/schemaWalker.test.ts |
Adds form-equivalence checks for try/catch frames. |
packages/open-workflow-diagram-editor/src/core/schemaWalker.ts |
Maps TryCatch to the shared task form. |
.changeset/quick-banks-tap.md |
Records the panel improvement for release. |
Review effort: Balanced
Signed-off-by: lornakelly <lornakelly88@gmail.com>
cc0eee0 to
0b6bdbc
Compare

Contributes to #254
Summary
Add sidepanel view to outer try catch node when selected - on the canvas a try task is drawn as three nodes: the outer TRY…CATCH node and an inner Try and Catch. In the YAML/JSON it is considered one task, not 3 separate. Currently you dont see anything when you select the outer node, this PR adds a small fix so you see the same view as the inner try and catch when selecting the outer TRY…CATCH
Verify
Storybook > Nested Editing > Try Catch Retry Inline