Skip to content

A cancel over the completable future returned by start should cancel the instance #1806

Closed

Description

@fjtirado

Currently, If the future returned by start is cancelled, nothing is really cancelled.
Before recent changes to guarantee signle execution when multiple threads call start at the same time, calling cancel over future was cancelling the real future, now it will be cancelling a helper one.
But even before, cancelling the future was not really cancelling the instance execution.
Now that we have a helper future, we can fix that by invoking instance cancel withint that helper future (that can hold a reference to the instance)

Activity

  1. self-assigned this
    on Oct 28, 2026
  2. added 7 commits that reference this issue on Oct 28, 2026
    92340dd
    a7f2d10
    3613777
    9b48219
    e6a3416
    d2350c2
    b79a216
  3. added theissue type on Oct 29, 2026
  4. added a commit that references this issue on Nov 3, 2026
    47487d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions