You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
A cancel over the completable future returned by start should cancel the instance #1806
Currently, If the future returned by start is cancelled, nothing is really cancelled.
Before recent changes to guarantee signle execution when multiple threads call start at the same time, calling cancel over future was cancelling the real future, now it will be cancelling a helper one.
But even before, cancelling the future was not really cancelling the instance execution.
Now that we have a helper future, we can fix that by invoking instance cancel withint that helper future (that can hold a reference to the instance)
Activity
[Fix open-workflow-specification#1806] CompletableFuture.cancel shoul…
[Fix open-workflow-specification#1806] CompletableFuture.cancel shoul…
[Fix open-workflow-specification#1806] Trying to make copilot happy (…
[Fix open-workflow-specification#1806] Trying to make copilot happy (…
[Fix open-workflow-specification#1806] Trying to make copilot happy (…
[Fix open-workflow-specification#1806] Trying to make copilot happy (…
[Fix open-workflow-specification#1806] Trying to make copilot happy (…
[Fix open-workflow-specification#1806] CompletableFuture.cancel shoul…