Repository navigation
fix(openehr-specs): build publish previews only through the published image - #5
Merged
Merged
Conversation
… image
The local-script branch of publish ran spec_publish.sh -f -v without -q, so
every {pkg} class-table include failed. On BASE that gave 70 "include file
not found" errors and about 80% fewer table blocks in the HTML, while the
script still printed "generated" and exited 0. The published
ghcr.io/openehr/asciidoctor image passes -q in its entrypoint, and the same
build there has no errors.
- publish runs only the image: it checks for Docker and the sibling
specifications-AA_GLOBAL checkout, snapshots the HTML timestamps, builds
with --rm, then fails the build on a missing or unchanged output or on any
ERROR or "include file not found" log line. The tool pre-check and the
script's allowed-tools rule are removed.
- authoring step 7 shows the image first and says to pass -q when using a
local toolchain.
- AGENTS.md, the plugin README, docs/testing.md and the CHANGELOG match.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The local-script branch of the
publishskill ranspec_publish.sh -f -vwithout-q. BASE'smaster.adocsets{pkg}only underifdef::package_qualifiers[], so every class-table include failed, and the script still printedgenerated <file>and exited 0.I measured this on BASE with the published image:
base_types.htmlbase_types)-f -r -v -t -q -l-f -v(what the script branch ran)include file not found … {pkg}…Both runs exited 0 and printed four
generatedlines, so the timestamp check added in #4 would have called the broken output "rebuilt". The publishedghcr.io/openehr/asciidoctorimage passes-qin its entrypoint, so this PR removes the script branch.Changes
publishruns only the image. It checks for Docker and the siblingspecifications-AA_GLOBALcheckout, snapshots the HTML timestamps, builds with--rm, then fails the build on a missing or unchanged output or on anyERRORorinclude file not foundlog line (anINFOline is not a failure). Thewhich asciidoctor jq bcpre-check and the script'sallowed-toolsrule are gone, so its onlyBashrule isdocker run * ghcr.io/openehr/asciidoctor *.spec_publish.sh, butref_diris$pub_home/specifications-AA_GLOBALandpub_homedefaults to$PWD, so the boilerplate andreference_definitions.adocare read from the mounted checkout.authoringstep 7 shows the image first and says to pass-qwith a local toolchain.AGENTS.md, the plugin README,docs/testing.mdand the CHANGELOG match. TheUnreleasedentries from refactor(openehr-specs): move commands to user-only skills, fold amend into amendment-record #4 are updated in place; nothing is released.For reviewers
-r(remote CSS, so it needs network and cannot preview local CSS changes) and-l development. The script inside the image can lag the clone'sbin/, because the publish workflow is manual and the base image is:latest.AGENTS.mdstill givesspecifications-AA_GLOBAL/bin/spec_publish.sh BASEas the render command. That omits-q, so it hits the same 70 errors. It is outside this repo and I did not change it.amendment-recordplacement bug (the skill says to insert at the top of the table, but 39 of 45 amendment records open with a release row) and theregen-classesbundled-schema issue remain follow-ups.Checklist
python3 scripts/validate.pypasses (alsoclaude plugin validate plugins/openehr-specs --strict)docker runcommand and the snapshot, verify and restore steps by hand against BASE, but not through a live/openehr-specs:publishinvocation, and theallowed-toolspattern was not exercised in a sessionUnreleased; no version bumpspecifications-AA_GLOBAL/Dockerfile,bin/spec_publish.shand itsAGENTS.md)🤖 Generated with Claude Code