pass data object as parameter in set_power_limit methode, review - #3856
Open
LKuemmel wants to merge 79 commits into
Open
pass data object as parameter in set_power_limit methode, review#3856LKuemmel wants to merge 79 commits into
LKuemmel wants to merge 79 commits into
Conversation
* use chargemode enums for chargepoints * fix * flake8 * flake8 * fix amount * use enum also for chargemode selected * fix asdict import * review
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
* fix colors, lookup dict names and colors for consumers * review * extend tests * add colors for yearly graph data * remove extra meters from log data * remove comment * flake8
* usage type self controlled * fix * review
* calc on time * review
* fix pytest * fixes, pytest * review * fix
* typo * fix * pytest
* IDM: send PV/Hausverbrauch/Batterie via GLT statt Leistungsvorgabe * Lambda: PV-Überschuss statt power_limit an E-Manager senden * Add OVUM CubeSpeicher/MPlus consumer module * IDM: revert scaling factor, fix flake8 formatting * flake8 * Rename send_grid_values to send_values in config.py * Adjust surplus calculation to account for charging power Include charging power in surplus calculation to avoid misreporting surplus to the heat pump. * Update send_values function to send grid power * Add Self_Controlled for IDM and Lambda * flake8: fix syntax error and whitespace in consumer modules Stray pasted line broke lambda_ consumer.py syntax; idm/lambda_/ovum files had trailing whitespace on blank lines and missing EOF newlines.
* clean up * fix loadmanagement * review * review * flake8
openWB#3840) * no charge for loads * consider non charging for consumers and update consumer state messages * flake8 * review
LKuemmel
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Passes consumer limit metadata through the power-limit control path.
Changes:
- Adds
SetLimitDatacontaining the configured maximum power. - Passes limit metadata to configurable consumer modules.
- Updates hierarchy documentation to include consumers.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/modules/consumers/generic/mqtt/consumer.py |
Accepts limit metadata in the MQTT callback. |
packages/modules/common/configurable_consumer.py |
Defines and forwards SetLimitData. |
packages/control/process.py |
Builds limit metadata and updates timestamp handling. |
packages/control/counter_all/hierarchy.py |
Clarifies consumer support in documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LKuemmel
force-pushed
the
feature_consumer
branch
from
August 26, 2026 13:43
1cd53eb to
e356251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.