fix some type hints - #3866
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects several Python type hints to better reflect actual runtime behavior in the MQTT consumer module and shared component state models.
Changes:
- Update the MQTT consumer
update()callback annotation to returnConsumerState(matching what it actually returns and whatConfigurableConsumerexpects). - Mark the MQTT consumer config
configurationparameter asOptional[...]since it defaults toNone. - Fix
IoStateconstructor annotations to useOptional[Dict[...]]for parameters that default toNone.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/modules/consumers/generic/mqtt/consumer.py | Adjusts update() return type to ConsumerState to match the constructed return value. |
| packages/modules/consumers/generic/mqtt/config.py | Makes configuration explicitly optional when defaulting to None. |
| packages/modules/common/component_state.py | Corrects IoState parameter annotations to reflect nullable dict inputs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LKuemmel
approved these changes
Aug 27, 2026
LKuemmel
approved these changes
Aug 27, 2026
LKuemmel
pushed a commit
that referenced
this pull request
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.