Skip to content

refactor(plugin)!: retire advisory capability preflight - #1609

Open
mldangelo-oai wants to merge 5 commits into
mainfrom
mdangelo/codex/retire-advisory-preflight
Open

mldangelo-oai wants to merge 5 commits into
mainfrom
mdangelo/codex/retire-advisory-preflight

Conversation

@mldangelo-oai

@mldangelo-oai mldangelo-oai commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Retire the advisory capability-preflight framework so optional helper failures cannot block scans. Merge current main while preserving the execution controls that actually govern scans.

Changes

  • Remove capability helpers, custom registries, advisory remediation instructions, and helper-derived progress plumbing.
  • Retire preflight worker-status events and capability-specific MCP/workbench inputs; retain dispatch progress.
  • Preserve authentication, permissions, credential configuration, execution recipes, Deep worker inheritance, and historical migration/read behavior.
  • Align workflow documentation and generated validation pins with current main.

Testing

  • All five required portable plugin checks: passed.
  • SDK type and formatting checks: passed.
  • Focused and retained SDK regressions: 502 passed, 22 platform skips.
  • Focused Python regressions: 17 passed.
  • MCP Deep executor, permission-profile, and startup/rejoin smoke suites: passed.
  • Three native review passes and a fresh independent verifier on this head: no actionable findings.
  • Full SDK seeded/default validation and refreshed GitHub CI are tracked separately; no completion claim is made for pending runs.

Risk and rollout

This is an intentional breaking retirement of public helper/custom-registry and advisory event/input contracts. Consumers should use current runtime tools and retained dispatch events. Native worker authentication, permissions, execution settings, diagnostic text, and release automation remain unchanged. No new commands or flags are introduced.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@github-actions github-actions Bot added the breaking-change Breaking change called out in generated release notes label Oct 12, 2026
@mldangelo-oai
mldangelo-oai marked this pull request as ready for review October 12, 2026 22:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T04:06:38.673185Z 6ab358f New commits
🔒 Security Review ✅ Completed 2026-10-16T04:06:24.329968Z 6ab358f New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@zcrab-oai zcrab-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9129b6532f47 in two source-review passes, including relevant callers and contracts.

Approved. No new actionable findings in the reviewed scope.

Validation: CI-helper TypeScript compilation and plugin bundling passed locally; native binaries came from CI with matching compiled source inputs. Focused SDK tests passed: api-preflight-config.test.ts, worker-progress.test.ts. Focused Python tests passed: test_runtime_settings.py, test_workbench_progress.py (17 passed in 5.26s). The full cross-platform suite was not run locally; Windows execution remains unverified here.

CI consideration: 4 latest observed checks are pending or have not passed, including tests / ${{ matrix.os }} / shard-${{ matrix.shard }}, installed package / ${{ matrix.os }} / node-${{ matrix.node }}, windows-latest / node-22 / tests-${{ matrix.shard }}, windows-latest / node-${{ (((matrix.node == '22.13.0') && '22') || matrix.node) }} / verify. See the checks; this approval does not resolve those results.

@alandelong-oai alandelong-oai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the PR diff at 983cbbc6e9ec in three independent source passes, followed by verification of the retained execution and progress paths.

The advisory capability framework is removed consistently from scan instructions, helper packaging, MCP/workbench inputs, and SDK progress events. The change preserves the separate authentication, sandbox, execution-setting, and Deep worker controls, along with saved history. The retired public event/helper contracts are explicitly documented as breaking changes. No blocking source findings.

Static review; I did not rerun the suites. Removed fixture bodies were checked by the behavior they covered rather than audited byte by byte.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Breaking change called out in generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants