Repository navigation
refactor(plugin)!: retire advisory capability preflight - #1609
mldangelo-oai wants to merge 5 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
zcrab-oai
left a comment
There was a problem hiding this comment.
Reviewed 9129b6532f47 in two source-review passes, including relevant callers and contracts.
Approved. No new actionable findings in the reviewed scope.
Validation: CI-helper TypeScript compilation and plugin bundling passed locally; native binaries came from CI with matching compiled source inputs. Focused SDK tests passed: api-preflight-config.test.ts, worker-progress.test.ts. Focused Python tests passed: test_runtime_settings.py, test_workbench_progress.py (17 passed in 5.26s). The full cross-platform suite was not run locally; Windows execution remains unverified here.
CI consideration: 4 latest observed checks are pending or have not passed, including tests / ${{ matrix.os }} / shard-${{ matrix.shard }}, installed package / ${{ matrix.os }} / node-${{ matrix.node }}, windows-latest / node-22 / tests-${{ matrix.shard }}, windows-latest / node-${{ (((matrix.node == '22.13.0') && '22') || matrix.node) }} / verify. See the checks; this approval does not resolve those results.
alandelong-oai
left a comment
There was a problem hiding this comment.
Reviewed the PR diff at 983cbbc6e9ec in three independent source passes, followed by verification of the retained execution and progress paths.
The advisory capability framework is removed consistently from scan instructions, helper packaging, MCP/workbench inputs, and SDK progress events. The change preserves the separate authentication, sandbox, execution-setting, and Deep worker controls, along with saved history. The retired public event/helper contracts are explicitly documented as breaking changes. No blocking source findings.
Static review; I did not rerun the suites. Removed fixture bodies were checked by the behavior they covered rather than audited byte by byte.
Summary
Retire the advisory capability-preflight framework so optional helper failures cannot block scans. Merge current
mainwhile preserving the execution controls that actually govern scans.Changes
main.Testing
Risk and rollout
This is an intentional breaking retirement of public helper/custom-registry and advisory event/input contracts. Consumers should use current runtime tools and retained dispatch events. Native worker authentication, permissions, execution settings, diagnostic text, and release automation remain unchanged. No new commands or flags are introduced.
Public disclosure review