Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7ba5eba to
6353428
Compare
|
Reviewed I found no demonstrated correctness or security regression. I left one nonblocking simplification comment: remove this new native directory API and use Node's names-only Buffer API in the subsequent ranking caller. The only production caller discards all type metadata. Removing the export, types, proof and package coupling cuts 212 net lines; the coordinated caller change cuts four more. Verification beyond the complete-stack comparison with main:
Only first-invalid-name diagnostic precedence changes intentionally; valid artifact bytes and receipt hashes remain unchanged in the comparisons. Local OS execution was Linux. Exact-head CI provides separate platform/native evidence; the synthetic combined stack still needs platform CI after restacking. The shipped helper uses Node, so direct Bun directory-object differences do not justify this native addition. |
|
Retained the native directory API for the implemented workbench traversal and directory-copy consumers in the remaining migration. They use raw names, type/symlink metadata, and per-entry errors, so the export and its proofs remain a shared prerequisite. The inline thread is resolved with that rationale, and the PR description now explains these consumers. Updated head: |
Summary
Expose raw Unix directory entries through the existing native binding for ranking and the remaining workbench migration.
Changes
Testing
ba12023: both full SDK runs passed 2,656 tests with 50 skips and zero failures (seeds 12345 and 4201856736).Risk and rollout
Stacked on deep-review input. The native export and typed declaration must ship together through the existing native build and packaging workflow. This adds no public CLI surface.
Public disclosure review