Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the Vinext starter to
react-server-dom-webpack@19.2.8, as proposed in #26, causesnpm installto fail withERESOLVE: that release requiresreactandreact-domat^19.2.8, while the starter pins both to19.2.6.Update the React and React DOM pins to
19.2.8and include a patch changeset for@openai/create-sites. These versions also satisfy the current RSC19.2.6peer requirements, so this can merge independently of #26. The RSC and Vite updates stay in their existing Dependabot PRs.Validation:
pnpm checkpassed: formatting, lint, types, builds, and all 44 tests.pnpm changeset:checkpassed.19.2.6, then with RSC19.2.8from Bump react-server-dom-webpack from 19.2.6 to 19.2.8 in /packages/create-sites/templates/vinext #26. No force or legacy-peer-deps flags were used.