fix: citation helm deployment

[at88mph]

Add a Helm Chart to deploy the citation application. Also included an in-page cache to alleviate multiple registry calls from the browser.

Changes

• New Helm Chart in the citation/helm folder
  • ArgoCD ready
• Small change to only call registry once per lookup and cache for faster page API access

[at88mph]

@jburke-cadc @WenbinWL Could one of you review this? Once accepted I can complete that Story and we can deploy this to the new Kubernetes Cluster.

[WenbinWL]

A few concerns:

1. I think we should confirm this image repository before merging.
   @pdowler mentioned that images.opencadc.org is intended for open-source images, mostly a community for external users, while internal images should stay on bucket.canfar.net with imagePullSecrets.
   I also cannot verify that an images.opencadc.org/canfar project is available.
   Question: Should this chart default to bucket.canfar.net/citation, or should the repository be left empty/overridden only by deployent values?

e.g.:

image:
  repository: ""
  tag: ""

[WenbinWL]

2. The chart appVersion is 1.16.0, but the default image tag is v1.0.0 and the README says the tag should match appVersion. This will render images.opencadc.org/canfar/citation:v1.0.0(if exists) instead of using 1.16.0.
   Are we okay with not to align appVersion, image.tag, and the documented build tag?

[WenbinWL]

3. Keel staging registry may need to specify DOI lookups at the new DOI deployment
   registry looksup for: ivo://cadc.nrc.ca/doi
   I didn't notice there was a service mapping which can point the registry to the actual capabilities endpoint:

- id: "ivo://cadc.nrc.ca/doi"
     url: "https://staging.canfar.net/doi/capabilities"

my understanding:
Since citation resolves DOI endpoints through ivo://cadc.nrc.ca/doi, the Keel staging registry values also need to publish the DOI service entry for the new staging DOI deployment. Otherwise this page may continue resolving to the old ws-cadc.canfar.net DOI service even after deploying the new chart.

[pdowler]

I am strongly against publishing any images from this repo to images.opencadc.org.

The fact that this repo is in the opencadc organisation at all was a short cut I already regret.

[at88mph]

3. Keel staging registry may need to specify DOI lookups at the new DOI deployment
   registry looksup for: ivo://cadc.nrc.ca/doi
   I didn't notice there was a service mapping which can point the registry to the actual capabilities endpoint:

- id: "ivo://cadc.nrc.ca/doi"
     url: "https://staging.canfar.net/doi/capabilities"

my understanding: Since citation resolves DOI endpoints through ivo://cadc.nrc.ca/doi, the Keel staging registry values also need to publish the DOI service entry for the new staging DOI deployment. Otherwise this page may continue resolving to the old ws-cadc.canfar.net DOI service even after deploying the new chart.

Right. There is what I would think is a bug. Citation is a client application that calls the Registry using a provided baseURL, which is pulled from the incoming request origin:

        // Instantiate controller for Data Citation List page
        citation_js = new cadc.web.citation.Citation({baseURL: window.location.origin})
        citation_js.init()

We should likely have configuration passed in like other applications/services. On deployment, this application will depend on a Registry accessible from this same domain. The actual lookup is hard-coded:

      return _getCachedServiceURL(
          'ivo://cadc.nrc.ca/doi',
          'http://www.opencadc.org/std/doi#instances-1.0',
          'vs:ParamHTTP',
          'cookie'
      )

Is that passable for a first release?

[at88mph]

Is this because the doi and citation images won't be used by anybody else, @pdowler? I've moved this deployment's image to bucket.canfar.net until we get a better Harbor running.

@WenbinWL The suggested changes are in place

[WenbinWL]

Looks good to me. Thank you @at88mph.

[at88mph]

Thanks @WenbinWL . Do you have merge permission?