Skip to content

fix: make group and metadata prefixes optional #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jburke-cadc merged 3 commits into from
Aug 5, 2026
Merged

fix: make group and metadata prefixes optional #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
838f8e2
fix: make group and metadata prefixes optional
at88mph Aug 5, 2026
8f8d802
fix: only group prefix is optional
at88mph Aug 5, 2026
e8dcc4d
fix: fix to make group prefix optional and metadata prefix mandatory
at88mph Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doi/helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ maintainers:

type: application

version: 0.1.0
version: 0.1.1

appVersion: "1.2.0"
4 changes: 3 additions & 1 deletion doi/helm/config/doi.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
ca.nrc.cadc.doi.vospaceParentUri = {{ .Values.application.config.vospaceParentUri | required ".Values.application.config.vospaceParentUri is required" }}
ca.nrc.cadc.doi.metaDataPrefix = {{ .Values.application.config.metaDataPrefix | required ".Values.application.config.metaDataPrefix is required" }}
ca.nrc.cadc.doi.groupPrefix = {{ .Values.application.config.groupPrefix | required ".Values.application.config.groupPrefix is required" }}
ca.nrc.cadc.doi.landingUrl = {{ .Values.application.config.landingUrl | required ".Values.application.config.landingUrl is required" }}
ca.nrc.cadc.doi.datacite.mdsUrl = {{ .Values.application.config.mdsUrl | required ".Values.application.config.mdsUrl is required" }}
ca.nrc.cadc.doi.datacite.accountPrefix = {{ .Values.application.config.accountPrefix | required ".Values.application.config.accountPrefix is required" }}
{{- with .Values.application.config.groupPrefix }}
ca.nrc.cadc.doi.groupPrefix = {{ . }}
{{- end }}
{{- with .Values.application.config.doiIdentifierPrefix }}
ca.nrc.cadc.doi.doiIdentifierPrefix = {{ . }}
{{- end }}
Expand Down
3 changes: 2 additions & 1 deletion doi/helm/examples/values.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,11 @@ application:
config:
vospaceParentUri: vos://example.org~arc/doi
metaDataPrefix: doi
groupPrefix: doi
landingUrl: https://doi.example.org/doi
mdsUrl: https://mds.datacite.org
accountPrefix: "10.5072"
# Optional:
# groupPrefix: doi

datacite:
auth:
Expand Down
6 changes: 3 additions & 3 deletions doi/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ application:
# Prefix prepended to the DOI name for metadata stored in VOSpace.
metaDataPrefix: "doi"

# Prefix prepended to the DOI name to create the backing GMS group name.
groupPrefix: "doi"

# DOI landing page URL.
landingUrl: "https://example.org/doi"

Expand All @@ -57,6 +54,9 @@ application:
# Registered prefix for the DataCite account.
accountPrefix: ""

# Optional prefix prepended to the DOI name to create the backing GMS group name.
groupPrefix: ""

# Optional DOI identifier prefix.
doiIdentifierPrefix: ""

Expand Down
Loading