Skip to content

fix: move new Featured recommendations out of Discord - #64

Merged
Patrick-Erichsen merged 1 commit into
mainfrom
move-featured-recommendations-to-slack
Oct 31, 2026
Merged

Patrick-Erichsen merged 1 commit into
mainfrom
move-featured-recommendations-to-slack

Conversation

@Patrick-Erichsen

Copy link
Copy Markdown
Contributor

What Problem This Solves

Featured recommendations are moving to the advisory Slack review workflow. Continuing to publish them in Discord would create two places to review the same recommendations.

User Impact

For new v4 weeks ending November 2, 2026 UTC onward, Discord shows both catalogs’ search totals, collection coverage, company opportunities, official gaps and movers. Featured membership still requires the existing approval flow.

Why This Change Was Made

The receiver selects presentation by immutable week identity while preserving the complete validated payload and original delivery ownership. Old weeks keep their byte-identical formatter. An incomplete cutoff-week delivery resumes its original legacy parts only when both the full payload hash and existing ordered manifest match; conflicting or uncertain receipts retain their existing safeguards. Rollback must retain this selector and both formatters once new claims exist.

Evidence

The same fixture through the real HTTP handler, SQLite/D1 receipts and Carbon serialization produced one Featured-only message before and two search-intelligence messages after. Both returned 200; replays sent no additional messages. Discord transport was captured; no live test messages were sent.

  • 50 receiver tests pass, including partial/uncertain delivery, both concurrent manifest winners, old frozen weeks, strict validation, privacy and message bounds.
  • The presentation and compatibility regressions fail before the change and pass after it.
  • TypeScript, Worker dry-run build and independent read-only review pass. The legacy formatter prefix is byte-identical.

@clawsweeper

clawsweeper Bot commented Oct 31, 2026

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

@Patrick-Erichsen
Patrick-Erichsen merged commit cf6564f into main Oct 31, 2026
7 checks passed
@Patrick-Erichsen
Patrick-Erichsen deleted the move-featured-recommendations-to-slack branch October 31, 2026 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant