Repository navigation
fix: move new Featured recommendations out of Discord - #64
Merged
Merged
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Featured recommendations are moving to the advisory Slack review workflow. Continuing to publish them in Discord would create two places to review the same recommendations.
User Impact
For new v4 weeks ending November 2, 2026 UTC onward, Discord shows both catalogs’ search totals, collection coverage, company opportunities, official gaps and movers. Featured membership still requires the existing approval flow.
Why This Change Was Made
The receiver selects presentation by immutable week identity while preserving the complete validated payload and original delivery ownership. Old weeks keep their byte-identical formatter. An incomplete cutoff-week delivery resumes its original legacy parts only when both the full payload hash and existing ordered manifest match; conflicting or uncertain receipts retain their existing safeguards. Rollback must retain this selector and both formatters once new claims exist.
Evidence
The same fixture through the real HTTP handler, SQLite/D1 receipts and Carbon serialization produced one Featured-only message before and two search-intelligence messages after. Both returned 200; replays sent no additional messages. Discord transport was captured; no live test messages were sent.