refactor: consolidate reminder and list rendering

[steipete]

Reminder and search rendering duplicated the same row formatting, while one large renderer needed a SwiftLint type-length suppression. Share the row formatter and non-standard dispatch, group identical format cases, and move list rendering into its own extension.

Validation: isolated Codex autoreview is scoped-clean through P2; strict Swift/shell/workflow lint and all 92 tests pass; RemindCore coverage remains 93.8% (898/957); release build passes. The local Homebrew Bash stalled preparing the coverage script's Python heredoc; the unchanged script passed with /bin/bash.

Live proof: built before/after binaries produced 40 byte-identical outputs against the same disposable synthetic EventKit list: show, search, info, export, repeated list creation, status, and link across standard/table/plain/JSON/quiet, plus help/version/bash/zsh completion. The fixture included timed/repeating and completed reminders, priority, notes, and URL. All synthetic data was removed.

Exact independent head: 462ee9c9659b357aad322e106b115258a43bee99. CI. The identical reviewed patch was rebased onto main without the other cleanup commits (stable patch ID unchanged), then local gates and live binary comparisons were repeated. Isolated Codex autoreview is scoped-clean through P2.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: needs maintainer review before merge. Reviewed September 13, 2026, 2:33 AM ET / 06:33 UTC (Revision 2).

ClawSweeper review

What this changes

Shares reminder row formatting and output dispatch, combines identical format cases, and moves list rendering into a separate extension while preserving CLI output.

Merge readiness

✅ Ready for maintainer review

This remains a useful, focused cleanup absent from current main. No actionable correctness or security defect was found, and the collaborator-authored PR is protected from automatic closure.

Priority: P3
Reviewed head: 462ee9c9659b357aad322e106b115258a43bee99

Review scores

Measure	Result	What it means
Overall readiness	🐚 platinum hermit (4/6)	A focused, behavior-preserving refactor with reported production comparisons and no actionable findings.
Proof confidence	🌊 off-meta tidepool	Not applicable: The collaborator-authored PR is exempt from the external-contributor proof gate. Its body reports byte-identical before/after EventKit-backed CLI outputs covering the changed reminder and list renderers; the underlying transcript was not supplied.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Not applicable	Not applicable: The collaborator-authored PR is exempt from the external-contributor proof gate. Its body reports byte-identical before/after EventKit-backed CLI outputs covering the changed reminder and list renderers; the underlying transcript was not supplied.
Evidence reviewed	6 items	Rendering equivalence: Read both complete changed files and the complete main renderer. Search retains its standard ID suffix; other formats delegate to identical existing branches. Shared rows retain status, date intent, priority, recurrence, and sorting. The moved list table preserves the eight-character ID prefix. Current main and release status: GitHub confirms main remains the pinned base, whose renderer still contains the duplication. No local release tag contains the PR head; the supplied latest release is v0.3.6. No implemented-on-main closure is supported. Existing CLI contract: README documents stable tab-separated output and JSON/table/quiet modes. Inspected command callers, runtime format selection, and search, list-summary, and export tests; the patch changes neither their inputs nor their contracts.
Findings	None	None.
Security	None	None.

How this fits together

remindctl reads Apple Reminders through EventKit and passes reminder records and list summaries to its CLI renderer. The renderer converts those records into readable text, tables, tab-separated output, JSON, or counts.

flowchart LR
  A[Apple Reminders] --> B[Command handlers]
  C[Output flags] --> D[Format selection]
  B --> E[Reminder and list renderer]
  D --> E
  E --> F[Terminal text or structured output]

Loading

Before merge

None.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Code size	Production +68/-83, net -15 lines; tests unchanged	The two-file extraction reduces total production code while removing repeated formatting.

Technical review

Best possible solution:

Keep a shared reminder-row formatter and separate list-rendering extension while retaining the existing CLI output contract.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this refactor addresses duplicated implementation rather than a reported runtime failure; the duplication is directly visible on main.

Is this the best way to solve the issue?

Yes: extracting the identical row expression and reusing existing dispatch is a narrow solution that preserves each format's established behavior.

AGENTS.md: not found in the target repository.

Codex review notes: model internal, reasoning medium; reviewed against 1b71fb003087.

Labels

Label justifications:

• P3: This is a bounded rendering cleanup with no intended user-visible behavior change.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator-authored PR is exempt from the external-contributor proof gate. Its body reports byte-identical before/after EventKit-backed CLI outputs covering the changed reminder and list renderers; the underlying transcript was not supplied.

Evidence

What I checked:

• Rendering equivalence: Read both complete changed files and the complete main renderer. Search retains its standard ID suffix; other formats delegate to identical existing branches. Shared rows retain status, date intent, priority, recurrence, and sorting. The moved list table preserves the eight-character ID prefix. (Sources/remindctl/OutputFormatting.swift:40, 462ee9c9659b)
• Current main and release status: GitHub confirms main remains the pinned base, whose renderer still contains the duplication. No local release tag contains the PR head; the supplied latest release is v0.3.6. No implemented-on-main closure is supported. (Sources/remindctl/OutputFormatting.swift:40, 1b71fb003087)
• Existing CLI contract: README documents stable tab-separated output and JSON/table/quiet modes. Inspected command callers, runtime format selection, and search, list-summary, and export tests; the patch changes neither their inputs nor their contracts. (README.md:211, 462ee9c9659b)
• Reported production validation: The complete captured PR body reports 40 byte-identical before/after binary outputs using a disposable EventKit list, including show/search/info and standard/table/plain/JSON/quiet modes, repeated after rebasing to the pinned head. It also reports 92 passing tests and a release build. These are contributor-reported results; no raw comparison transcript or media was supplied, and this reviewer did not execute target code. (462ee9c9659b)
• Area history and routing: Available main history lists Peter Steinberger across initial rendering, date handling, recurrence, search/info, and expanded workflows. GitHub maps the search/info commit to steipete. Older blob retrieval failed with HTTP 403 during deeper follow/blame inspection, so exact source-line introduction is unverified. (Sources/remindctl/OutputFormatting.swift, 0f375f36b850)
• Review continuity and inspection limits: The previous completed review covers the same head and retains no findings or published rank-up moves. No AGENTS.md or maintainer-notes directory was found. The related-PR search endpoint rejected the read, so no canonical replacement was established. Diff whitespace checks passed and the checkout remained clean. (462ee9c9659b)

Likely related people:

• steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (1 earlier review cycle)

• reviewed 2026-09-13T06:28:03.023Z sha 462ee9c :: needs maintainer review before merge. :: none