graph: expose @libre.graph.shareTypes on driveItems - #3438
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 17 |
🟢 Coverage 81.97% diff coverage · +0.03% coverage variation
Metric Results Coverage variation ✅ +0.03% coverage variation (-1.00%) Diff coverage ✅ 81.97% diff coverage Coverage variation details
Coverable lines Covered lines Coverage Common ancestor commit (61037cc) 88237 20687 23.44% Head commit (aa968ec) 88294 (+57) 20731 (+44) 23.48% (+0.03%) Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch:
<coverage of head commit> - <coverage of common ancestor commit>Diff coverage details
Coverable lines Covered lines Diff coverage Pull request (#3438) 61 50 81.97% Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified:
<covered lines added or modified>/<coverable lines added or modified> * 100%
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
dschmidt
force-pushed
the
feat/driveitem-share-types
branch
3 times, most recently
from
September 1, 2026 12:08
d336a4c to
a1db1a9
Compare
dschmidt
marked this pull request as ready for review
September 1, 2026 12:09
dschmidt
force-pushed
the
feat/driveitem-share-types
branch
from
September 1, 2026 13:35
a1db1a9 to
024f635
Compare
butonic
force-pushed
the
feat/driveitem-share-types
branch
from
September 2, 2026 22:03
024f635 to
7a88e6b
Compare
butonic
reviewed
Sep 2, 2026
butonic
approved these changes
Sep 2, 2026
dschmidt
force-pushed
the
feat/driveitem-share-types
branch
3 times, most recently
from
September 3, 2026 07:58
31a2fe9 to
f61b9e3
Compare
dschmidt
force-pushed
the
feat/driveitem-share-types
branch
from
September 3, 2026 14:59
f61b9e3 to
aa968ec
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3437 (pendingOperations), implements opencloud-eu/libre-graph-api#58.
driveItems can carry
@libre.graph.shareTypes, listing the kinds of shares that exist on an item so a listing can render share indicators without expanding permissions. Replacesoc:share-typesfrom WebDAV PROPFIND for Graph listings.userandgroupcome from the storage grants, which the provider only reports whenshare-typesis in the field mask;linkhas to be reassembled from the public share manager, one filter per item. Both are only done when the annotation is requested via$select, mirroring WebDAV, whereoc:share-typesis inrequiresExplicitFetchingand never part of anallpropresponse. A failing public share lookup costs the link type, not the response.remoteis in the spec enum but never emitted, ocdav does not report federated shares as a share type either.