Skip to content

graph: expose @libre.graph.shareTypes on driveItems - #3438

Merged
dschmidt merged 1 commit into
mainfrom
feat/driveitem-share-types
Sep 3, 2026
Merged

dschmidt merged 1 commit into
mainfrom
feat/driveitem-share-types

Conversation

@dschmidt

@dschmidt dschmidt commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Stacked on #3437 (pendingOperations), implements opencloud-eu/libre-graph-api#58.

driveItems can carry @libre.graph.shareTypes, listing the kinds of shares that exist on an item so a listing can render share indicators without expanding permissions. Replaces oc:share-types from WebDAV PROPFIND for Graph listings.

user and group come from the storage grants, which the provider only reports when share-types is in the field mask; link has to be reassembled from the public share manager, one filter per item. Both are only done when the annotation is requested via $select, mirroring WebDAV, where oc:share-types is in requiresExplicitFetching and never part of an allprop response. A failing public share lookup costs the link type, not the response.

remote is in the spec enum but never emitted, ocdav does not report federated shares as a share type either.

@codacy-production

codacy-production Bot commented Sep 1, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 17 complexity

Metric Results
Complexity 17

View in Codacy

🟢 Coverage 81.97% diff coverage · +0.03% coverage variation

Metric Results
Coverage variation +0.03% coverage variation (-1.00%)
Diff coverage 81.97% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (61037cc) 88237 20687 23.44%
Head commit (aa968ec) 88294 (+57) 20731 (+44) 23.48% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3438) 61 50 81.97%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@dschmidt
dschmidt force-pushed the feat/driveitem-share-types branch 3 times, most recently from d336a4c to a1db1a9 Compare September 1, 2026 12:08
@dschmidt
dschmidt marked this pull request as ready for review September 1, 2026 12:09
@dschmidt
dschmidt requested review from butonic and micbar September 1, 2026 12:09
Base automatically changed from feat/driveitem-pending-operations to main September 1, 2026 13:35
@dschmidt
dschmidt force-pushed the feat/driveitem-share-types branch from a1db1a9 to 024f635 Compare September 1, 2026 13:35
@butonic
butonic force-pushed the feat/driveitem-share-types branch from 024f635 to 7a88e6b Compare September 2, 2026 22:03
Comment thread services/graph/pkg/service/v0/driveitems.go
@dschmidt
dschmidt force-pushed the feat/driveitem-share-types branch 3 times, most recently from 31a2fe9 to f61b9e3 Compare September 3, 2026 07:58
@dschmidt
dschmidt force-pushed the feat/driveitem-share-types branch from f61b9e3 to aa968ec Compare September 3, 2026 14:59
@dschmidt
dschmidt merged commit addb328 into main Sep 3, 2026
67 checks passed
@dschmidt
dschmidt deleted the feat/driveitem-share-types branch September 3, 2026 15:52
@openclouders openclouders mentioned this pull request Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants