Repository navigation
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the metadata configuration to incorporate required deviations for the Nokia platform. These changes ensure that the test environment correctly handles specific platform behaviors, facilitating consistent validation for the MPLS-in-UDP feature. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #5546 / aa3c6e2Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request adds a platform exception for Nokia with specific deviations in the metadata.textproto file. The reviewer noted that Nokia SR Linux uses lowercase 'default' as the default network instance name, and recommended adding default_network_instance: "default" to the deviations list to prevent test failures.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Please fix gemini |
|
/fptest nokia-physical |
|
Test Status: Failed Full test logs and details here: Sponge Link: http://sponge2/761cceca-e9d6-4304-8d4d-bf6d30e621f3 The failure happened in TestMPLSOUDPEncap when trying to program the gRIBI Next Hop (NH) index 1001. The device responded that MPLS-in-UDP is not enabled on the platform. Here is the specific error from the logs: <1787677976747386381 (0 nsec): AFTOperation { ID: 4, Details: <Type: Add NH Index: 1001>, Status: FAILED } With Server Error: Add operation for next hop 1001 in 'DEFAULT' with encap_header key present but MPLS over UDPv6 support is not enabled on this platform.> |
jayakumarramisetty
left a comment
There was a problem hiding this comment.
please check all comments on test failure and revert back with answer
@alokmtri-g Please use 0.0.1 image for this script, 26.7.1 version is not applicable for this script. |
Please use 0.0.1 image for this script, 26.7.1 version is not applicable for this script. |
Adding required deviations for vendor Nokia in metadata.textproto. “This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”
Adding required deviations for vendor Nokia in metadata.textproto.
“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”