Skip to content

TE-18.1: Enabling required deviation in metadata - #5546

Open
trathod1 wants to merge 1 commit into
openconfig:mainfrom
nokia:TE18dot1
Open

trathod1 wants to merge 1 commit into
openconfig:mainfrom
nokia:TE18dot1

Conversation

@trathod1

@trathod1 trathod1 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Adding required deviations for vendor Nokia in metadata.textproto.

“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”

@trathod1
trathod1 requested a review from a team as a code owner June 8, 2026 22:48
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the metadata configuration to incorporate required deviations for the Nokia platform. These changes ensure that the test environment correctly handles specific platform behaviors, facilitating consistent validation for the MPLS-in-UDP feature.

Highlights

  • Nokia Platform Deviations: Added platform-specific deviations for the Nokia vendor in the metadata configuration to ensure proper test execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot

OpenConfigBot commented Jun 8, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #5546 / aa3c6e2

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Cisco 8000E status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Cisco XRd status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Juniper ncPTX status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Nokia SR Linux status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Openconfig Lemming status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Cisco status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Juniper status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation
Nokia status
TE-18.1: pending authorization
TE-18.1: gRIBI MPLS-in-UDP Encapsulation

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a platform exception for Nokia with specific deviations in the metadata.textproto file. The reviewer noted that Nokia SR Linux uses lowercase 'default' as the default network instance name, and recommended adding default_network_instance: "default" to the deviations list to prevent test failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@alokmtri-g

Copy link
Copy Markdown
Contributor

Please fix gemini

@alokmtri-g

Copy link
Copy Markdown
Contributor

/fptest nokia-physical

@alokmtri-g

alokmtri-g commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Test Status: Failed
dut.os_version -> 26.7.1-554

Full test logs and details here: Sponge Link: http://sponge2/761cceca-e9d6-4304-8d4d-bf6d30e621f3

The failure happened in TestMPLSOUDPEncap when trying to program the gRIBI Next Hop (NH) index 1001. The device responded that MPLS-in-UDP is not enabled on the platform.

Here is the specific error from the logs:

<1787677976747386381 (0 nsec): AFTOperation { ID: 4, Details: <Type: Add NH Index: 1001>, Status: FAILED } With Server Error: Add operation for next hop 1001 in 'DEFAULT' with encap_header key present but MPLS over UDPv6 support is not enabled on this platform.>
This cascaded into failing the subsequent Next Hop Group (NHG) and IPv6 route additions since NH 1001 didn't exist.

@alokmtri-g alokmtri-g assigned trathod1 and unassigned trathod1 Aug 25, 2026

@jayakumarramisetty jayakumarramisetty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check all comments on test failure and revert back with answer

@trathod1

trathod1 commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor Author

Test Status: Failed dut.os_version -> 26.7.1-554

Full test logs and details here: Sponge Link: http://sponge2/761cceca-e9d6-4304-8d4d-bf6d30e621f3

The failure happened in TestMPLSOUDPEncap when trying to program the gRIBI Next Hop (NH) index 1001. The device responded that MPLS-in-UDP is not enabled on the platform.

Here is the specific error from the logs:

<1787677976747386381 (0 nsec): AFTOperation { ID: 4, Details: <Type: Add NH Index: 1001>, Status: FAILED } With Server Error: Add operation for next hop 1001 in 'DEFAULT' with encap_header key present but MPLS over UDPv6 support is not enabled on this platform.> This cascaded into failing the subsequent Next Hop Group (NHG) and IPv6 route additions since NH 1001 didn't exist.

@alokmtri-g Please use 0.0.1 image for this script, 26.7.1 version is not applicable for this script.

@trathod1

Copy link
Copy Markdown
Contributor Author

please check all comments on test failure and revert back with answer

Please use 0.0.1 image for this script, 26.7.1 version is not applicable for this script.

@trathod1 trathod1 closed this Nov 20, 2026
@trathod1 trathod1 reopened this Nov 20, 2026
Adding required deviations for vendor Nokia in metadata.textproto.

“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants