Repository navigation
Conversation
…infinite loop Following changes are done - 1. After reboot, script was checking only number of component between pre-reboot and post-reboot and was not validating the state of components. Made component state check as validating criteria, to make sure script waits for all components are up after the reboot. 2. Fixing checkSyncResponse if condition for time check that would never be met under failure condition to avoid infinite loop. Also adding wait of 10 seconds in that loop to avoid log runout in case of failure. “This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”
Also fixes testcode strings to reflect new value
---
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Contributor
|
/fptest physical |
Contributor
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the breakout subscription test by renaming subtests from PLT-1.2.x to PLT-1.3.x, adjusting the reboot component comparison logic, and simplifying the timeout check in checkSyncResponse. The review feedback identifies a critical bug in checkSyncResponse where a stream error can cause a nil pointer dereference and an infinite loop, and suggests sorting the component matrices before comparison to prevent flaky test failures.
Contributor
|
@trathod1 please fix gemini review |
Contributor
Author
|
Committed changes to resolve gemini comments. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes are done -
“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”