Skip to content

PLT-1.3: Fixing script for component check after reboot and avoiding infinite loop - #5691

Open
trathod1 wants to merge 6 commits into
openconfig:mainfrom
nokia:PLT1dot3
Open

trathod1 wants to merge 6 commits into
openconfig:mainfrom
nokia:PLT1dot3

Conversation

@trathod1

Copy link
Copy Markdown
Contributor

Following changes are done -

  1. After reboot, script was checking only number of component between pre-reboot and post-reboot and was not validating the state of components. Made component state check as validating criteria, to make sure script waits for all components are up after the reboot.
  2. Fixing checkSyncResponse if condition for time check that would never be met under failure condition to avoid infinite loop. Also adding wait of 10 seconds in that loop to avoid log runout in case of failure.

“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”

…infinite loop

Following changes are done -
  1. After reboot, script was checking only number of component between pre-reboot and post-reboot and was not validating the state of components. Made component state check as validating criteria, to make sure script waits for all components are up after the reboot.
  2. Fixing checkSyncResponse if condition for time check that would never be met under failure condition to avoid infinite loop. Also adding wait of 10 seconds in that loop to avoid log runout in case of failure.

“This code is a Contribution to the OpenConfig Feature Profiles project (“Work”) made under the Google Software Grant and Corporate Contributor License Agreement (“CLA”) and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia’s intellectual property are granted for any other purpose. This code is provided on an “as is” basis without any warranties of any kind.”
@trathod1
trathod1 requested a review from a team as a code owner July 11, 2026 15:21
@OpenConfigBot

OpenConfigBot commented Jul 11, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #5691 / 330a6a6

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Cisco 8000E status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Cisco XRd status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Juniper ncPTX status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Nokia SR Linux status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Openconfig Lemming status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Cisco status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Juniper status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces
Nokia status
PLT-1.3: pending authorization
PLT-1.3: OnChange Subscription Test for Breakout Interfaces

Help

Also fixes testcode strings to reflect new value

---

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@alokmtri-g

Copy link
Copy Markdown
Contributor

/fptest physical

@alokmtri-g alokmtri-g self-assigned this Sep 1, 2026
@alokmtri-g

Copy link
Copy Markdown
Contributor

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the breakout subscription test by renaming subtests from PLT-1.2.x to PLT-1.3.x, adjusting the reboot component comparison logic, and simplifying the timeout check in checkSyncResponse. The review feedback identifies a critical bug in checkSyncResponse where a stream error can cause a nil pointer dereference and an infinite loop, and suggests sorting the component matrices before comparison to prevent flaky test failures.

@alokmtri-g

Copy link
Copy Markdown
Contributor

@trathod1 please fix gemini review

@trathod1

trathod1 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Committed changes to resolve gemini comments.

@trathod1 trathod1 removed their assignment Sep 1, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants