Repository navigation
[Health-1.1] Fix Arista storage leak in generic healthz check test #6104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arnavanand-lgtm
wants to merge
5
commits into
openconfig:main
Choose a base branch
from
arnavanand-lgtm:fix-healthz-cleanup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
65bac01
Fix Arista healthz storage leak via gNOI file sweep fallback
arnavanand-lgtm 85d735d
Address review: empty artifact ID check
arnavanand-lgtm 0f4311d
Merge branch 'main' into fix-healthz-cleanup
arnavanand-lgtm 561a6f9
Merge branch 'main' into fix-healthz-cleanup
navaneethyv 724766a
Merge branch 'main' into fix-healthz-cleanup
arnavanand-lgtm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the Repository Style Guide, hardcoded vendor checks (like
dut.Vendor() == ondatra.ARISTA) should be avoided in test files. Instead, platform-specific workarounds or exceptions should be implemented as deviations.Please define a new deviation (e.g.,
ManualHealthzSweepRequired) ininternal/deviations/deviations.goandinternal/deviations/deviations.textproto, and use it here.References
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use right deviation and why is this specific to Arista ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @navaneethyv ,
Good question — we used
dut.Vendor() == ondatra.ARISTAdirectly (similar tovendorCoreFilePathin this file) because this is only post-test flash housekeeping using an EOS-specific path (/mnt/flash/persist/healthz) rather than changing any test validation or operational intent.That said, if you'd prefer tracking the
Healthz.Acknowledgefallback formally as a deviation inmetadata.proto/metadata.textproto, I'm happy to add it. Let me know which approach you prefer!