Skip to content

gnmi-1.19: add fixes and deviations - #6223

Open
dipchauh wants to merge 4 commits into
openconfig:mainfrom
nokia:gnmi1dot19
Open

dipchauh wants to merge 4 commits into
openconfig:mainfrom
nokia:gnmi1dot19

Conversation

@dipchauh

Copy link
Copy Markdown
Contributor
  • Added retry handling for SwitchControlProcessor similar to failover_test
  • Added verification for controller role change after switchover as per Readme
  • Removed redundant check for switchover-ready after gnmi.Await, since Await already fatals on timeout
  • Added existing isis_instance_enabled_required deviation for the deprecated IS-IS global instance leaf
  • Added new Nokia deviation gnmi_expand_wildcard_paths_in_get_responses_required (ref: b/579492243)

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the controller card switchover test suite by introducing robust retry mechanisms and stricter post-switchover role verification. It also adds necessary platform-specific deviations to ensure compatibility with diverse hardware requirements in the OpenConfig Feature Profiles project.

Highlights

  • Retry Logic: Implemented retry handling for the SwitchControlProcessor to improve robustness during controller card switchover.
  • Switchover Verification: Added explicit verification to confirm controller roles have successfully swapped after a switchover.
  • New Deviations: Introduced 'isis_instance_enabled_required' and 'gnmi_expand_wildcard_paths_in_get_responses_required' to support specific device requirements.
  • Code Cleanup: Removed redundant checks for 'switchover-ready' as the Await function already handles fatal timeouts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot

OpenConfigBot commented Oct 30, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6223 / c88efb2

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Cisco 8000E status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Cisco XRd status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Juniper ncPTX status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Nokia SR Linux status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Openconfig Lemming status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Cisco status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Juniper status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover
Nokia status
gNMI-1.19: pending authorization
gNMI-1.19: ConfigPush and ConfigPull after Control Card switchover

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the GNMIExpandWildcardPathsInGetResponsesRequired deviation and implements it in the controller card switchover test to enable wildcard path expansion on gRPC servers when required. It also refactors the switchover verification to retry the operation and verify that the controller roles have actually swapped. The review feedback highlights two key issues: first, calling components.FindStandbyControllerCard inside the retry loop can cause blocking or premature test failures, and should be replaced with non-blocking gnmi.Lookup calls; second, the newly added native configuration for wildcard path expansion lacks a corresponding cleanup operation, violating the repository's state reversion guidelines, and should be registered using t.Cleanup().

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@dipchauh
dipchauh marked this pull request as ready for review October 30, 2026 22:24
@dipchauh
dipchauh requested review from a team as code owners October 30, 2026 22:24
@dipchauh
dipchauh requested a review from AmrNJ October 30, 2026 22:24
…into gnmi1dot19

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
…into gnmi1dot19

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants