Repository navigation
RT-1.55: use network instance name default for SONIC - #6289
nnelluri-cisco wants to merge 3 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration for OPENCONFIG to ensure the default network instance is correctly identified as 'default'. This change is necessary to align with SONiC's requirement for network instance naming, ensuring compatibility during BGP session mode configuration tests. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #6289 / 6bd427cVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request adds a platform exception for the OPENCONFIG vendor in the metadata.textproto file of the BGP session mode configuration test, specifying the default_network_instance deviation as 'default'. There are no review comments, and I have no feedback to provide as the changes are straightforward and correct.
3499ff6 to
53332a0
Compare
SONiC accepts DEFAULT_INSTANCE only on the network instance named default. The test otherwise uses DEFAULT, so an OPENCONFIG binding never gets past network-instance configuration. Signed-off-by: nnelluri <nnelluri@cisco.com>
53332a0 to
deb8233
Compare
SONiC is now a supported Ondatra vendor, so the platform exception for RT-1.55 uses SONIC instead of OPENCONFIG. Keeps default_network_instance and default_bgp_instance_name unchanged. Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
Summary
deviations.DefaultNetworkInstance(), which isDEFAULTunless a platform exception overrides it.DEFAULT_INSTANCEtype only on the network instance nameddefault. A binding for a SONiC DUT (vendorOPENCONFIGat the time) failednetwork-instance configuration with the name
DEFAULT.default_network_instancetodefaultanddefault_bgp_instance_nametobgp. Cisco, Nokia, and Arista bindings donot match this block. Arista already sets the same network instance name on its own exception.
SONICtoDevice.Vendor). TheSONICvendor will not parse until that merges and this repo bumps Ondatra.Test plan
metadata.textprotofor RT-1.55.TestBgpSessionModeConfigurationwith a binding whose DUTvendorisSONICand confirm the network instance path usesname=default.DEFAULT.