Skip to content

RT-1.55: use network instance name default for SONIC - #6289

Open
nnelluri-cisco wants to merge 3 commits into
openconfig:mainfrom
nnelluri-cisco:rt-1.55-openconfig-default-network-instance
Open

nnelluri-cisco wants to merge 3 commits into
openconfig:mainfrom
nnelluri-cisco:rt-1.55-openconfig-default-network-instance

Conversation

@nnelluri-cisco

@nnelluri-cisco nnelluri-cisco commented Nov 16, 2026 •

Copy link
Copy Markdown

Summary

  • RT-1.55 configures the default VRF through deviations.DefaultNetworkInstance(), which is DEFAULT unless a platform exception overrides it.
  • SONiC accepts the DEFAULT_INSTANCE type only on the network instance named default. A binding for a SONiC DUT (vendor OPENCONFIG at the time) failed
    network-instance configuration with the name DEFAULT.
  • Add a SONIC platform exception that sets default_network_instance to default and default_bgp_instance_name to bgp. Cisco, Nokia, and Arista bindings do
    not match this block. Arista already sets the same network instance name on its own exception.
  • Depends on Add SONIC to Device.Vendor ondatra#160 (adds SONIC to Device.Vendor). The SONIC vendor will not parse until that merges and this repo bumps Ondatra.

Test plan

  • Diff is only metadata.textproto for RT-1.55.
  • Run TestBgpSessionModeConfiguration with a binding whose DUT vendor is SONIC and confirm the network instance path uses name=default.
  • Confirm a Cisco or Nokia binding still uses DEFAULT.

@nnelluri-cisco
nnelluri-cisco requested a review from a team as a code owner November 16, 2026 22:41
@google-cla

google-cla Bot commented Nov 16, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the configuration for OPENCONFIG to ensure the default network instance is correctly identified as 'default'. This change is necessary to align with SONiC's requirement for network instance naming, ensuring compatibility during BGP session mode configuration tests.

Highlights

  • Configuration Update for OPENCONFIG: Added a platform exception in metadata.textproto to explicitly set the default_network_instance to 'default' for the OPENCONFIG vendor.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot

OpenConfigBot commented Nov 16, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6289 / 6bd427c

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Cisco 8000E status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Cisco XRd status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Juniper ncPTX status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Nokia SR Linux status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Openconfig Lemming status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Cisco status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Juniper status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)
Nokia status
RT-1.55: pending authorization
RT-1.55: BGP session mode (active/passive)

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a platform exception for the OPENCONFIG vendor in the metadata.textproto file of the BGP session mode configuration test, specifying the default_network_instance deviation as 'default'. There are no review comments, and I have no feedback to provide as the changes are straightforward and correct.

@nnelluri-cisco
nnelluri-cisco force-pushed the rt-1.55-openconfig-default-network-instance branch from 3499ff6 to 53332a0 Compare November 16, 2026 22:43
SONiC accepts DEFAULT_INSTANCE only on the network instance named default. The test otherwise uses DEFAULT, so an OPENCONFIG binding never gets past network-instance configuration.

Signed-off-by: nnelluri <nnelluri@cisco.com>
@nnelluri-cisco
nnelluri-cisco force-pushed the rt-1.55-openconfig-default-network-instance branch from 53332a0 to deb8233 Compare November 16, 2026 22:43
SONiC is now a supported Ondatra vendor, so the platform exception for RT-1.55 uses SONIC instead of OPENCONFIG. Keeps default_network_instance and default_bgp_instance_name unchanged.

Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
@nnelluri-cisco nnelluri-cisco changed the title RT-1.55: use network instance name default for OPENCONFIG RT-1.55: use network instance name default for SONIC Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants