Repository navigation
DP-1.14: Replace no_zero_suppression with skip_sampling_qos_counters … - #6303
alokmtri-g wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the deviation handling for Juniper platforms to resolve specific issues related to QoS counter sampling. By switching to the 'skip_sampling_qos_counters' deviation, the changes prevent unexpected service restarts and timeouts that occurred when handling zero-valued drop counters. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #6303 / 275f9f9Virtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request replaces the no_zero_suppression deviation with skip_sampling_qos_counters in the basic QoS test metadata, and adds a Juniper platform exception to deviations.textproto. Feedback was provided regarding the software_version_regex value "*.*", which is invalid under Go's regexp syntax; it is recommended to omit this field entirely to match any software version.
| platforms: { | ||
| issue_url: "https://issuetracker.google.com/582681167" | ||
| platform: { | ||
| vendor: JUNIPER | ||
| software_version_regex: "*.*" | ||
| } | ||
| } |
There was a problem hiding this comment.
The software_version_regex value "*.*" is invalid under Go's regexp syntax because * is a repetition operator that must follow an expression. If you want to match any software version, you can safely omit the software_version_regex field entirely, as the deviation lookup helper in deviations.go skips the check when it is empty.
platforms: {
issue_url: "https://issuetracker.google.com/582681167"
platform: {
vendor: JUNIPER
}
}
| interface_ref_interface_id_format: true | ||
| ecn_profile_required_definition: true | ||
| no_zero_suppression: true | ||
| skip_sampling_qos_counters: true |
There was a problem hiding this comment.
Is this behavior confirmed with the vendor? This is a Cisco deviation.
There was a problem hiding this comment.
Test with Local changes passed.
Confirmed with Vendor .
| } | ||
| } | ||
| platforms: { | ||
| issue_url: "https://issuetracker.google.com/582681167" |
There was a problem hiding this comment.
This change is not required.
Replaced obsolete no_zero_suppression deviation with skip_sampling_qos_counters for Juniper to avoid live na-grpcd restarts and post-traffic SAMPLE timeouts on zero-valued drop counters (https://issuetracker.google.com/582681167).