Skip to content

DP-1.14: Replace no_zero_suppression with skip_sampling_qos_counters … - #6303

Open
alokmtri-g wants to merge 2 commits into
openconfig:mainfrom
alokmtri-g:dp-1.14-juniper-qos-deviation
Open

alokmtri-g wants to merge 2 commits into
openconfig:mainfrom
alokmtri-g:dp-1.14-juniper-qos-deviation

Conversation

@alokmtri-g

Copy link
Copy Markdown
Contributor

Replaced obsolete no_zero_suppression deviation with skip_sampling_qos_counters for Juniper to avoid live na-grpcd restarts and post-traffic SAMPLE timeouts on zero-valued drop counters (https://issuetracker.google.com/582681167).

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the deviation handling for Juniper platforms to resolve specific issues related to QoS counter sampling. By switching to the 'skip_sampling_qos_counters' deviation, the changes prevent unexpected service restarts and timeouts that occurred when handling zero-valued drop counters.

Highlights

  • Deviation Update: Replaced the obsolete 'no_zero_suppression' deviation with 'skip_sampling_qos_counters' in the QoS basic test metadata to improve stability.
  • Platform Configuration: Added a new platform-specific configuration for Juniper devices in the internal deviations definition to address issues with na-grpcd restarts and SAMPLE timeouts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot

OpenConfigBot commented Nov 19, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6303 / 275f9f9

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
DP-1.14: failure
DP-1.14: QoS basic test
e7e554f2 Log
Cisco 8000E status
DP-1.14: failure
DP-1.14: QoS basic test
217b21f9 Log
Cisco XRd status
DP-1.14: failure
DP-1.14: QoS basic test
5dc31854 Log
Juniper ncPTX status
DP-1.14: failure
DP-1.14: QoS basic test
53e4fb46 Log
Nokia SR Linux status
DP-1.14: failure
DP-1.14: QoS basic test
06942ce3 Log
Openconfig Lemming status
DP-1.14: failure
DP-1.14: QoS basic test
92d05d24 Log

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
DP-1.14: pending authorization
DP-1.14: QoS basic test
Cisco status
DP-1.14: pending authorization
DP-1.14: QoS basic test
Juniper status
DP-1.14: pending authorization
DP-1.14: QoS basic test
Nokia status
DP-1.14: pending authorization
DP-1.14: QoS basic test

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the no_zero_suppression deviation with skip_sampling_qos_counters in the basic QoS test metadata, and adds a Juniper platform exception to deviations.textproto. Feedback was provided regarding the software_version_regex value "*.*", which is invalid under Go's regexp syntax; it is recommended to omit this field entirely to match any software version.

Comment on lines +3033 to +3039
platforms: {
issue_url: "https://issuetracker.google.com/582681167"
platform: {
vendor: JUNIPER
software_version_regex: "*.*"
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The software_version_regex value "*.*" is invalid under Go's regexp syntax because * is a repetition operator that must follow an expression. If you want to match any software version, you can safely omit the software_version_regex field entirely, as the deviation lookup helper in deviations.go skips the check when it is empty.

  platforms: {
    issue_url: "https://issuetracker.google.com/582681167"
    platform: {
      vendor: JUNIPER
    }
  }

interface_ref_interface_id_format: true
ecn_profile_required_definition: true
no_zero_suppression: true
skip_sampling_qos_counters: true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this behavior confirmed with the vendor? This is a Cisco deviation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test with Local changes passed.
Confirmed with Vendor .

}
}
platforms: {
issue_url: "https://issuetracker.google.com/582681167"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not required.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants