Repository navigation
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes test resource allocation by updating the testbed configuration for two specific test suites. By migrating from an 8-link to a 5-link testbed, the changes eliminate unnecessary port reservations that were not being utilized by the underlying test logic, ensuring more efficient use of the hardware testbed infrastructure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the metadata files for the basic_encap_test and encap_decap_gre tests, changing the required testbed topology from an 8-link setup (TESTBED_DUT_ATE_8LINKS) to a 5-link setup (TESTBED_DUT_ATE_5LINKS). This optimization aligns with the repository's topology guidelines to avoid high-link-count testbeds when they are not strictly necessary, helping to reduce hardware reservation contention. There are no review comments, and I have no further feedback to provide.
| plan_id: "PF-1.23" | ||
| description: "EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload" | ||
| testbed: TESTBED_DUT_ATE_8LINKS | ||
| testbed: TESTBED_DUT_ATE_5LINKS |
There was a problem hiding this comment.
can we change the egress to 3 so that this becomes 4 link?
Summary
Prune unused ghost ports (ports 6–8) by migrating their
metadata.textprotofromTESTBED_DUT_ATE_8LINKStoTESTBED_DUT_ATE_5LINKS:feature/gribi/otg_tests/basic_encap_test/metadata.textproto(TE-16.1):testbedfromTESTBED_DUT_ATE_8LINKStoTESTBED_DUT_ATE_5LINKS.README.mdandbasic_encap_test.gouse only 5 DUT–ATE links (port1ingress andport2–port5egress); ports 6–8 are unreferenced.feature/policy_forwarding/ethomplsogre/otg_tests/encap_decap_gre/metadata.textproto(PF-1.23):testbedfromTESTBED_DUT_ATE_8LINKStoTESTBED_DUT_ATE_5LINKS.README.mdalready specifiestopologies/atedut_5.testbed, andencap_decap_gre_test.goonly configures and checksport1(custLagData) andport2–port5(coreLagData,verifyECMPLagBalance); ports 6–8 are unreferenced.Logs and analysis in b/581488452.