Skip to content

Migrate TE-16.1 and PF-1.23 from 8-link to 5-link testbed - #6305

Open
AmrNJ wants to merge 1 commit into
openconfig:mainfrom
AmrNJ:fix-cat-a-5link-pruning
Open

AmrNJ wants to merge 1 commit into
openconfig:mainfrom
AmrNJ:fix-cat-a-5link-pruning

Conversation

@AmrNJ

@AmrNJ AmrNJ commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Prune unused ghost ports (ports 6–8) by migrating their metadata.textproto from TESTBED_DUT_ATE_8LINKS to TESTBED_DUT_ATE_5LINKS:

  • feature/gribi/otg_tests/basic_encap_test/metadata.textproto (TE-16.1):
    • Changed testbed from TESTBED_DUT_ATE_8LINKS to TESTBED_DUT_ATE_5LINKS.
    • Both README.md and basic_encap_test.go use only 5 DUT–ATE links (port1 ingress and port2–port5 egress); ports 6–8 are unreferenced.
  • feature/policy_forwarding/ethomplsogre/otg_tests/encap_decap_gre/metadata.textproto (PF-1.23):
    • Changed testbed from TESTBED_DUT_ATE_8LINKS to TESTBED_DUT_ATE_5LINKS.
    • README.md already specifies topologies/atedut_5.testbed, and encap_decap_gre_test.go only configures and checks port1 (custLagData) and port2–port5 (coreLagData, verifyECMPLagBalance); ports 6–8 are unreferenced.

Logs and analysis in b/581488452.

@AmrNJ
AmrNJ requested a review from a team as a code owner November 20, 2026 07:28
@AmrNJ
AmrNJ requested a review from nflath November 20, 2026 07:28
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes test resource allocation by updating the testbed configuration for two specific test suites. By migrating from an 8-link to a 5-link testbed, the changes eliminate unnecessary port reservations that were not being utilized by the underlying test logic, ensuring more efficient use of the hardware testbed infrastructure.

Highlights

  • Testbed Migration: Migrated TE-16.1 and PF-1.23 tests from the 8-link testbed configuration to the 5-link testbed configuration.
  • Resource Optimization: Pruned unused ghost ports (6-8) by updating the metadata, aligning the testbed requirements with the actual port usage in the test implementations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot

OpenConfigBot commented Nov 20, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6305 / dd3c88e

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
status
TE-16.1: failure
PF-1.23: failure
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
ce5aa194 Log
Cisco 8000E status
status
TE-16.1: failure
PF-1.23: failure
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
c76bc65f Log
Cisco XRd status
status
TE-16.1: failure
PF-1.23: failure
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
1dd8a532 Log
Juniper ncPTX status
status
TE-16.1: failure
PF-1.23: failure
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
f5b85aad Log
Nokia SR Linux status
status
TE-16.1: failure
PF-1.23: failure
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
9a042bcf Log
Openconfig Lemming status
status
TE-16.1: failure
PF-1.23: failure
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
b57e248e Log

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
status
TE-16.1: pending authorization
PF-1.23: pending authorization
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
Cisco status
status
TE-16.1: pending authorization
PF-1.23: pending authorization
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
Juniper status
status
TE-16.1: pending authorization
PF-1.23: pending authorization
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload
Nokia status
status
TE-16.1: pending authorization
PF-1.23: pending authorization
TE-16.1: basic encapsulation tests
PF-1.23: EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the metadata files for the basic_encap_test and encap_decap_gre tests, changing the required testbed topology from an 8-link setup (TESTBED_DUT_ATE_8LINKS) to a 5-link setup (TESTBED_DUT_ATE_5LINKS). This optimization aligns with the repository's topology guidelines to avoid high-link-count testbeds when they are not strictly necessary, helping to reduce hardware reservation contention. There are no review comments, and I have no further feedback to provide.

plan_id: "PF-1.23"
description: "EthoCWoMPLSoGRE IPV4 forwarding of IPV4/IPV6 payload"
testbed: TESTBED_DUT_ATE_8LINKS
testbed: TESTBED_DUT_ATE_5LINKS

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change the egress to 3 so that this becomes 4 link?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants