Skip to content

wait time for fabric power-admin state increased - #6306

Open
mnp-juniper wants to merge 2 commits into
openconfig:mainfrom
mnp-juniper:powerfab
Open

mnp-juniper wants to merge 2 commits into
openconfig:mainfrom
mnp-juniper:powerfab

Conversation

@mnp-juniper

Copy link
Copy Markdown
Contributor

Issue:
After gnmi power-up/power-down on fabric , it takes more than 1 minute to stream the value for /components/component[name=CHASSIS0:SIB0]/fabric/state/power-admin-state.
Fix:
Increase wait time from 1 min to 5 min.

Refer:#5628

@mnp-juniper
mnp-juniper requested a review from a team as a code owner November 20, 2026 09:09
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a timing issue observed during fabric power operations. By increasing the wait duration for the power-admin-state to update, the test suite becomes more resilient to the latency inherent in the system's response after power-up or power-down commands.

Highlights

  • Increased Wait Time: Extended the timeout for the fabric power-admin-state verification from 1 minute to 5 minutes to accommodate longer processing times.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot

OpenConfigBot commented Nov 20, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #6306 / 2b962e2

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Cisco 8000E status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Cisco XRd status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Juniper ncPTX status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Nokia SR Linux status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Openconfig Lemming status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Cisco status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Juniper status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters
Nokia status
gNMI-1.18: pending authorization
gNMI-1.18: gNMI subscribe with sample mode for backplane capacity counters

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sampled_backplane_capacity_counters_test.go file to increase the timeout duration for the gnmi.Await calls from 1 minute to 5 minutes when waiting for the fabric component's power admin state to transition to both POWER_DISABLED and POWER_ENABLED. There are no review comments, and I have no feedback to provide.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants