Repository navigation
wait time for fabric power-admin state increased - #6306
mnp-juniper wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a timing issue observed during fabric power operations. By increasing the wait duration for the power-admin-state to update, the test suite becomes more resilient to the latency inherent in the system's response after power-up or power-down commands. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the sampled_backplane_capacity_counters_test.go file to increase the timeout duration for the gnmi.Await calls from 1 minute to 5 minutes when waiting for the fabric component's power admin state to transition to both POWER_DISABLED and POWER_ENABLED. There are no review comments, and I have no feedback to provide.
Issue:
After gnmi power-up/power-down on fabric , it takes more than 1 minute to stream the value for /components/component[name=CHASSIS0:SIB0]/fabric/state/power-admin-state.
Fix:
Increase wait time from 1 min to 5 min.
Refer:#5628