Repository navigation
Conversation
…OKIA TE-2.3 (gRIBI IPv6 entry with prefix length > 64): - Push and start OTG protocols after DUT configuration, then wait for IPv6 ARP (otgutils.WaitForARP) before sending traffic in TestIPv6Entry and createTrafficFlows. - Add interface_enabled deviation for NOKIA in metadata.textproto. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Pull Request Functional Test Report for #6307 / d5647ccVirtual Devices
Hardware Devices
|
|
Closing — author will file manually. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the stability of the gRIBI IPv6 entry tests by enforcing proper startup ordering. By ensuring that IPv6 ARP is resolved before traffic flows begin, the tests are less prone to timing-related failures. Additionally, the configuration logic has been refactored to be more explicit, and platform-specific metadata has been updated to support NOKIA devices. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the IPv6 entry test to ensure proper neighbor resolution before starting traffic. Specifically, it adds calls to otgutils.WaitForARP after starting OTG protocols in multiple places within ipv6_entry_test.go, aligning with the repository's style guide to prevent packet drops. It also removes the redundant OTG configuration push and protocol start from configureATE, moving them to the main test flow. Additionally, the interface_enabled: true deviation is added to the metadata exceptions. No review comments were provided, so there is no additional feedback.
Summary
TE-2.3 (
feature/gribi/otg_tests/ipv6_entry_test, gRIBI IPv6 entry with prefix length > 64):ipv6_entry_test.go: start OTG protocols after DUT configuration, then wait for IPv6 ARP (otgutils.WaitForARP) before traffic inTestIPv6EntryandcreateTrafficFlows.configureATEno longer pushes/starts the OTG config.metadata.textproto: addinterface_enabled: trueto the platform exception.