Skip to content

TE-2.3: wait for IPv6 ARP before traffic; enable interface deviation - #6307

Closed
snaragund wants to merge 1 commit into
openconfig:mainfrom
snaragund:te-2.3-ipv6-entry-arp-wait
Closed

snaragund wants to merge 1 commit into
openconfig:mainfrom
snaragund:te-2.3-ipv6-entry-arp-wait

Conversation

@snaragund

@snaragund snaragund commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

TE-2.3 (feature/gribi/otg_tests/ipv6_entry_test, gRIBI IPv6 entry with prefix length > 64):

  • ipv6_entry_test.go: start OTG protocols after DUT configuration, then wait for IPv6 ARP (otgutils.WaitForARP) before traffic in TestIPv6Entry and createTrafficFlows. configureATE no longer pushes/starts the OTG config.
  • metadata.textproto: add interface_enabled: true to the platform exception.

…OKIA

TE-2.3 (gRIBI IPv6 entry with prefix length > 64):
- Push and start OTG protocols after DUT configuration, then wait for IPv6
  ARP (otgutils.WaitForARP) before sending traffic in TestIPv6Entry and
  createTrafficFlows.
- Add interface_enabled deviation for NOKIA in metadata.textproto.

Co-authored-by: Cursor <cursoragent@cursor.com>
@snaragund
snaragund requested a review from a team as a code owner November 20, 2026 11:08
@snaragund
snaragund requested a review from gggsmith November 20, 2026 11:08
@google-cla

google-cla Bot commented Nov 20, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #6307 / d5647cc

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Cisco 8000E status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Cisco XRd status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Juniper ncPTX status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Nokia SR Linux status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Openconfig Lemming status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Cisco status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Juniper status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64
Nokia status
TE-2.3: pending authorization
TE-2.3: gRIBI IPv6 Entry with Prefix Length > 64

Help

@snaragund

Copy link
Copy Markdown
Contributor Author

Closing — author will file manually.

@snaragund snaragund closed this Nov 20, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the stability of the gRIBI IPv6 entry tests by enforcing proper startup ordering. By ensuring that IPv6 ARP is resolved before traffic flows begin, the tests are less prone to timing-related failures. Additionally, the configuration logic has been refactored to be more explicit, and platform-specific metadata has been updated to support NOKIA devices.

Highlights

  • Test Reliability: Updated the IPv6 entry test suite to explicitly wait for IPv6 ARP resolution before initiating traffic, ensuring better synchronization between the ATE and DUT.
  • Configuration Refactoring: Moved OTG configuration and protocol startup logic out of the shared configureATE function into individual test cases to allow for more granular control over the test lifecycle.
  • Platform Support: Enabled the interface_enabled flag in the metadata for the NOKIA platform to resolve specific platform-related configuration requirements.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IPv6 entry test to ensure proper neighbor resolution before starting traffic. Specifically, it adds calls to otgutils.WaitForARP after starting OTG protocols in multiple places within ipv6_entry_test.go, aligning with the repository's style guide to prevent packet drops. It also removes the redundant OTG configuration push and protocol start from configureATE, moving them to the main test flow. Additionally, the interface_enabled: true deviation is added to the metadata exceptions. No review comments were provided, so there is no additional feedback.

@snaragund snaragund changed the title TE-2.3: wait for IPv6 ARP before traffic; enable interface on NOKIA TE-2.3: wait for IPv6 ARP before traffic; enable interface deviation Nov 20, 2026
@snaragund
snaragund deleted the te-2.3-ipv6-entry-arp-wait branch November 20, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants